Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
| 2026-08-14 | claude/disabled-button-accessibility-piclvr (PR #1928) | 1988c762dfa763a38ec1b95cc9855b0db47f2054 | PR #1928 heavy review: outstanding-issues inbox count accuracy (docs only) | P2 fixed — durable summary corrected from four controls to four groups covering nine controls; no other actionable defects; no unresolved review threads | manual adversarial source pass; JSON parse + schema/count assertions; exact-head PR required CI green before fix; no provider-backed gates run |
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
| 2026-08-13 | claude/disabled-button-accessibility-piclvr | c73bba958e26e706c4957c886c9974ffcf330943 | outstanding-issues inbox request capturing the four placeholder controls #291 left native (docs only) | authored — PR #1928 opened | verify:pr-local 11/11 completed, none failed; check:outstanding-issues; check:ledger-write-discipline (re-run post-commit); prettier --check clean |
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"version": 1,
"id": "1752caad-7fac-4089-a415-d20a26e5984a",
"createdOn": "2026-08-14",
"action": "can\u0063el",
"payload": {
"requestId": "38e25384-5dcb-463d-b1b7-e0caea60bb83",
"reason": "Superseded by request 47ba09d2-64f6-47ab-8ad6-380fc3f93eee with count-accurate wording."
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"version": 1,
"id": "38e25384-5dcb-463d-b1b7-e0caea60bb83",
"createdOn": "2026-08-13",
"action": "add",
"payload": {
"pri": "P3",
"type": "task",
"summary": "Four placeholder controls still carry native disabled after the #291 conversion",
"detail": "**Outcome:** every control that is unavailable for a stated reason uses the aria-disabled + inert-handler shape decided in #291, or has a recorded reason why it does not. **Detail:** PR #1778 converted 25 sites and settled the encoding, but deliberately left four, and they were recorded only in that PR body — this row exists so they survive it. All four verified still native on main at 2d27039. (1) differentials/differential-presentation-workflow-page.tsx — four 'not available in this comparison view' placeholders (lines 216, 226, 607, 619) plus the Compact/Detailed density pair at 798; they qualify for conversion, but the page is scheduled for a rewrite and tests/mobile-interaction-regressions.test.ts:80 still pins the density pair as native-only (not.toContain aria-disabled), so converting means editing that pin too. Do it with the rewrite, not before. (2) document-viewer/document-image-filmstrip.tsx:45 'Page unknown' — untouched because a parallel session owned that subtree during #1778. (3) DocumentViewer.tsx summarizeTitle (907, used at 1215) is genuinely ambiguous and is the only one needing a decision rather than an edit: it folds a persistent auth reason ('Sign in before answering from this document') and a transient loading state behind one canSummarizeDocument flag, so it is half stated-reason and half transient. Split the flag before classifying it. (4) clinical-dashboard/search-pins-menu.tsx:453 'Maximum N pins reached' — states a reason but is a capacity state the user clears by deleting a pin; left native as transient. Recorded as a judgement call, not an oversight. **Next:** (3) is the only one with real design content — split the summarize flag, then classify each half. (1) rides the presentation-page rewrite. (2) is a mechanical conversion once the subtree is free. (4) needs no action unless the transient reading is rejected. **Stop:** do not convert (1) ahead of the rewrite while that test pins the old shape, and do not 'tidy' (4) into aria-disabled without deciding that a capacity limit is a stated reason — that is the same category question #291 settled for placeholders, not for limits.",
"source": "PR #1778 body; session 2026-08-13; verified against main 2d27039"
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"version": 1,
"id": "47ba09d2-64f6-47ab-8ad6-380fc3f93eee",
"createdOn": "2026-08-14",
"action": "add",
"payload": {
"pri": "P3",
"type": "task",
"summary": "Four follow-up groups cover nine controls after #291",
"detail": "Six controls in the differential comparison page stay coupled to its planned rewrite and pinned density test. The filmstrip Page unknown control is a later mechanical change. DocumentViewer needs its persistent access reason split from transient loading before classification. The pin-limit control remains a capacity-state judgement. These are four source groups and nine controls, not four controls.",
"source": "PR #1778 body; verified against main 2d27039"
}
}
Loading