Skip to content

feat(factsheets): add per-category counts; correct the eviction claim (PR D) #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BigSimmo merged 5 commits into from
Aug 13, 2026
Merged

feat(factsheets): add per-category counts; correct the eviction claim (PR D) #1888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1d968e5
feat(factsheets): add per-category counts; correct the eviction claim…
claude Aug 12, 2026
9551507
Merge origin/main into claude/filter-contract-factsheets-pr-d
claude Aug 12, 2026
8d04724
docs(ledger): record PR #1888 review row (factsheets filter contract)
claude Aug 12, 2026
f8930c3
Merge branch 'main' into claude/filter-contract-factsheets-pr-d
BigSimmo Aug 12, 2026
3749e14
Merge main into claude/filter-contract-factsheets-pr-d
BigSimmo Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ords/33f8fcf0543655449bf077fbb7595b849f39599f7d54238755ee9a649967f25a.record.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
| 2026-08-12 | PR #1888 (claude/filter-contract-factsheets-pr-d) | 95515078031b4bd29d90f05986dc5eb3a36ce660 | factsheets category counts, filter-contract correction, desktop-rail exception decision | Filter contract PR D — corrected the earlier false claim that factsheets' category presets discard the query and need eviction (searchHref preserves q); kept the desktop rail as real Link elements rather than converging to SegmentedControl because /factsheets/search is a genuine server-rendered searchParams route, recorded as a documented exception in filter-contract.md; added per-query category counts to both breakpoints from one shared options array. verify:pr-local full green pre- and post-merge; bundle budget within tolerance; UI proved with pinned-Chromium Playwright (11/11) and the updated ui-smoke.spec.ts factsheets test against a real build. /issues #170 updated to correct its own stale factsheets claim. | verify:pr-local (green), check:bundle-budget (within tolerance), lint, typecheck, full vitest (564/564 post-merge), targeted Playwright (1/1) + manual browser script (11/11) |
1 change: 1 addition & 0 deletions ...ords/770c855f8ddb79707f4ddb49b266ea1f4d27795aa33fcc02f099586e423c15b2.record.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
| 2026-08-13 | PR #1888 / claude/filter-contract-factsheets-pr-d | f8930c36d11a15820bd0a76aa6b4ff24928db224 | PR #1888 fresh heavy review-and-fix before required main sync | Dispositioned the PR delta as superseded by current main: retained main's shared counted SegmentedControl, selected dead-end handling, dedicated DOM coverage, and current filter contract; no remaining high-confidence PR-introduced P0-P2 defect. | historical exact-head PR required and Production UI green; current-main factsheets component, contract, and tests reviewed; CodeRabbit unavailable (spending cap), distinct manual adversarial pass |
Loading