Fix phone search suggestion ticker regression - #1834
Conversation
…store-phone-suggestion-ticker
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughChangesThe search header enables a phone suggestion ticker on shared and standalone home routes. The universal search surface renders the ticker, pauses hint rotation during interaction, and updates and focuses the search input when a suggestion is selected. Tests cover ticker visibility and interaction. Phone suggestion ticker
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant HomeRoute
participant MasterSearchHeader
participant UniversalSearchCommandSurface
participant SearchInput
HomeRoute->>MasterSearchHeader: Enable phone suggestion ticker
MasterSearchHeader->>UniversalSearchCommandSurface: Pass ticker visibility
UniversalSearchCommandSurface->>SearchInput: Update query and focus input
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed: dependency version conflict. Check your lock file or package.json. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 44f7fa58aa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex resolve actionable Codex review findings for this pull request and current head using the repository instructions. This is the pull request's single automatic repair pass: do not perform a fresh review, create new standalone findings, or request another review. Work only the existing unresolved Codex threads on the current head. The only repository destination is BigSimmo/Database, and the only branch destination is the pull request head branch codex/restore-phone-suggestion-ticker at starting commit 44f7fa5; never publish fixes to a detached or synthetic work branch and never create a stacked pull request. Use the authenticated GitHub connector to commit each approved fix to BigSimmo/Database:codex/restore-phone-suggestion-ticker, then verify that the pull request head contains the published commit before reporting success. Always fix P0 and P1 findings. For P2 and lower findings, fix only clear, scoped, low-risk issues; otherwise disposition them with a concise reason. For a fixed thread, reply with as the first line and as the second line. For a no-code disposition, use followed by . These result markers authorize the workflow to close that exact thread only after it verifies a fixed commit is the pull request head; a local-only commit is not a fix. If publication or verification fails, do not use either result marker, do not claim success, and leave the thread open with the blocker. If human input or new authorization is required, do the same. Finish only after every actionable thread is fixed or dispositioned and closed, or explicitly left open for a human decision. Do not update the branch from main, address unrelated reviews, broaden scope, or create more than one scoped fix commit. Do not use external APIs, paid services, credentials, dependency changes, or broad refactors unless explicitly authorized. Add targeted tests where behavior changes and run the narrowest relevant validation. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #9803 (failure). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
There was a problem hiding this comment.
Pull request overview
Restores the phone-only tappable search suggestion ticker while preserving desktop suggestions.
Changes:
- Adds rotating ticker interaction and click-to-fill behavior.
- Enables the ticker across shared search shells.
- Adds focused phone Chromium coverage.
- Blocking:
/documentsremains excluded becauseshowSharedHomeonly covers/.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/components/ClinicalDashboard.tsx |
Enables the ticker on the shared home. |
src/components/clinical-dashboard/global-search-shell.tsx |
Enables it for standalone mode homes. |
src/components/clinical-dashboard/master-search-header.tsx |
Threads the ticker flag into the command surface. |
src/components/clinical-dashboard/universal-search-command-surface.tsx |
Implements ticker rendering and interaction freezing. |
tests/ui-overlap.spec.ts |
Tests phone visibility, sizing, naming, and click-to-fill. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@copilot Fix the code for all comments in this review thread. When a review comment includes a suggested change, apply the suggestion exactly. Do not make changes beyond what is described in the linked review thread. |
… just / Co-authored-by: BigSimmo <87357024+BigSimmo@users.noreply.github.com>
Head branch was pushed to by a user without write access
Fixed in the latest commit. Changed |
Summary
RAG impact: no retrieval behaviour change — this restores client-side presentation and selection of existing prompt examples only.
Verification
npm run verify:pr-localVerification not run: the full PR-local stack was not repeated after the targeted production Playwright build already compiled TypeScript and built successfully; repository focused-test capacity was subsequently occupied by other worktrees.
npm run verify:uiwhen UI, routing, styling, browser behavior, reduced-motion, or forced-colors behavior changedUI verification partial:
npm run verify:phone-chrome -- --files ...entered the full Chromium matrix but exceeded the 30-minute tool window. Its artifacts reproduced two unrelated/servicesdesktop scroll-runway timeouts. No complete pass count was emitted, so the broad gate is not claimed green.npm run verify:releasebefore release or handoff confidence claimsRelease verification not run: this is a focused regression fix and release confidence was not requested.
Completed checks:
npm run test:e2e -- tests/ui-overlap.spec.ts --project=chromium --grep "phone smart search replaces desktop rows with one tappable ticker"—1 passed (3.7s); production build and TypeScript compilation succeeded.npm run lint— passed with zero warnings.npm run check:runtime— Node 24.19.0 and npm 11.17.0 passed.npm run check:installed-lock-parity— passed for 755 package locations and 51,732 files.npm run formatand exact changed-file Prettier check — passed.git diff --check— passed.Risk and rollout
Clinical Governance Preflight
Not applicable: no ingestion, retrieval/ranking, source rendering, document access, privacy, production environment, or clinical output behavior changed.
Notes
SmartRotatingHintimplementation after PR Add tappable iPhone suggestion ticker optimized for phone home composer #1805 had introduced the ticker.Summary by CodeRabbit
New Features
Tests