feat(privacy): Quiet Signal production page with elevated processing map - #1833
Conversation
Replace the card-stack privacy page with the Quiet Signal design: sticky amber Important (Full/Less), processing map, accordion with gists, and a desktop Signal Index — without phone number chips. Keep governance copy pinned and shared for privacy-ui tests.
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 29 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
Comment |
Drop the redundant shield beside ClinicalBadge, use a compact Full/Less face with a tap-sized hit area, and warm the expanded Important panel so it stays fused to the amber signal.
CI triageCI failed on this PR. Automated classification of the 3 failed job(s):
Compared with main CI run #9819 (cancelled). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 33bef1cb9b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex resolve actionable Codex review findings for this pull request and current head using the repository instructions. This is the pull request's single automatic repair pass: do not perform a fresh review, create new standalone findings, or request another review. Work only the existing unresolved Codex threads on the current head. The only repository destination is BigSimmo/Database, and the only branch destination is the pull request head branch cursor/privacy-quiet-signal-adopt-bc81 at starting commit 33bef1c; never publish fixes to a detached or synthetic work branch and never create a stacked pull request. Use the authenticated GitHub connector to commit each approved fix to BigSimmo/Database:cursor/privacy-quiet-signal-adopt-bc81, then verify that the pull request head contains the published commit before reporting success. Always fix P0 and P1 findings. For P2 and lower findings, fix only clear, scoped, low-risk issues; otherwise disposition them with a concise reason. For a fixed thread, reply with as the first line and as the second line. For a no-code disposition, use followed by . These result markers authorize the workflow to close that exact thread only after it verifies a fixed commit is the pull request head; a local-only commit is not a fix. If publication or verification fails, do not use either result marker, do not claim success, and leave the thread open with the blocker. If human input or new authorization is required, do the same. Finish only after every actionable thread is fixed or dispositioned and closed, or explicitly left open for a human decision. Do not update the branch from main, address unrelated reviews, broaden scope, or create more than one scoped fix commit. Do not use external APIs, paid services, credentials, dependency changes, or broad refactors unless explicitly authorized. Add targeted tests where behavior changes and run the narrowest relevant validation. |
Summary
Testing
|
Rebuild /privacy to match Quiet-scroll DNA: brand mark header with signal badge and Draft on the right, full-bleed Important row with spine/shield/uppercase label, denser accordion, 80rem measure, desktop Signal Index, and compact processing-map pills on phone — still no phone number chips.
Replace the dual-mount pill strip (which clipped External on phone) with one stacked/3-col instrument card, drop the duplicate aria region, and stop the Quiet badge and page title from truncating on 320px.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Align the production Quiet Signal page with design-system tokens (text roles, tracking scale, elevation, tap sizes), drop sticky chrome when it exceeds the viewport so accordion hits remain reachable at large text, and update the standalone shell contract for the owned safe-area pad. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Babysit update (
|
| Blocker | Fix |
|---|---|
Static / design-system (text-soft, legacy tap h-11, tracking literals, shadow-tight, colour-only LiveDot, raw padding) |
Quiet Signal page now uses design tokens / elevation / min-h-tap |
Unit / search-page-shell-standalone.contract |
Contract updated for Quiet Signal’s owned safe-area pad |
| Codex P1: sticky chrome covers accordion at 200% text | Drop sticky when chrome height ≥ viewport |
Sentry: useLayoutEffect under renderToStaticMarkup |
Switched to useEffect |
Review threads replied + resolved. Local proof: check:design-system-contract pass; privacy + shell contract tests 7/7. Leaving merge/auto-merge to you.
Replace in-flow stacked rows with the Quiet Signal instrument strip — tone-washed three-column cells, MapPin marks, fused under Important — so regions stay visible without Live Signal circle jump chips. Phone gets Expand all and denser accordion rhythm.
cursor
Bot
changed the title
2 participants
Summary
/privacy: sticky header + Important + processing instrument, accordion with gists, desktop Signal Index — no Live Signal phone jump chips (01 Tool/02 Collected…).tracking-kicker/tracking-display/tracking-eyebrow,min-h-tap,--e1, named Live status) and standalone shell safe-area contract.Verification
./node_modules/.bin/vitest run tests/privacy-ui.test.ts tests/search-page-shell-standalone.contract.test.ts— 7 passednpm run verify:pr-local— Cloud VM lock drift (nextinstalled vs locked) blocked the broad gate; focused tests above cover the changed surfaceverify:uinot proportionate; focused Chromium screenshots taken via computer-use agentRisk and rollout
tests/privacy-ui.test.ts. Sticky chrome is taller with the fused map; oversized banners drop sticky so accordion hits stay reachable./privacysurface.Clinical Governance Preflight
Clinical KB Database(sjrfecxgysukkwxsowpy)Notes
src/lib/privacy-page-content.tsxis unchanged.