Refine recent searches: compact rectangular chips & style-contract registration - #1819
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 51 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe change adds responsive styling for home recent-search chips and applies the new class in ChangesHome recent-search styling
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ddcea60336
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex resolve actionable Codex review findings for this pull request and current head using the repository instructions. This is the pull request's single automatic repair pass: do not perform a fresh review, create new standalone findings, or request another review. Work only the existing unresolved Codex threads on the current head. The only repository destination is BigSimmo/Database, and the only branch destination is the pull request head branch codex/improve-design-of-recent-searches at starting commit ddcea60; never publish fixes to a detached or synthetic work branch and never create a stacked pull request. Use the authenticated GitHub connector to commit each approved fix to BigSimmo/Database:codex/improve-design-of-recent-searches, then verify that the pull request head contains the published commit before reporting success. Always fix P0 and P1 findings. For P2 and lower findings, fix only clear, scoped, low-risk issues; otherwise disposition them with a concise reason. For a fixed thread, reply with as the first line and as the second line. For a no-code disposition, use followed by . These result markers authorize the workflow to close that exact thread only after it verifies a fixed commit is the pull request head; a local-only commit is not a fix. If publication or verification fails, do not use either result marker, do not claim success, and leave the thread open with the blocker. If human input or new authorization is required, do the same. Finish only after every actionable thread is fixed or dispositioned and closed, or explicitly left open for a human decision. Do not update the branch from main, address unrelated reviews, broaden scope, or create more than one scoped fix commit. Do not use external APIs, paid services, credentials, dependency changes, or broad refactors unless explicitly authorized. Add targeted tests where behavior changes and run the narrowest relevant validation. |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
Pull request overview
Refines recent-search chips on the shared home surface with a compact visual treatment.
Changes:
- Adds scoped desktop and mobile chip styling.
- Applies the variant to recent searches.
- Registers a style-contract exemption, but its claimed visual/mobile coverage is incomplete.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/app/globals.css |
Defines the compact chip presentation. |
src/components/clinical-dashboard/answer-status.tsx |
Applies the new styling class. |
tests/helpers/style-contracts.ts |
Adds the disputed contract exemption. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #9791 (failure). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
Babysit summary (PR #1819)
Fixed on this head
Local proof
Residual
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/ui-smoke.spec.ts (1)
2570-2582: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winCover the coarse-pointer media query.
The 390×844 viewport tests the width query only. Add a Chromium-only touch-emulated case with
hasTouch: trueand assert the chip’s computedmin-heightisvar(--spacing-tap).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/ui-smoke.spec.ts` around lines 2570 - 2582, Extend the mobile recent-search test around recentChips with a Chromium-only touch-emulated case using a context or page configured with hasTouch: true. At the 390×844 viewport, assert the chip element’s computed min-height equals var(--spacing-tap), while preserving the existing width-query assertions.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tests/ui-smoke.spec.ts`:
- Around line 2570-2582: Extend the mobile recent-search test around recentChips
with a Chromium-only touch-emulated case using a context or page configured with
hasTouch: true. At the 390×844 viewport, assert the chip element’s computed
min-height equals var(--spacing-tap), while preserving the existing width-query
assertions.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e51f7404-b160-4680-9568-0e6cb20e4a52
📒 Files selected for processing (5)
src/app/globals.csssrc/components/clinical-dashboard/answer-status.tsxtests/helpers/style-contracts.tstests/ui-smoke.spec.tstests/ui-style-contract.spec.ts
Babysit snapshot (scope: babysit)
Actionable defects reviewed on this head
Required checks run locally
Ledger
Residual risk
Merge is left to you. |
Babysit PR summary
|
Codex babysit summary (scope babysit)
Merge remains blocked pending the external required check. |
Babysit snapshot (2026-08-12)
I reproduced the exact journey locally with: No PR-scope defect was identified and no in-scope fix was applied. Ledger: appended under scope |
Babysit review summary
|
|
Unblock snapshot (latest head):
Resolved blocker(s):
Required checks on this tip:
Additional check evidence:
Residual risk:
|
Motivation
Description
home-recent-searchespresentation insrc/app/globals.cssthat converts the pill chips into compact, softly rounded rectangular chips with reduced height, lighter background, smaller icon, and tuned hover/pressed styles while preserving--spacing-tapfor coarse pointers.className="home-recent-searches justify-center"to theAnswerSuggestionChipsusage insrc/components/clinical-dashboard/answer-status.tsx.home-recent-searchestoSTYLE_CONTRACT_EXEMPTIONSintests/helpers/style-contracts.tswith a concise reason why it is covered behaviourally.src/app/globals.css,src/components/clinical-dashboard/answer-status.tsx, andtests/helpers/style-contracts.tsand are purely presentational and scoped to the home recent-search surface.Testing
npm run test -- --run tests/answer-preferences.dom.test.tsxand it passed (7 tests).npm run test:e2e -- tests/ui-smoke.spec.ts --project=chromium --grep "recent searches appear on the answer home"and the recent-search journey passed.npm run test -- --run tests/style-contract-registry.test.ts tests/document-viewer-page-virtualization.dom.test.tsxand both passed in the focused rerun.npm run verify:pr-local); formatting, lint and typecheck passed and the verification plan executed, but the full suite encountered unrelated test failures/timeouts in thepr-handoff-stophook and other unrelated, environment-sensitive tests (these are outside the UI recent-search change and reproduced independently); the targeted, focused tests described above are green.Codex Task
Summary by CodeRabbit
Style
Tests