Remove card styling from phone “Try this” ticker and tighten mode‑home spacing - #1808
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 11 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe home interface now uses tighter hero spacing. The phone ticker has reduced spacing and padding, with a transparent background and no border, rounded treatment, or inset shadow. ChangesHome UI compactness
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/app/globals.css (1)
1825-1827: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winReuse shared spacing tokens for the new values.
The declarations introduce raw
remdesign values. Reference existing Tailwind 4 spacing tokens, or define shared values in@themeif they do not exist. Keep these component variables as aliases to the shared scale.As per coding guidelines,
**/*.{ts,tsx,css}must use Tailwind 4@themetokens instead of introducing hardcoded design values.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/app/globals.css` around lines 1825 - 1827, Update the smart-search ticker variables near --smart-search-phone-ticker-gap, --smart-search-phone-ticker-inline-padding, and --smart-search-phone-ticker-vertical-padding to reference existing Tailwind 4 spacing tokens instead of raw rem values; if suitable tokens do not exist, define shared values in `@theme` and alias these component variables to them.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/app/globals.css`:
- Line 1828: Insert a blank line immediately before the min-height declaration
in the affected stylesheet rule so it satisfies the configured
declaration-empty-line-before Stylelint rule.
---
Nitpick comments:
In `@src/app/globals.css`:
- Around line 1825-1827: Update the smart-search ticker variables near
--smart-search-phone-ticker-gap, --smart-search-phone-ticker-inline-padding, and
--smart-search-phone-ticker-vertical-padding to reference existing Tailwind 4
spacing tokens instead of raw rem values; if suitable tokens do not exist,
define shared values in `@theme` and alias these component variables to them.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 2348c8af-95bb-4dae-b865-dc60a85a5cb4
📒 Files selected for processing (2)
src/app/globals.csssrc/components/mode-home-template.tsx
Unblock snapshot for PR #1808
What blocked:
Required checks snapshot:
Residual risk:
Merge left to you. |
Unblock sweep snapshot
What was fixed/dispositioned
Residual risks
|
Motivation
Description
src/app/globals.css—.smart-search-phone-tickerand related rules)src/components/mode-home-template.tsx—ModeHomeHerogrid gap)Testing
npm run formatand applied changes successfully.npm run test -- --run tests/shared-home-empty-state.dom.test.tsxand it passed (15 tests passed).artifacts/phone-search-ticker.pngand programmatically inspected the ticker to confirmborder: 0,background: transparent, and preserved48pxtap height; the visual check succeeded.Codex Task
Summary by CodeRabbit