fix(therapy): use phone space more effectively - #1799
Conversation
…cards-20260810 # Conflicts: # src/components/therapy-compass/therapy-card.tsx
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
📝 WalkthroughWalkthroughChangesTherapy Result Card
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed: dependency version conflict. Check your lock file or package.json. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/components/therapy-compass/therapy-card.tsx (1)
64-65: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winMove responsive grid sizing into named theme tokens.
Define the desktop column sizing in
src/app/globals.cssunder@themewith the--grid-template-columns-*namespace. Then use the generatedmd:grid-cols-*utility insrc/components/therapy-compass/therapy-card.tsx.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/therapy-compass/therapy-card.tsx` around lines 64 - 65, Move the desktop grid column definition from the inline md:grid-cols value on the therapy card’s outer grid into a named --grid-template-columns-* token under `@theme` in globals.css. Update the therapy-card grid to use the generated md:grid-cols-* utility, preserving the existing responsive column sizing and all other layout classes.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/components/therapy-compass/therapy-card.tsx`:
- Around line 64-65: Move the desktop grid column definition from the inline
md:grid-cols value on the therapy card’s outer grid into a named
--grid-template-columns-* token under `@theme` in globals.css. Update the
therapy-card grid to use the generated md:grid-cols-* utility, preserving the
existing responsive column sizing and all other layout classes.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f1688f95-a20d-4961-9163-e91b2002f972
📒 Files selected for processing (3)
src/components/therapy-compass/therapy-card.tsxtests/therapy-compass-responsive-contract.test.tstests/ui-route-coverage.spec.ts
…date mergeability
Babysit / unblock summary
|
Summary
mainand keep the unavailable favourite control explicitly disabledVerification
npm run format— passed; no formatting changes remainednpm run test -- tests/therapy-compass-responsive-contract.test.ts tests/therapy-card-preview.test.ts— 2 files passed, 21 tests passednpm run test:e2e -- tests/ui-route-coverage.spec.ts --project=chromium --grep "Therapy result cards use the full phone width"— production build and TypeScript passed; 1 Playwright test passed across 320, 390, 639, 768, 1440, and 1920px, including keyboard navigation, reduced motion, and forced coloursnpm run verify:pr-local— partial: runtime, lock parity, changed-file formatting, lint, and typecheck passed; the full unit stage then reported 22 failures in unchanged Windows/bundle test owners (bundle-budget.test.tsandpr-handoff-stop.test.ts), so later build/RAG-fixture steps were not reachedRisk and limitations
Rollback
Revert this PR.
Summary by CodeRabbit
UI Improvements
Bug Fixes