Skip to content

fix(dsm): clean search header and remove catalogue page strip - #1775

Merged
BigSimmo merged 8 commits into
mainfrom
cursor/dsm-search-header-fix-15d6
Aug 9, 2026
Merged

fix(dsm): clean search header and remove catalogue page strip#1775
BigSimmo merged 8 commits into
mainfrom
cursor/dsm-search-header-fix-15d6

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Aug 9, 2026

Copy link
Copy Markdown
Owner

Summary

  • Remove the redundant /dsm/search page header (back crumb, “Diagnosis catalogue”, “Diagnosis search”, description) so the page leads with the shared results ribbon under ModeNav.
  • Restyle the DSM category filter trigger as a single full-width inset control with a plain tabular count (no same-tone pill that disappeared into the filter row).
  • Move the Compare CTA into SearchResultsHeaderBand utilityControls when two+ diagnoses are selected, and set headingLevel={1} so the query remains the page heading.

Verification

  • npx vitest run tests/dsm-search-empty-state.dom.test.tsx — 2 passed
  • npm run test — 545 files / 5857 passed
  • npm run lint — pass
  • npm run typecheck — pass
  • Phone check via npm run ensure at http://localhost:4461/dsm/search?q=Delirium — old page strip absent; ribbon shows 27 DSM diagnoses | Delirium; category filter shows visible 146 count

DSM search header on phone after fix

UI verification not run: full verify:ui skipped; focused phone owner check of /dsm/search was sufficient for this DSM-local chrome change.

Clinical Governance Preflight

Not applicable — UI chrome only on the DSM catalogue search page; no retrieval, ranking, answer generation, ingestion, document access, privacy, or production env changes.

To show artifacts inline, enable in settings.

Open in Web Open in Cursor 

Remove the redundant Diagnosis search page strip so /dsm/search leads with
the shared results band, move Compare into band utilities, and restyle the
category filter as a single inset control with a visible count.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 34 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3a65df00-bdf5-42bd-a127-3ddefc54e3ba

📥 Commits

Reviewing files that changed from the base of the PR and between 39973f0 and 3d9f7f0.

📒 Files selected for processing (3)
  • docs/branch-review-ledger.md
  • src/components/dsm/dsm-search-page.tsx
  • tests/dsm-search-empty-state.dom.test.tsx

Comment @coderabbitai help to get the list of available commands.

@supabase

supabase Bot commented Aug 9, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

CI triage

CI failed on this PR. Automated classification of the 2 failed job(s):

  • Production UI (1)needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
  • PR requiredmain-side: the same job also failed on the latest completed main CI run.

Compared with main CI run #9458 (failure).

Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger.

…x-15d6

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@BigSimmo
BigSimmo marked this pull request as ready for review August 9, 2026 07:32
…Hub DIRTY/staleness)

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes redundant DSM search chrome and consolidates controls into the shared results ribbon.

Changes:

  • Promotes the search query ribbon to the page heading.
  • Restyles the category filter and relocates the Compare action.
  • Adds DOM regression coverage.

No high-confidence defects found. Static review only; full UI verification was not rerun.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/components/dsm/dsm-search-page.tsx Simplifies header and filter/compare layout.
tests/dsm-search-empty-state.dom.test.tsx Verifies removed chrome and heading hierarchy.
docs/branch-review-ledger.md Records the change and reconciles ledger rows.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@BigSimmo
BigSimmo enabled auto-merge (squash) August 9, 2026 09:34
@BigSimmo
BigSimmo merged commit 7a4ffe2 into main Aug 9, 2026
26 checks passed
@BigSimmo
BigSimmo deleted the cursor/dsm-search-header-fix-15d6 branch August 9, 2026 09:45
cursor Bot pushed a commit that referenced this pull request Aug 9, 2026
Clear behind-but-clean drift after main advanced (#1775); merge-tree was clean.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants