fix(dsm): clean search header and remove catalogue page strip - #1775
Conversation
Remove the redundant Diagnosis search page strip so /dsm/search leads with the shared results band, move Compare into band utilities, and restyle the category filter as a single inset control with a visible count. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 34 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #9458 (failure). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
…x-15d6 Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
…Hub DIRTY/staleness) Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Removes redundant DSM search chrome and consolidates controls into the shared results ribbon.
Changes:
- Promotes the search query ribbon to the page heading.
- Restyles the category filter and relocates the Compare action.
- Adds DOM regression coverage.
No high-confidence defects found. Static review only; full UI verification was not rerun.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/components/dsm/dsm-search-page.tsx |
Simplifies header and filter/compare layout. |
tests/dsm-search-empty-state.dom.test.tsx |
Verifies removed chrome and heading hierarchy. |
docs/branch-review-ledger.md |
Records the change and reconciles ledger rows. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Clear behind-but-clean drift after main advanced (#1775); merge-tree was clean. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Summary
/dsm/searchpage header (back crumb, “Diagnosis catalogue”, “Diagnosis search”, description) so the page leads with the shared results ribbon under ModeNav.SearchResultsHeaderBandutilityControlswhen two+ diagnoses are selected, and setheadingLevel={1}so the query remains the page heading.Verification
npx vitest run tests/dsm-search-empty-state.dom.test.tsx— 2 passednpm run test— 545 files / 5857 passednpm run lint— passnpm run typecheck— passnpm run ensureathttp://localhost:4461/dsm/search?q=Delirium— old page strip absent; ribbon shows27 DSM diagnoses | Delirium; category filter shows visible146countDSM search header on phone after fix
UI verification not run: full
verify:uiskipped; focused phone owner check of/dsm/searchwas sufficient for this DSM-local chrome change.Clinical Governance Preflight
Not applicable — UI chrome only on the DSM catalogue search page; no retrieval, ranking, answer generation, ingestion, document access, privacy, or production env changes.
To show artifacts inline, enable in settings.