fix(runtime): declare and enforce the Node 24.15 floor dependencies already require - #1771
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 40 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (13)
Comment |
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XZHZjz6kX8Ly1qBvvCg29C
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3df3cb3993
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… floor supported_runtime (was satisfies_floor) checked only the lower bound, so a container shipping Node 25+ with no cached $NODE_BIN was treated as supported. The hook skipped provisioning 24.19.0 and handed npm ci a runtime that engine-strict rejects against ">=24.15.0 <25" — the same blind spot as the major-only check this branch already fixed, mirrored to the other end of the range. Raised by Codex review on PR #1771. Verified against the real predicate extracted from the hook: 24.13.0, 24.14.9, 25.0.0, 26.0.0, empty and malformed input all provision the pinned Node; 24.15.0 and 24.19.0 are accepted. Malformed input fails toward installing. Also pins the hook's bounds to package.json engines.node by test, alongside the existing preinstall-hook pin, and asserts NODE_VERSION is itself inside the supported range. Both guards mutation-checked red. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XZHZjz6kX8Ly1qBvvCg29C
There was a problem hiding this comment.
Pull request overview
Declares and enforces Node 24.15.0 as the minimum supported runtime.
Changes:
- Adds floor-aware runtime and installation checks.
- Updates Claude and Codex environment contracts.
- Adds boundary and consistency tests.
Review concerns:
- Codex Cloud/Desktop provisioning remains major-only, leaving Node 24.13 installations broken.
package-lock.jsonstill declares"node": "24.x".- The branch-review ledger unnecessarily reorders historical append-only records.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.claude/hooks/session-start.sh |
Provisions Node 24.19 when outside the supported range. |
docs/branch-review-ledger.md |
Reorders historical entries and adds the PR record. |
docs/outstanding-issues.md |
Marks issue #285 resolved. |
package.json |
Raises the Node engine floor. |
scripts/check-codex-cloud-setup.mjs |
Accepts and validates bounded engine ranges. |
scripts/check-node-engine.cjs |
Enforces the range during installation. |
scripts/check-runtime.ts |
Adds minor-version floor validation. |
tests/check-runtime.test.ts |
Tests boundaries and duplicated-range consistency. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
7371db3 to
7c8dadd
Compare
Summary
>=24.15.0 <25and enforces it before installation and verification.scripts/check-node-engine.cjsandscripts/check-runtime.tsreject Node 24 releases below 24.15 and Node 25+ with an explicit project requirement..claude/hooks/session-start.shprovisions Node 24.19.0 when the current runtime falls outside the bounded range. Its comparison is Bash-native and does not depend on GNUsort -V.scripts/setup-codex-cloud.shreadspackage.json#engines.node, upgrades an out-of-range runtime through nvm, and fails closed if the selected runtime still does not satisfy the range.scripts/setup-codex-worktree.mjsvalidates the complete engine range before dependency reuse, removal, or installation, so Windows Desktop fails early instead of reachingnpm cion Node 24.13.AGENTS.md. Closes Remove Evidence-based and All sources chips from answer footer #285.Verification
Current head
7c8dadd409002572358570564be78cb80f9b3819is a single commit based directly onmainataf85cbc5f16d52a166a319e652082b23f959b418:npm run test -- --run tests/check-runtime.test.ts tests/codex-cloud-setup.test.ts tests/setup-codex-worktree.test.ts-> 3 files passed, 41 tests passed.npm run typecheck-> exit 0, no diagnostics.npm run format-> exit 0; the pre-push exact-commit formatting guard also passed.npm run check:runtime-> Node 24.19.0 and npm 11.17.0 pass.npm run check:codex-cloud->[Codex Cloud Check] PASS: static Cloud contracts match.npm run check:branch-review-ledger-> guard passed with 785 live and 1206 archived records.npm run check:outstanding-issues-> 292 rows (144 open, 148 archived), unique ids, no ids deleted from the current base..claude/hooks/session-start.shandscripts/setup-codex-cloud.sh-> pass.The PR branch was rebuilt linearly from current
mainto clear GitHub's stale conflict state while preserving the previously verified source content and the append-only review records. GitHub now reports the PR as mergeable. Hosted checks for the new SHA are pending.Not run locally: UI/browser gates, because no UI, routing, styling, or browser behavior changed. Provider-backed clinical/RAG/Supabase gates are not applicable to these operational runtime paths.
Risk and rollout
7c8dadd409002572358570564be78cb80f9b3819.Clinical Governance Preflight
Not applicable. The changed paths are operational runtime/setup contracts and do not touch ingestion, answer generation, search/ranking, source rendering, document access, privacy, or clinical output.
Review dispositions
sort -Vwith a Bash-native numeric comparison.