fix(specifiers): builder pathway strip and mobile spacing - #1762
Conversation
Share the map wording pathway on Build, drop the truncating hero supporting copy, and harden min-width/break-words so phone layouts no longer clip on the right edge. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe PR extracts a shared four-stage wording pathway, integrates it into the Specifier builder and map pages, improves responsive layouts, removes obsolete guidance text, adds mobile regression coverage, and updates the branch-review ledger. ChangesSpecifier pathway UI
Branch review ledger
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant SpecifierBuilderPage
participant SpecifierMapPage
participant SpecifierWordingPathway
SpecifierBuilderPage->>SpecifierWordingPathway: Render four wording stages
SpecifierMapPage->>SpecifierWordingPathway: Render four wording stages
SpecifierWordingPathway-->>SpecifierBuilderPage: Display responsive pathway
SpecifierWordingPathway-->>SpecifierMapPage: Display responsive pathway
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/branch-review-ledger.md`:
- Around line 823-824: Restore the existing ledger row order without modifying
their contents, then append the two PR `#1686` rows using the ledger:append
workflow. Preserve the incoming parent rows’ original ordering and avoid
manually rewriting or reordering existing entries.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 8deb11f3-f3fd-45db-b3a3-a22cc2c0cf16
📒 Files selected for processing (1)
docs/branch-review-ledger.md
Bare getByText clicks can miss the sr-only peer under shard contention with ui-specifiers (#257). Drive the radio with check() so the framework step is deterministic. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #9418 (cancelled). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
sr-only peer radios time out on check(); scope to the formulation framework radiogroup and click like ui-tools/ui-specifiers (#257).
The template radio is sr-only, so Playwright actionability rejects radio.click()/check(). Click the wrapping label inside the Formulation framework radiogroup instead (#257). Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Summary
/specifiers/buildervia a newSpecifierWordingPathwaycomponent.min-w-0/break-wordsso option copy and working diagnosis wording stay inside the viewport.Verification
npm run test:e2e -- tests/ui-specifiers.spec.ts --project=chromium→6 passed (5.5s)npm run verify:pr-local/npm run verify:ui— scoped layout/chrome change covered by the Specifiers Playwright file aboveRisk and rollout
Notes
minmax(0, …)overflow hardening.Summary by CodeRabbit