Skip to content

fix(specifiers): builder pathway strip and mobile spacing - #1762

Merged
cursor[bot] merged 11 commits into
mainfrom
cursor/specifiers-builder-mobile-f72a
Aug 9, 2026
Merged

fix(specifiers): builder pathway strip and mobile spacing#1762
cursor[bot] merged 11 commits into
mainfrom
cursor/specifiers-builder-mobile-f72a

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Summary

  • Share the Specifier map’s four-step wording pathway on /specifiers/builder via a new SpecifierWordingPathway component.
  • Remove the Build page hero supporting paragraph that truncated on phone widths.
  • Harden builder layout with min-w-0 / break-words so option copy and working diagnosis wording stay inside the viewport.
  • Extend Playwright coverage for the pathway and a 390px horizontal-overflow check.

Verification

  • Focused Specifiers Playwright: npm run test:e2e -- tests/ui-specifiers.spec.ts --project=chromium6 passed (5.5s)
  • Verification not run: full npm run verify:pr-local / npm run verify:ui — scoped layout/chrome change covered by the Specifiers Playwright file above
  • Provider-backed gates not run (not applicable)

Risk and rollout

  • Risk: Low — Specifiers Build presentation/layout only; no retrieval, ingestion, auth, or schema changes.
  • Rollback: Revert this PR.
  • Provider or production effects: None

Notes

  • Map page consumes the extracted pathway with no intentional visual change beyond shared minmax(0, …) overflow hardening.
Open in Web Open in Cursor 

Summary by CodeRabbit

  • New Features
    • Added a visual, four-step wording pathway to specifier pages.
    • Improved responsive layouts for builder forms, specifier cards, and diagnosis panels.
  • Bug Fixes
    • Improved text wrapping and spacing on smaller screens.
    • Prevented horizontal overflow while keeping pathway stages readable.
    • Removed outdated introductory instructions.
  • Tests
    • Added coverage for pathway visibility, instructional text removal, and mobile layout behavior.
  • Documentation
    • Updated review ledger records and corrected historical entries.

Share the map wording pathway on Build, drop the truncating hero
supporting copy, and harden min-width/break-words so phone layouts
no longer clip on the right edge.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The PR extracts a shared four-stage wording pathway, integrates it into the Specifier builder and map pages, improves responsive layouts, removes obsolete guidance text, adds mobile regression coverage, and updates the branch-review ledger.

Changes

Specifier pathway UI

Layer / File(s) Summary
Shared wording pathway component
src/components/specifiers/specifier-ui.tsx
Adds SpecifierWordingPathway with four numbered stages, responsive arrow separators, and accessible labeling.
Page integration and responsive validation
src/components/specifiers/specifier-builder-page.tsx, src/components/specifiers/specifier-map-page.tsx, tests/ui-specifiers.spec.ts, tests/ui-formulation.spec.ts
Uses the shared pathway on both pages, removes obsolete instructional text, updates responsive layout classes, and tests mobile visibility, overflow, and radio selection.

Branch review ledger

Layer / File(s) Summary
Ledger record updates
docs/branch-review-ledger.md
Reorders the two sidebar popup records and adds the Specifier mobile pathway review record.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant SpecifierBuilderPage
  participant SpecifierMapPage
  participant SpecifierWordingPathway

  SpecifierBuilderPage->>SpecifierWordingPathway: Render four wording stages
  SpecifierMapPage->>SpecifierWordingPathway: Render four wording stages
  SpecifierWordingPathway-->>SpecifierBuilderPage: Display responsive pathway
  SpecifierWordingPathway-->>SpecifierMapPage: Display responsive pathway
Loading

Possibly related PRs

Suggested reviewers: claude

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main changes: the builder pathway strip and mobile spacing fixes.
Description check ✅ Passed The description covers the summary, focused verification results, skipped checks with reasons, risk, rollback, and production effects.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/specifiers-builder-mobile-f72a

Comment @coderabbitai help to get the list of available commands.

@supabase

supabase Bot commented Aug 8, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

cursoragent and others added 2 commits August 8, 2026 19:10
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@cursor
cursor Bot marked this pull request as ready for review August 8, 2026 23:35
@cursor
cursor Bot enabled auto-merge (squash) August 8, 2026 23:35
cursoragent and others added 4 commits August 8, 2026 23:53
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/branch-review-ledger.md`:
- Around line 823-824: Restore the existing ledger row order without modifying
their contents, then append the two PR `#1686` rows using the ledger:append
workflow. Preserve the incoming parent rows’ original ordering and avoid
manually rewriting or reordering existing entries.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8deb11f3-f3fd-45db-b3a3-a22cc2c0cf16

📥 Commits

Reviewing files that changed from the base of the PR and between c1e4ad4 and b2f0dea.

📒 Files selected for processing (1)
  • docs/branch-review-ledger.md

Comment thread docs/branch-review-ledger.md
cursoragent and others added 2 commits August 9, 2026 00:52
Bare getByText clicks can miss the sr-only peer under shard contention with
ui-specifiers (#257). Drive the radio with check() so the framework step is
deterministic.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

CI triage

CI failed on this PR. Automated classification of the 2 failed job(s):

  • Production UI (2)needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
  • PR requiredneeds investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.

Compared with main CI run #9418 (cancelled).

Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger.

cursoragent and others added 2 commits August 9, 2026 01:19
sr-only peer radios time out on check(); scope to the formulation framework
radiogroup and click like ui-tools/ui-specifiers (#257).
The template radio is sr-only, so Playwright actionability rejects
radio.click()/check(). Click the wrapping label inside the Formulation
framework radiogroup instead (#257).

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@cursor
cursor Bot merged commit 50ef12e into main Aug 9, 2026
26 checks passed
@cursor
cursor Bot deleted the cursor/specifiers-builder-mobile-f72a branch August 9, 2026 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants