issues: capture the in-page nav series (#286–#288) and correct #256 - #1761
Conversation
…cumentViewer decision) and correct #256 #256's forms half is disproven against origin/main e71b23b: all six formSections targetIds now render as element ids. Its differential-presentations half is still live, and two DSM routes have the same defect and were never recorded. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GyM49edHSNfm42u1SFDfG3
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 22 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe outstanding-issues ledger updates its allocation marker, corrects issue ChangesNavigation issue ledger
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/outstanding-issues.md`:
- Line 327: Update the `#288` entry in the outstanding-issues ledger to remove the
false claim that DocumentViewer’s non-adoption is undocumented and delete the
duplicate documentation task, referencing docs/search-chrome-behaviour.md as the
existing record. Correct the `#286` status claim so it reflects that chrome-metric
generalisation remains future work, and avoid stating that every information
page must adopt the template because `#287` permits documented route-specific
exceptions. Narrow the entry to the remaining DocumentViewer owner decision.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: af495683-42e7-4acf-89ed-c6a853c895cc
📒 Files selected for processing (1)
docs/outstanding-issues.md
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 324b182134
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…utstanding-issues) Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
…utstanding-issues) Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
3 participants
Summary
Ledger-only follow-up to PR #1740, which extracted the default in-page navigation template. That PR was phase 1 of three; phases 2 and 3 were planned in-session but existed nowhere durable, so this records them before the context is lost.
#286(P2 task) — PR 2 of the series. Convert the six routes still drawing the shell-owned pill rail (services, forms, specifiers ×2, formulation, dsm ×2) ontoInPageNavHeader, then delete the rail behind them. Records the blocker found while planning it:InPageNavHeader.actionsis a render prop(close) => ReactNode, and four of the seven components in scope are Server Components, so all four fail to build against that signature until it is widened.#287(P2 task) — PR 3 of the series. The three locally-owned routes each need a decision rather than a conversion: medications'SectionTabsswaps content rather than scrolling (a product call on a clinical record), differentials/presentations has no rendered anchors at all, and factsheets has no section ids and a decorative "On this page" list that does nothing.#288(P3 rec) — whetherDocumentVieweradopts the template it was extracted from. After phases 2 and 3 the template is adopted everywhere except its origin, which is defensible but currently unrecorded as a choice.#256corrected in both directions againstorigin/maine71b23b. Its Forms diagnosis is disproven — all sixformSectionstarget ids now render as element ids (form-detail-page.tsx:700, 823, 835, 859, 882, 891). Its differentials/presentations half is still live. Two DSM routes have the same defect and had never been recorded:/dsm/diagnoses/[slug]declares five sections and renders three, and/dsm/diagnoses/[slug]/differentialsdeclares four and renders one.Each claim above was verified against the rendered source at
e71b23brather than carried over from the earlier ledger text, per#256's own stop rule that these sets must not be audited by grepping forid=alone.Verification
Docs-only change to
docs/outstanding-issues.md(5 insertions, 2 deletions). No executable, RAG-ranking, or clinical-risk paths are touched, so the risk-routed light-scope gates apply.npm run check:outstanding-issues—Outstanding-issues guard passed: 286 rows (142 open, 144 archived), unique ids, next-id=289 above the highest, no merge driver, no ids deleted from base e71b23b646c5.npx prettier --check .—All matched files use Prettier code style!(whole tree, not just the changed file).Not run, and why: no behavioural gate applies to a ledger append.
verify:pr-local,verify:ui,verify:release, the retrieval/answer evals andcheck:production-readinessall cover failure classes this diff cannot reach.Risk and rollout
Negligible. Append-and-amend on the outstanding-work ledger; no product code, no schema, no configuration. Rollback is
git revertof the single commit.Note for whoever syncs this:
docs/outstanding-issues.mddeliberately has no merge driver, so an overlapping append conflicts loudly. Resolve by rebuilding fromorigin/mainand re-applying only the rows changed here — never by taking one side wholesale.Notes
Rows were written with
npm run issues:add/issues:updaterather than by hand, so ids came from theissues:next-idmarker and the writer re-ran the gate against its own output.The branch was restarted from
origin/mainbecause PR #1740 had already merged and its head was auto-deleted; this branch shares the same name but carries only the new commit.Generated by Claude Code
Summary by CodeRabbit