Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -682,7 +682,27 @@ jobs:
visual-baseline:
name: Visual baselines (advisory)
needs: changes
if: needs.changes.outputs.ui_changed == 'true'
# Deliberately NOT on pull_request or merge_group. Owner decision, 2026-08-09:
# a pixel gate that reports on every UI pull request taxes exactly the work it
# exists to support. During a redesign the honest result is red on every push,
# and the baselines cannot be refreshed until a run has produced the new
# images, so that red is unavoidable rather than actionable. It never blocked
# a merge (`continue-on-error`, and absent from `pr-required`), but a red check
# nobody can act on mid-iteration is friction whether or not it gates.
# `merge_group` is excluded for the same reason: queue runs are still
# pre-merge UI churn, not a post-land refresh point.
#
# Drift is still caught: this runs on pushes to main and release branches, on
# the weekly schedule, and on demand via workflow_dispatch. That puts the
# signal where a refresh is cheap — after the change has landed — instead of
# interrupting the change. Refresh with `npm run design-system:baselines:adopt`
# against that run's artifact.
#
# Do not add `pull_request` / `merge_group` back, and do not add this job to
# `pr-required`, without the owner saying so.
if: >
needs.changes.outputs.ui_changed == 'true' &&
contains(fromJSON('["push","schedule","workflow_dispatch"]'), github.event_name)
continue-on-error: true
runs-on: ubuntu-24.04
timeout-minutes: 45
Expand Down
Loading
Loading