Condense Form 1A priority facts and add Act section detail - #1752
Conversation
Replace the redundant Source status card on Form 1A with MHA Act sections that open per-section detail sheets, and shorten the other three priority-fact cards with tap-for-detail bodies. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 47 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughForm 1A now provides structured priority facts and Mental Health Act sections. The catalog parser exposes these details to form summaries and search. The form detail page renders expandable cards and detail sheets. Review-ledger records are reordered chronologically. ChangesForm catalog and detail UI
Review ledger reconciliation
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant FormCatalogData
participant formCatalog
participant FormDetailPage
participant Sheet
FormCatalogData->>formCatalog: provide priorityFacts and actSections
formCatalog->>FormDetailPage: return parsed form details
FormDetailPage->>Sheet: open selected fact or Act section details
Sheet->>FormDetailPage: close detail view
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
7040b85 to
9db089a
Compare
Regenerate the adoption manifest after FormDetailPage mounts Sheet for priority-fact and Act-section detail popovers. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
9db089a to
b8911fd
Compare
Add one high-yield cue to each condensed card so clock, maker, criteria, and Act sections remain scannable without dropping the clinical essentials. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #9241 (cancelled). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7d2c8abcc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Use the file's outline focus pattern so design-system contract stays within the form-detail edgeOwnershipConflicts budget.
Keep ConfirmCalloutText from main with DetailCardShell/Act sections from the Form 1A priority-facts branch. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
…equence resume) Regenerate design-system adoption manifest after merge conflict.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@data/forms-catalog.json`:
- Around line 82-130: Move the Form 1A prose currently embedded in the generated
catalog into the generator’s input/source data, add or update the generator
reference for this catalog, then regenerate data/forms-catalog.json so the
generated snapshot contains the same content. Use the generator and source
symbols defined by the repository rather than editing the generated JSON
directly.
In `@docs/branch-review-ledger.md`:
- Around line 761-763: Add the focused branch review ledger guard check to the
Checks section, preserving the reported validation result: 749 live records,
1206 archived records, 749 under the 2026-07-29 machine-readable contract,
active ledger merge, six cells per record, and no conflict markers, mojibake,
heading records, or duplicates.
In `@src/components/forms/form-detail-page.tsx`:
- Around line 146-155: Update the fallback title in fromCard to use the existing
card-label mapping for cardId instead of displayText(cardId), ensuring
detail-sheet headings show the readable card label when fact.title is missing.
- Around line 325-333: In the detail button within the DetailCardShell, replace
the undefined --focus-ring CSS variable in the focus-visible ring class with the
declared --focus variable, leaving the rest of the styling unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e7a38c1a-3a77-4672-87fa-17b62acbd44b
📒 Files selected for processing (8)
data/forms-catalog.jsondocs/branch-review-ledger.mddocs/design-system/adoption-manifest.jsonsrc/components/forms/form-detail-page.tsxsrc/lib/form-catalog.tssrc/lib/form-ranker.tstests/form-priority-facts.dom.test.tsxtests/forms.test.ts
- Merge origin/main (5155aca, Align Forms results bar; 00cf695, Add Differentials Presentations tab) and regenerate adoption manifest with both forms/form-detail-page.tsx and forms/forms-search-results-page.tsx recorded as Sheet consumers. - fix(forms): use human-readable label fallback in priorityFactBody Add PRIORITY_FACT_LABELS map so the detail Sheet title falls back to 'Clock / review', 'Made by / authority', or 'Criteria' instead of the raw cardId string when a fact card has no configured title. Addresses Sentry thread PRRT_kwDOSh5Fis6XfzdQ. - fix(registry): catalogue summaryCards win over pre-seeded form rows Skip the owner's stored summary_cards when merging form registry rows — form summaryCards are catalogue-derived and should always reflect the current catalogue layout. Pre-seeded Form 1A rows that stored the old full-length card layout will now correctly receive the new condensed priority-fact cards. Addresses Codex thread PRRT_kwDOSh5Fis6Xf1V7. Adds a focused regression test (19 tests pass). Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
…36' into cursor/form-1a-priority-facts-dc36
2 participants
Summary
26 · 31 · 36 · 37 · 41 · 42) labelled as the MHA 2014 referral pathway.actSections.Condensed card copy (Form 1A)
Verification
npm run typechecknpm run lintnpm run test— 530 files / 5704 passed | 4 skipped (pre-enrichment head)tests/forms.test.ts+tests/form-priority-facts.dom.test.tsx(8 passed)npm run verify:pr-localfull plan still includesbuild/check:rag:fixtures; offline unit + lint + typecheck already green for this scopenpm run verify:ui(DOM test covers the sheet interaction)npm run verify:release(provider-backed; not requested)Risk and rollout
Clinical Governance Preflight
Clinical KB Database(sjrfecxgysukkwxsowpy)Notes
priorityFacts/actSectionson the form catalog) so later forms can opt in without another UI rewrite.Summary by CodeRabbit
New Features
Bug Fixes