docs(issues): capture the stale design-system handover, and the completeness half of the lock-parity gap - #1725
Conversation
…eteness half of the lock-parity gap Two follow-ups from the #263 close-out that exist nowhere durable yet. #277 (new): docs/design-system/HANDOVER-2026-08-07.md is the Source citation on nine open rows (#261, #262, #264-#270) and is linked from docs/design-system/README.md as 'measured state', but four of its figures have now been disproved by measurement and corrected into the rows rather than the document, which still asserts the originals. A session scoping work from it gets the wrong numbers with full provenance. Cheapest fix is a superseded banner, not a rewrite — duplicating the corrections re-creates the drift. #149: the row treated this as transitive version drift. Measured 2026-08-08, the gap is also structural completeness. Two npm installs killed mid-extraction exited 127 with an empty log and left a node_modules that check:installed-lock-parity PASSED, while @testing-library/dom/types/index.d.ts was 0 bytes and @types/node was six files short. That produced 163 phantom tsc errors indistinguishable from real breakage. A version comparison of any width cannot catch it — the files were the right version and merely incomplete — so the fix wants a completeness check beside the version one. Detection and repair that worked are recorded on the row. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 36 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b2f861c3d2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Address Codex P2 review on PR #1725: the lock-parity completeness check must fail closed on missing non-entry package files, and the stale design-system handover must be bannered or archived rather than deleted. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Review-and-fix summary (PR #1725)Tip: Fixed
Dispositioned
Required CI
Local proof
Residual risks
Merge left to you. |
Summary
Docs-only, one file. Two follow-ups from the
#263close-out that currently exist only in one session's context.#277(new) —docs/design-system/HANDOVER-2026-08-07.mdis cited as provenance by nine open rows but is measurably wrong. Rows#261,#262,#264–#270all carrysession 2026-08-07 — design-system HANDOVER-2026-08-07 Track A1 handoff (PR #1678)as their Source, anddocs/design-system/README.mdlinks it as "measured state, the ordered plan". Four of its figures have since been disproved and corrected into the rows, not the document, which still asserts the originals:229 --shadow-tight aliasesis the seven-tokenlegacyShadowAliasestotal mislabelled as one token — the real figure is 100 sites across 55 files, total 228.#270's "22 call sites pair a tap token with a dead numeric height" does not survive re-measurement at all — zero same-variant pairs, 84 cross-variant responsive step-downs that are not dead.The failure mode is specific: a session scoping work from it gets the wrong numbers with full provenance. Recommended fix is a superseded banner naming the rows as current truth, not a rewrite — duplicating the corrections is what re-creates the drift.
#149— the lock-parity gap has a completeness half, not just a version half. The row treated this as transitive version drift. Measured 2026-08-08 it is also structural. Twonpm installruns killed mid-extraction (a concurrent session rannpm cache clean; both exited 127 with an empty log) left anode_modulesthatcheck:installed-lock-paritypassed — every package present at its locked version — while@testing-library/dom/types/index.d.tswas 0 bytes and@types/nodewas six files short, missingweb-globals/importmeta.d.ts. That produced 163 phantomtscerrors (135 × TS2305 "no exported member 'screen'", plusImportMeta.dirname/Timeout/unref) indistinguishable from real breakage, and a missing@rolldown/binding-win32-x64-msvckilled Vitest withERR_DLOPEN_FAILED.A version comparison of any width cannot catch this — the installed files were the right version and merely incomplete — so the row now asks for a completeness check beside the version one. The detection that worked (run the gate against pristine
origin/maincontent; an identical error count proves the tree innocent) and the repair that worked (rm -rf node_modules, then onenpm install <package-already-in-the-manifest>to reify from the lockfile without touching the manifest) are both recorded.Verification
npm run check:outstanding-issues— passed:275 rows (132 open, 143 archived), unique ids, next-id=278 above the highest, no merge driver, no ids deleted from base 5c0504a40615.npx prettier --check .— passed whole-tree:All matched files use Prettier code style!npm run issues:add/issues:update, never by hand.Note for sequencing: PR #1724 also edits
docs/outstanding-issues.md(it closes#276). The two touch different sections — a closure plus queue-row removal there, an append plus one detail cell here — so they should merge independently, and that file deliberately has no merge driver, meaning any real overlap will conflict loudly rather than silently concatenate.🤖 Generated with Claude Code