fix(design-system): LinkAction refuses tone; correct #270, #118 and #269 by measurement

[BigSimmo]

Summary

Three commits, each independently revertible. One small source fix plus the ledger corrections that came out of measuring the next item rather than doing it.

• LinkAction refuses tone instead of silently ignoring it (src/components/ui/link.tsx). LinkActionProps extended BaseProps, which declares tone?: "accent" | "inherit", but LinkAction destructures only { href, children, className }. tone="inherit" therefore type-checked, read as working, and did nothing — while TextLink, ExternalTextLink and DownloadLink all honour it. Refusing rather than implementing: a forward action is the accent by design, which is what makes it read as the card's next step rather than as prose, so there is no inherit variant to select. LinkAction has zero production importers today (docs/design-system/adoption-manifest.json), so this is free to change now and expensive once call sites exist. Closes #276. .design-sync/config.json is regenerated by npm run design-system:design-sync:update, not hand-edited.

• #270 corrected — its premise did not survive re-measurement. The row said 22 call sites pair a tap token with a dead numeric height and that declaring tap in CLINICAL_TWMERGE_THEME.spacing would drop 18 production targets from 48px. Measured against origin/main, none of that holds at this HEAD:

  • Zero same-variant pairs in components, and 84 cross-variant ones. DocumentManagerPanel.tsx and settings-dialog.tsx carry no tap token at all any more; document-admin and service-detail-page have tap sites with no numeric height.
  • The survivors are responsive step-downs, not dead classes — min-h-tap with sm:min-h-9 / lg:min-h-9 / md:min-h-9, and h-10.5 with sm:h-tap. The later variant wins at its breakpoint, so deleting the numeric raises the control. That is a visual change, not the no-op the row promised.
  • The stated blocker is measured false: tailwind-merge groups by variant, so min-h-tap and sm:min-h-9 are never in one conflict group. A probe over the real pairings returned identical output with and without tap declared; only synthetic same-variant controls (min-h-tap min-h-9, min-h-9 min-h-tap, h-tap h-5) changed.
  • What stays open is narrower and is now written into the row: the per-literal scan cannot see a conflict composed across cn() arguments, where order decides whether a recipe raises to 48px or drops to 28px. That sweep is the real remaining work, and it is why no source file was touched here.

• #118 and #269 corrected on the visual baselines. #118 records the owner's decision — adopt, advisory-only first, promote to pr-required only after the soak the workflow comment asks for — and the sequencing constraint that baselines frozen while design changes are still merging go red on the next merge. #269's "baselines cannot be generated on Windows" is corrected: true of win32 PNGs, because snapshotPathTemplate carries {platform}, but the visual-baseline job on ubuntu-24.04 already produces the ones that count and uploads them as visual-baseline-<run_id>.

Also carries the docs/branch-review-ledger.md row for PR #1719, appended with npm run ledger:append rather than pushed as a ledger-only tip on that PR.

Verification

Note on the environment first, because it invalidated an earlier gate run: this worktree's node_modules was left partially written by two npm install runs that were killed mid-extraction (a concurrent session ran npm cache clean). Symptom was a zero-byte @testing-library/dom/types/index.d.ts and a six-file-short @types/node, which produced 163 phantom typecheck errors. Measured identically with and without this diff, so no finding here rests on that state; it was repaired by a clean reify from the lockfile before any gate below was run, and package.json / package-lock.json are untouched.

• node ./node_modules/typescript/bin/tsc -p tsconfig.typecheck.json --noEmit — exit 0, zero diagnostics (captured to a file, not piped, so the exit code is tsc's own).
• npm run lint — exit 0, no findings.
• npm run check:design-system-contract — exit 0: design-system adoption checked: 53 components, 55 roots, design-sync contract checked: 53 components and 7 guidelines.
• node scripts/check-icon-scale.mjs --strict — exit 0: ✓ icon-scale: no retired 4.5 (18px) half-step icon sizes in src. Run explicitly because it is not part of check:design-system-contract.
• node node_modules/vitest/vitest.mjs run --pool=threads --no-file-parallelism tests/ui-v2-components.dom.test.tsx tests/design-sync-visual-exports.test.ts tests/ui-primitives.dom.test.tsx tests/tailwind-merge-config.test.ts — Test Files 4 passed (4), Tests 175 passed (175).
• npm run check:outstanding-issues — passed: 274 rows (131 open, 143 archived), unique ids, next-id=277 above the highest, no merge driver, no ids deleted from base 00826bca2381.
• npx prettier --check . — passed whole-tree: All matched files use Prettier code style!
• No browser gate: LinkAction has zero production importers, so this diff renders nothing that is on a route today. The ledger commits are docs-only.

Clinical Governance Preflight

scripts/pr-policy.mjs classifies this diff as non-clinical-risk, but AGENTS.md asks for the preflight whenever source rendering or clinical output could be involved, so it is written out rather than skipped.

• Clinical output affected? No. LinkAction is a navigation affordance with zero production importers; no answer, citation, source-rendering or document-access path is touched.
• Privacy / document access affected? No. No auth, owner-scope, query-privacy or storage code is touched.
• Retrieval or ranking affected? No. Nothing under src/lib/rag/**, clinical-search, retrieval-selection, ranking-config or the eval harness is touched. RAG impact: no retrieval behaviour change — the diff is one component prop type, one generated design-sync entry, and three documentation rows.
• Failure behaviour is unchanged and remains conservative: the change removes an accepted-but-ignored prop, so the only new outcome is a compile-time rejection of a call that already did nothing at runtime.
• Rollback: git revert the single source commit; the two docs commits are independent of it.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes

  • Prevented unsupported link styling options from being selected, improving consistency for link actions.

• Documentation

  • Corrected documentation for legacy shadow aliases, focus tokens, baseline generation, and responsive sizing measurements.
  • Updated review records with clarified adoption guidance, CI artifact details, and revised cleanup recommendations.

[supabase]

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[coderabbitai]

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 24 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e04fde79-e158-4997-949a-856a5c0c1c7f

📥 Commits

Reviewing files that changed from the base of the PR and between 824c1b7 and add61fe.

📒 Files selected for processing (6)

• .design-sync/config.json
• docs/branch-review-ledger.md
• docs/design-system/adoption-manifest.json
• docs/outstanding-issues.md
• src/components/ui/link.tsx
• tests/ui-v2-components.dom.test.tsx

📝 Walkthrough

Walkthrough

The PR removes the unsupported tone prop from LinkAction and its design-sync declaration. It also updates review-ledger entries with corrected measurements, baseline-generation details, and sequencing decisions.

Changes

LinkAction contract

Layer / File(s)	Summary
Remove unsupported LinkAction prop src/components/ui/link.tsx, .design-sync/config.json	LinkActionProps and the design-sync declaration no longer expose the optional tone property.

Review documentation

Layer / File(s)	Summary
Update review records docs/outstanding-issues.md, docs/branch-review-ledger.md	The ledgers record revised baseline decisions, Ubuntu CI artifact generation, corrected responsive measurements, and design-system documentation corrections.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• BigSimmo/Database#595: Introduced the .design-sync/config.json file modified here.
• BigSimmo/Database#1224: Also updates append-only records in docs/branch-review-ledger.md.
• BigSimmo/Database#1677: Also adds review records to docs/branch-review-ledger.md.

Suggested reviewers: claude, cursoragent

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Linked Issues check	⚠️ Warning	The PR does not implement the directly linked issue #276 requirements for Supabase Cursor configuration, skills, and README onboarding.	Implement the .cursor/mcp.json configuration, vendored Supabase skills, and README onboarding required by issue #276, or link the correct issues.
Out of Scope Changes check	⚠️ Warning	The LinkAction type change and documentation ledger corrections are unrelated to the Supabase Cursor configuration requested by issue #276.	Remove unrelated changes or update the linked issue set to include the objectives for LinkAction and ledger corrections.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title clearly identifies the LinkAction prop fix and the related corrections to issues #270, #118, and #269.
Description check	✅ Passed	The description provides a detailed summary, verification results, governance assessment, and rollback information; the required context is substantially complete.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/ds-tap-and-linkaction

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/branch-review-ledger.md`:
- Line 747: Update the ledger entry for claude/ds-doc-corrections so its scope
includes src/components/ui/link.tsx, .design-sync/config.json, and
docs/outstanding-issues.md entries `#118`, `#269`, and `#270`, and record the reported
TypeScript, lint, design-system contract, icon-scale, targeted test,
outstanding-issues, and Prettier checks. If retaining the docs-only scope,
assign it a separate ref and head instead of identifying it as PR `#1719`, using
the ledger workflow.

In `@docs/outstanding-issues.md`:
- Line 215: Update the dated evidence in the outstanding-issues entry for `#118`
and the related entries `#310`–311 so it does not reference August 9, 2026 before
that date has occurred. Replace those dates with the actual evidence date, or
move the updates to a post-August 9 entry while preserving the documented
decisions and measurements.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3334aebc-8394-4e2c-8474-e29aab91d1f0

📥 Commits

Reviewing files that changed from the base of the PR and between d136991 and 824c1b7.

📒 Files selected for processing (4)

• .design-sync/config.json
• docs/branch-review-ledger.md
• docs/outstanding-issues.md
• src/components/ui/link.tsx

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 824c1b74a2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".