Remove Specifiers search-results back breadcrumb - #1710
Conversation
The lone ← Specifiers crumb under ModeNav on search results was redundant with Find/Build/More; deep pages keep their trails. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 44 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Specifiers results view no longer displays the standalone left-arrow breadcrumb. Lighthouse baseline refreshes now ignore prior-baseline mismatches while still requiring complete measurements. Stored Lighthouse metrics are updated. ChangesSpecifiers breadcrumb removal
Lighthouse baseline refresh
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant UpdateCommand
participant BudgetChecker
participant LighthouseReports
UpdateCommand->>BudgetChecker: request baseline update
BudgetChecker->>LighthouseReports: check measurement availability
LighthouseReports-->>BudgetChecker: report measurements
BudgetChecker-->>UpdateCommand: allow refresh or reject incomplete evidence
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
…ers-back-arrow-f1c4 Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
`--update` treated runner Chrome user-agent mismatches as incomplete evidence, so the documented remediation could not run. Ignore baseline-relative gaps during refresh, then adopt this PR's CI reports (HeadlessChrome/150) as the committed baseline. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
|
@cursoragent Work the current open PR end-to-end. Confirm the PR number and GitHub head first from context. If more than one open PR could apply, stop and say which one you would use and why. Fetch and start from the remote tip that matches that GitHub head. If the named branch ref is missing or stale, use the PR head ref. Preserve unrelated local WIP, including any local-only ledger commits; do not discard dirty work, and do not treat a local-ahead commit as the reviewed tip. Do not merge the PR, force-push, rebase, or arm auto-merge unless I explicitly ask. No provider-backed gates without separate approval. If you cannot push or resolve threads, diagnose and comment only; if inline replies fail, resolve when possible and put dispositions in the summary comment. If auto-merge is already armed, push only for a real blocker, and avoid pushes that would cancel in-flight required CI unless the push itself clears that blocker. If the PR is already merged or closed: confirm the head and merge commit, note required-CI outcome, post one summary, and stop. Goal: deep review plus Bugbot, fix actionable issues with the smallest correct changes, clear merge / required-CI / thread blockers, run strong local offline verification, push fixes, append the review ledger, and post one PR summary. Prefer thoroughness over speed. Regenerate large assets only when a fix requires it; then run the asset check and keep compatibility aliases byte-identical where the repo uses them. Snapshot the GitHub head SHA: tip, base, behind/ahead, mergeable state, merge-tree versus origin/main (real conflict versus behind-but-clean), required checks on that tip including Production UI when selected, advisory separately, unresolved actionable threads. Missing checks while dirty are not green. If the tip moves mid-work, re-snapshot and continue from the new head. Ledger-lookup against that GitHub head under the heavy review-and-fix scope for this PR. Already reviewed at this head with clean merge-tree, green required checks, and no new actionable threads → summarize, comment, stop unless I asked for a fresh superseding pass. Follow the repo review protocol. Unblock once: real conflict → merge origin/main (prefer main’s shared queues; keep this PR’s notes); behind-but-clean → one sync, late if required CI is in flight; clean → leave. Labels like skip-branch-sync do not block a manual sync needed to clear a real blocker. No sync thrash. After any sync or push, re-snapshot tip, merge-tree, and required checks before declaring done. Dedupe the ledger if a merge touched it. Review high-confidence delta risks only. Separate PR-introduced defects from pre-existing re-emitted debt. For generated assets, review contracts, aliases, cache, and manifests—not every generated line. If protected RAG or ranking surfaces are touched, say so before editing; fix PR-body policy text only when wrong or missing. Ignore bot noise. No nit spam or broad rewrites. Escalate verification by touched risk: clinical / RAG / privacy / migrations / auth → domain check plus production-readiness when warranted; UI / phone-chrome / routing / styling → ensure plus phone-chrome or UI gates when warranted; generated assets or docs inventory/links → asset or docs checks when warranted. Fix P0/P1 always; clear scoped P2 when locally provable; else disposition and resolve. Required-check failures on this tip only; ignore advisory. Prefer reverting a bad autofix commit. After fixes: format and commit before push; smallest targeted proof; repo cheap gate; repo PR-local gate. No release, lighthouse, live eval, or live provider gates without approval. Push only this PR’s fix commits. Append ledger for the final GitHub head under the heavy scope. Never push a ledger-only tip—include ledger in a real fix push, or leave a no-change ledger append local and unpushed. One PR comment: tip, sync/merge-tree, fixed versus dispositioned, threads, required CI, decisive local gate lines, residual risks; merge left to me. Inline only for remaining human-needed P0/P1. Stop when merge-tree is clean on the current GitHub tip, actionable threads are clear, required checks are green or clearly in progress, heavy gates for scope passed, summary posted, merge left to me. |
|
PR #1710 @ tip Review: No actionable P0–P2. Specifiers crumb removal and lighthouse Unblock: One behind-but-clean sync from Gates: Residual: Main moved again (#1712) → GitHub |
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
PR #1710 end-to-end review summaryTarget: PR #1710 ( Snapshot (post-work)
Review findings
Local gates (decisive lines)
Residual risks
Merge left to you. |
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Codex P2 on PR #1724: the red advisory is a stale Chromium 150 baseline overwrite from #1710 against a job already pinned to Playwright Chromium 151 (#1716), not a fresh CI-runner 150→151 bump. Prefer restoring or comparing the known 151 baseline over a blind --update. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>


Summary
← Specifiersbreadcrumb from Specifiers search results under ModeNav (Find/Build/More).--updatecould not refresh after runner Chrome user-agent drift (151 baseline vs 150 CI), so the documented remediation was unreachable. Ignore baseline-relative gaps during refresh and adopt this PR's CI reports as the baseline.Verification
npm run formatnpm run typecheck(exit 0)npm run lint(exit 0)npm run ensure→http://localhost:4461/specifiers?q=Pain&run=1— crumb gone; Find/Build/More remainsnpm run test -- tests/check-lighthouse-budget.test.ts— 38 passednpm run check:lighthouse-budget -- --update --dir <CI artifact>then re-grade — within tolerancenpm run verify:pr-local/verify:ui— scoped JSX + lighthouse grader/baseline change covered by focused unit + CI artifact re-gradeRisk and rollout
ubuntu-24.04; does not alter product runtime.Notes
--updatefrom that run's artifact; pinning Lighthouse to Playwright Chromium would remove that flake.Summary by CodeRabbit
UI Improvements
Documentation