Skip to content

Remove Specifiers search-results back breadcrumb - #1710

Merged
BigSimmo merged 6 commits into
mainfrom
cursor/remove-specifiers-back-arrow-f1c4
Aug 8, 2026
Merged

Remove Specifiers search-results back breadcrumb#1710
BigSimmo merged 6 commits into
mainfrom
cursor/remove-specifiers-back-arrow-f1c4

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Aug 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • Remove the redundant ← Specifiers breadcrumb from Specifiers search results under ModeNav (Find/Build/More).
  • Leave deep-page Specifiers breadcrumbs (Build / Compare / Map / records / reference) unchanged.
  • Fix advisory Lighthouse budget CI failure: --update could not refresh after runner Chrome user-agent drift (151 baseline vs 150 CI), so the documented remediation was unreachable. Ignore baseline-relative gaps during refresh and adopt this PR's CI reports as the baseline.

Verification

  • npm run format
  • npm run typecheck (exit 0)
  • npm run lint (exit 0)
  • npm run ensurehttp://localhost:4461
  • Phone-width spot-check: /specifiers?q=Pain&run=1 — crumb gone; Find/Build/More remains
  • npm run test -- tests/check-lighthouse-budget.test.ts — 38 passed
  • npm run check:lighthouse-budget -- --update --dir <CI artifact> then re-grade — within tolerance
  • Verification not run: full npm run verify:pr-local / verify:ui — scoped JSX + lighthouse grader/baseline change covered by focused unit + CI artifact re-grade

Risk and rollout

  • Risk: Low for Specifiers crumb removal. Lighthouse change is advisory-gate tooling + relative baseline refresh after Chrome UA drift on ubuntu-24.04; does not alter product runtime.
  • Rollback: Revert the product commit and/or the lighthouse commit.
  • Provider or production effects: None

Notes

  • No tests asserted the Specifiers home crumb.
  • Residual: if GitHub's runner Chrome UA flips again (e.g. back to 151), the advisory job fails closed until another --update from that run's artifact; pinning Lighthouse to Playwright Chromium would remove that flake.
Open in Web Open in Cursor 

Summary by CodeRabbit

  • UI Improvements

    • Removed the standalone left-arrow “Specifiers” breadcrumb from search results for a cleaner interface.
    • Preserved breadcrumb navigation when viewing deeper specifier pages.
    • Search result navigation is now less visually cluttered while deep-page navigation remains available.
  • Documentation

    • Added a record documenting the navigation update and confirming the intended deep-page behavior.

The lone ← Specifiers crumb under ModeNav on search results was
redundant with Find/Build/More; deep pages keep their trails.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 44 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0ce04345-1f06-4271-ae92-56a6fd15f432

📥 Commits

Reviewing files that changed from the base of the PR and between 19b25d8 and 64d9a60.

📒 Files selected for processing (1)
  • docs/branch-review-ledger.md
📝 Walkthrough

Walkthrough

The Specifiers results view no longer displays the standalone left-arrow breadcrumb. Lighthouse baseline refreshes now ignore prior-baseline mismatches while still requiring complete measurements. Stored Lighthouse metrics are updated.

Changes

Specifiers breadcrumb removal

Layer / File(s) Summary
Remove results breadcrumb
src/components/specifiers/specifiers-home-page.tsx, docs/branch-review-ledger.md
The results view no longer imports or renders SpecifierBreadcrumbs. The review ledger records the change and validation.

Lighthouse baseline refresh

Layer / File(s) Summary
Separate baseline refresh validation
scripts/check-lighthouse-budget.mjs, tests/check-lighthouse-budget.test.ts
--update ignores browser-version drift and missing baseline rows. It still rejects missing Lighthouse measurements.
Refresh stored baseline data
lighthouse-budget.json
Desktop and mobile metrics, the Chrome version, and the update timestamp are refreshed.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant UpdateCommand
  participant BudgetChecker
  participant LighthouseReports
  UpdateCommand->>BudgetChecker: request baseline update
  BudgetChecker->>LighthouseReports: check measurement availability
  LighthouseReports-->>BudgetChecker: report measurements
  BudgetChecker-->>UpdateCommand: allow refresh or reject incomplete evidence
Loading

Possibly related PRs

Suggested reviewers: claude

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the primary product change: removing the Specifiers search-results back breadcrumb.
Description check ✅ Passed The description covers the changes, verification, skipped gates, risk, rollback, production effects, and remaining notes; the omitted clinical preflight is not clearly applicable.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/remove-specifiers-back-arrow-f1c4

Comment @coderabbitai help to get the list of available commands.

@supabase

supabase Bot commented Aug 7, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@BigSimmo
BigSimmo marked this pull request as ready for review August 7, 2026 18:21
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@BigSimmo
BigSimmo enabled auto-merge (squash) August 7, 2026 18:21
cursoragent and others added 3 commits August 7, 2026 18:32
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
…ers-back-arrow-f1c4

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
`--update` treated runner Chrome user-agent mismatches as incomplete
evidence, so the documented remediation could not run. Ignore
baseline-relative gaps during refresh, then adopt this PR's CI
reports (HeadlessChrome/150) as the committed baseline.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@BigSimmo

BigSimmo commented Aug 8, 2026

Copy link
Copy Markdown
Owner Author

@cursoragent Work the current open PR end-to-end. Confirm the PR number and GitHub head first from context. If more than one open PR could apply, stop and say which one you would use and why.

Fetch and start from the remote tip that matches that GitHub head. If the named branch ref is missing or stale, use the PR head ref. Preserve unrelated local WIP, including any local-only ledger commits; do not discard dirty work, and do not treat a local-ahead commit as the reviewed tip. Do not merge the PR, force-push, rebase, or arm auto-merge unless I explicitly ask. No provider-backed gates without separate approval. If you cannot push or resolve threads, diagnose and comment only; if inline replies fail, resolve when possible and put dispositions in the summary comment. If auto-merge is already armed, push only for a real blocker, and avoid pushes that would cancel in-flight required CI unless the push itself clears that blocker.

If the PR is already merged or closed: confirm the head and merge commit, note required-CI outcome, post one summary, and stop.

Goal: deep review plus Bugbot, fix actionable issues with the smallest correct changes, clear merge / required-CI / thread blockers, run strong local offline verification, push fixes, append the review ledger, and post one PR summary. Prefer thoroughness over speed. Regenerate large assets only when a fix requires it; then run the asset check and keep compatibility aliases byte-identical where the repo uses them.

Snapshot the GitHub head SHA: tip, base, behind/ahead, mergeable state, merge-tree versus origin/main (real conflict versus behind-but-clean), required checks on that tip including Production UI when selected, advisory separately, unresolved actionable threads. Missing checks while dirty are not green. If the tip moves mid-work, re-snapshot and continue from the new head.

Ledger-lookup against that GitHub head under the heavy review-and-fix scope for this PR. Already reviewed at this head with clean merge-tree, green required checks, and no new actionable threads → summarize, comment, stop unless I asked for a fresh superseding pass. Follow the repo review protocol.

Unblock once: real conflict → merge origin/main (prefer main’s shared queues; keep this PR’s notes); behind-but-clean → one sync, late if required CI is in flight; clean → leave. Labels like skip-branch-sync do not block a manual sync needed to clear a real blocker. No sync thrash. After any sync or push, re-snapshot tip, merge-tree, and required checks before declaring done. Dedupe the ledger if a merge touched it.

Review high-confidence delta risks only. Separate PR-introduced defects from pre-existing re-emitted debt. For generated assets, review contracts, aliases, cache, and manifests—not every generated line. If protected RAG or ranking surfaces are touched, say so before editing; fix PR-body policy text only when wrong or missing. Ignore bot noise. No nit spam or broad rewrites. Escalate verification by touched risk: clinical / RAG / privacy / migrations / auth → domain check plus production-readiness when warranted; UI / phone-chrome / routing / styling → ensure plus phone-chrome or UI gates when warranted; generated assets or docs inventory/links → asset or docs checks when warranted.

Fix P0/P1 always; clear scoped P2 when locally provable; else disposition and resolve. Required-check failures on this tip only; ignore advisory. Prefer reverting a bad autofix commit. After fixes: format and commit before push; smallest targeted proof; repo cheap gate; repo PR-local gate. No release, lighthouse, live eval, or live provider gates without approval.

Push only this PR’s fix commits. Append ledger for the final GitHub head under the heavy scope. Never push a ledger-only tip—include ledger in a real fix push, or leave a no-change ledger append local and unpushed.

One PR comment: tip, sync/merge-tree, fixed versus dispositioned, threads, required CI, decisive local gate lines, residual risks; merge left to me. Inline only for remaining human-needed P0/P1.

Stop when merge-tree is clean on the current GitHub tip, actionable threads are clear, required checks are green or clearly in progress, heavy gates for scope passed, summary posted, merge left to me.

@cursor

cursor Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

PR #1710 @ tip 19b25d89 — only matching open PR.

Review: No actionable P0–P2. Specifiers crumb removal and lighthouse --update fix look correct; no Bugbot/review threads.

Unblock: One behind-but-clean sync from main (auto-merge was already armed). Required CI was green on the pre-sync tip; it is restarting on the new tip.

Gates: verify:cheap — 5539 passed; verify:pr-local — exit 0 (build + RAG fixtures).

Residual: Main moved again (#1712) → GitHub DIRTY but merge-tree clean (behind-by-1). No second sync. Ledger row left local/unpushed. Summary posted on the PR; merge left to you.

Open in Web Open in Cursor 

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@cursor

cursor Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

PR #1710 end-to-end review summary

Target: PR #1710 (cursor/remove-specifiers-back-arrow-f1c4) — only open PR in context.

Snapshot (post-work)

  • GitHub tip: 19b25d897bcae4801f059c307c04e20c99b03d9b (synced from prior tip 37204300)
  • Sync: one git merge origin/main to clear pre-sync BEHIND (auto-merge was already armed). Merge-tree was clean then and remains clean vs current origin/main (2675e6e1, fix(design-system): close the open COMPONENTS §0.4 defect rows (#263) #1712) — git merge-tree --write-treecfd38e6a… exit 0. GitHub currently reports DIRTY/CONFLICTING from being behind-by-1 again after main moved during this pass; that is staleness, not a content conflict. No second sync (avoid thrash / cancel in-flight required CI on the tip just pushed).
  • Threads: none unresolved (Bugbot/CodeRabbit/Codex: no actionable inline findings).
  • Required CI (pre-sync tip 37204300): all green including PR required, Production UI (1–3 + critical), Build, Static, Unit coverage. Advisory Lighthouse was also green on that tip.
  • Required CI (current tip): restarting after the sync push — in progress / pending; not treated as green yet.
  • Auto-merge: already armed (squash); left as-is. Merge left to you.

Review findings

  • No P0/P1/P2 in the PR delta. Specifiers search-results crumb removal is correctly scoped; deep-page SpecifierBreadcrumbs call sites remain. Lighthouse --update chicken-and-egg fix + baseline refresh are coherent; unit tests cover refresh vs grade paths.
  • Fixed: none needed beyond the one behind-but-clean sync.
  • Dispositioned: advisory Lighthouse may flake again vs Playwright Chromium pin from main #1716 until a future baseline refresh — ignore per advisory policy; not a required-check blocker.

Local gates (decisive lines)

  • npm run verify:cheapTest Files 522 passed (522) / Tests 5539 passed | 4 skipped (5543) exit 0
  • npm run verify:pr-localClient bundle secret surface check passed. + Offline RAG fixture and manifest validation passed (36 golden cases, 23 suites). exit 0
  • npm run test -- tests/check-lighthouse-budget.test.tsTests 38 passed (38)

Residual risks

  • Branch is behind main by 1 again (#1712); merge-tree clean — one late sync after required CI settles if GitHub still blocks auto-merge.
  • Ledger row for this heavy pass is local/unpushed (no ledger-only tip). Scope: PR #1710 heavy review-and-fix @ 19b25d89….

Merge left to you.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@BigSimmo
BigSimmo merged commit 4f1bbbb into main Aug 8, 2026
24 of 25 checks passed
@BigSimmo
BigSimmo deleted the cursor/remove-specifiers-back-arrow-f1c4 branch August 8, 2026 06:37
cursor Bot pushed a commit that referenced this pull request Aug 8, 2026
Codex P2 on PR #1724: the red advisory is a stale Chromium 150 baseline
overwrite from #1710 against a job already pinned to Playwright Chromium
151 (#1716), not a fresh CI-runner 150→151 bump. Prefer restoring or
comparing the known 151 baseline over a blind --update.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants