fix(ui): keep burger menu in universal phone header - #1708
Conversation
Stop swapping the top-left control to a back arrow on information pages and differentials search results. Page-owned back controls remain the navigation path; the universal bar stays mode, new chat, menu.
📝 WalkthroughWalkthroughThe change removes mobile back-navigation helpers and props from the clinical dashboard search components. The mobile header always opens the Clinical Guide menu. Related back-navigation tests are deleted. ChangesMobile search navigation removal
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Clear the stale cancelled PR-required check left by the draft-to-ready CI retrigger, and sync the branch tip with main.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/components/clinical-dashboard/master-search-header.tsx (1)
199-199: 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick winGate the mobile menu trigger when no handler exists. Both production callers pass
onOpenMobileSidebar, and no removed props remain. Test callers omit the callback, so the button renders withonClick={undefined}. Make the callback required or render the button only when it exists.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/clinical-dashboard/master-search-header.tsx` at line 199, Update the master search header component’s mobile menu trigger to require and validate onOpenMobileSidebar before rendering or wiring the button; preserve the existing behavior for production callers while preventing a trigger with an undefined onClick in test callers.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/components/clinical-dashboard/master-search-header.tsx`:
- Line 199: Update the master search header component’s mobile menu trigger to
require and validate onOpenMobileSidebar before rendering or wiring the button;
preserve the existing behavior for production callers while preventing a trigger
with an undefined onClick in test callers.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ac5f047b-8d54-4589-8ca1-6ae444ee68ac
📒 Files selected for processing (3)
src/components/clinical-dashboard/global-search-shell.tsxsrc/components/clinical-dashboard/master-search-header.tsxtests/global-search-shell-back-href.test.ts
💤 Files with no reviewable changes (2)
- tests/global-search-shell-back-href.test.ts
- src/components/clinical-dashboard/global-search-shell.tsx
2 participants
Summary
Open Clinical Guide menu) as the universal phone header’s top-left control on nested information pages and differentials submitted-search views.mobileLeadingAction="back") plus unusedinfoPageBackHref/mobileBackHrefhelpers.origin/mainso a fresh CI head replaces the stale cancelledPR requiredfrom the draft→ready retrigger.Verification
npm run verify:pr-localPR requiredgreen on head6bff4b2f(run 31208494525)npm run verify:releasebefore release or handoff confidence claimsRisk and rollout
Notes
docs/search-chrome-behaviour.md: universal top bar is mode, new chat, menu; back belongs in page-owned chrome.Lighthouse budget (advisory)fails closed on Chrome 151 vs baseline Chrome 150 UA drift (evidence incomplete— refresh baselines with--updatein a dedicated change). Not caused by this header icon swap.Summary by CodeRabbit