WIP: Combined Backups for 6 branches - #1701
Conversation
…20260730 # Conflicts: # docs/outstanding-issues.md
…20260730 # Conflicts: # docs/outstanding-issues.md
…20260730 # Conflicts: # docs/outstanding-issues.md
…20260730 # Conflicts: # docs/outstanding-issues.md
…20260730 # Conflicts: # docs/outstanding-issues.md
…20260730 # Conflicts: # docs/outstanding-issues.md
…20260730 # Conflicts: # docs/outstanding-issues.md
…20260730 # Conflicts: # docs/outstanding-issues.md
…20260730 # Conflicts: # docs/outstanding-issues.md
…nto codex/moderate-batch-20260730
…al-audit-pr1485-final-audit
|
Important Review skippedToo many files! This PR contains 162 files, which is 12 over the limit of 150. To get a review, reduce the PR to 150 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to Pro+ to raise the limit. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (162)
You can disable this status message by setting the Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
…lf-8c662bb1' into codex/combined-wip-backups-20260807
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
|
@cursoragent Work the current open PR end-to-end. Confirm the PR number and GitHub head first from context. If more than one open PR could apply, stop and say which one you would use and why. Fetch and start from the remote tip that matches that GitHub head. If the named branch ref is missing or stale, use the PR head ref. Preserve unrelated local WIP, including any local-only ledger commits; do not discard dirty work, and do not treat a local-ahead commit as the reviewed tip. Do not merge the PR, force-push, rebase, or arm auto-merge unless I explicitly ask. No provider-backed gates without separate approval. If you cannot push or resolve threads, diagnose and comment only; if inline replies fail, resolve when possible and put dispositions in the summary comment. If auto-merge is already armed, push only for a real blocker, and avoid pushes that would cancel in-flight required CI unless the push itself clears that blocker. If the PR is already merged or closed: confirm the head and merge commit, note required-CI outcome, post one summary, and stop. Goal: deep review plus Bugbot, fix actionable issues with the smallest correct changes, clear merge / required-CI / thread blockers, run strong local offline verification, push fixes, append the review ledger, and post one PR summary. Prefer thoroughness over speed. Regenerate large assets only when a fix requires it; then run the asset check and keep compatibility aliases byte-identical where the repo uses them. Snapshot the GitHub head SHA: tip, base, behind/ahead, mergeable state, merge-tree versus origin/main (real conflict versus behind-but-clean), required checks on that tip including Production UI when selected, advisory separately, unresolved actionable threads. Missing checks while dirty are not green. If the tip moves mid-work, re-snapshot and continue from the new head. Ledger-lookup against that GitHub head under the heavy review-and-fix scope for this PR. Already reviewed at this head with clean merge-tree, green required checks, and no new actionable threads → summarize, comment, stop unless I asked for a fresh superseding pass. Follow the repo review protocol. Unblock once: real conflict → merge origin/main (prefer main’s shared queues; keep this PR’s notes); behind-but-clean → one sync, late if required CI is in flight; clean → leave. Labels like skip-branch-sync do not block a manual sync needed to clear a real blocker. No sync thrash. After any sync or push, re-snapshot tip, merge-tree, and required checks before declaring done. Dedupe the ledger if a merge touched it. Review high-confidence delta risks only. Separate PR-introduced defects from pre-existing re-emitted debt. For generated assets, review contracts, aliases, cache, and manifests—not every generated line. If protected RAG or ranking surfaces are touched, say so before editing; fix PR-body policy text only when wrong or missing. Ignore bot noise. No nit spam or broad rewrites. Escalate verification by touched risk: clinical / RAG / privacy / migrations / auth → domain check plus production-readiness when warranted; UI / phone-chrome / routing / styling → ensure plus phone-chrome or UI gates when warranted; generated assets or docs inventory/links → asset or docs checks when warranted. Fix P0/P1 always; clear scoped P2 when locally provable; else disposition and resolve. Required-check failures on this tip only; ignore advisory. Prefer reverting a bad autofix commit. After fixes: format and commit before push; smallest targeted proof; repo cheap gate; repo PR-local gate. No release, lighthouse, live eval, or live provider gates without approval. Push only this PR’s fix commits. Append ledger for the final GitHub head under the heavy scope. Never push a ledger-only tip—include ledger in a real fix push, or leave a no-change ledger append local and unpushed. One PR comment: tip, sync/merge-tree, fixed versus dispositioned, threads, required CI, decisive local gate lines, residual risks; merge left to me. Inline only for remaining human-needed P0/P1. Stop when merge-tree is clean on the current GitHub tip, actionable threads are clear, required checks are green or clearly in progress, heavy gates for scope passed, summary posted, merge left to me. |
PR #1701 — review-and-fix completePR: #1701 Snapshot
Fixes pushed
Verification (decisive lines)
Residual riskThis branch still has a 177-file WIP consolidation beyond the fixes above. The Sentry CRITICAL thread is fixed at A full summary is posted on the PR. Required CI is running on the new tip — merge when it goes green.   |
The route computed privacy-projected relatedDocuments via projectRelatedDocumentForClient but still returned the raw arrays in both the top-level relatedDocuments field and smartPanel.relatedDocuments, leaking owner_id, hidden labels, and raw label metadata. Use clientRelatedDocuments for both fields and project smartPanel through projectSmartPanelForClient before attaching the sanitized related docs. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Resolve docs/outstanding-issues.md and lighthouse-budget.json conflicts by taking main. Restore scripts/outstanding-issues.mjs to main's 7-cell schema so the issues writer matches the current ledger format. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Mirror the demo-search path and apply projectDocumentMatchForClient to documentMatches in live search responses so hidden labels, owner_id, and raw label metadata do not leak alongside the relatedDocuments fix. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
The origin/main merge left a broken duplicate spawnSync block in the Lighthouse runner. Take main's version so format and the budget gate parse. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Resolve leftover conflict markers in design-system, staging-setup, and operator-backlog. Point AGENTS.md and outstanding-issues references at the new docs/ subdirectory layout so check-docs-links passes after the branch moved maintained docs out of flat paths. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Regenerate content-addressed therapy projections and restore the previous-generation hashed files required by check:therapy-data-index so verify:cheap passes after the branch dropped committed catalogue blobs. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
PR #1701 review-and-fix summaryTip: Snapshot (post-push)
Fixed (P0/P1)
Dispositioned / residual
Local gates (decisive lines)
Threads
Merge left to you once required CI settles green. |
CI triageCI failed on this PR. Automated classification of the 9 failed job(s):
Compared with main CI run #8987 (cancelled). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
|
Closing this without merging. This branch consolidates 6 backup branches ( Two concrete regressions were found in this branch specifically:
The one verified, valuable piece — the privacy-projection fix — has been extracted into its own minimal, reviewed PR off current Recommend treating this branch (and the 6 branches it was built from) as abandoned rather than attempting to rebase or salvage further. Generated by Claude Code |
Pull request was closed
2 participants
Summary
Consolidates 6 WIP backup branches into a single clean branch to stop CI thrashing. Restored regressions for the client-source projection layer and PDF zoom.
Verification
pm run verify:pr-local\
pm run verify:ui\ UI verification not run: Windows environment EPERM locking issues on local machine.
pm run verify:release\
Risk and rollout
Clinical Governance Preflight