Skip to content

Consolidate ledger updates - #1683

Merged
BigSimmo merged 6 commits into
mainfrom
codex/consolidated-ledger-updates
Aug 7, 2026
Merged

Consolidate ledger updates#1683
BigSimmo merged 6 commits into
mainfrom
codex/consolidated-ledger-updates

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Aug 7, 2026

Copy link
Copy Markdown
Owner

Summary

Verification

  • npm run verify:pr-local

During development, use npm run verify:cheap as the faster iteration gate before the final PR-local preflight.

  • npm run verify:ui when UI, routing, styling, browser behavior, reduced-motion, or forced-colors behavior changed
  • npm run verify:release before release or handoff confidence claims

For retrieval, ranking, selection, chunking, source/citation rendering, or answer-contract changes, verify:pr-local runs eval:rag:offline automatically. Run the offline command directly during iteration before spending a live eval.

  • npm run eval:retrieval:quality (must stay 36/36) when retrieval, ranking, selection, chunking, or scoring behavior changed — CI cannot run it (needs live keys), so run it locally and paste the summary. A metadata/governance-weighting change once buried correct docs (recall 1.0→0.76) and only this eval caught it.
  • npm run eval:rag -- --limit 15 + npm run eval:quality -- --rag-only when answer generation, the synthesis prompt, or answer post-processing changed (grounded-supported must not drop; citation-failure 0)
  • npm run check:production-readiness when clinical workflow, privacy, environment, Supabase, source governance, or deployment behavior changed
  • npm run check:deployment-readiness when deployment startup, hosting, or rollout behavior changed

Risk and rollout

Complete this section for clinical, data, API, auth/privacy, workflow, dependency, build, or deployment changes.

  • Risk:
  • Rollback:
  • Provider or production effects: None / describe the explicitly authorized effect

Clinical Governance Preflight

Complete this section when the change touches ingestion, answer generation, search/ranking, source rendering, document access, privacy, production env, or clinical output.

  • Source-backed claims still require linked source verification before clinical use
  • No patient-identifiable document workflow was introduced or expanded without explicit governance approval
  • Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
  • Service-role keys and private document access remain server-only
  • Demo/synthetic content remains clearly separated from real clinical sources
  • Source metadata, review status, and outdated/unknown-source behavior remain conservative
  • Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

Notes

Summary by CodeRabbit

  • Documentation
    • Added review records documenting a repository-wide audit and verification results.
    • Recorded the review and fixes for PR #1683, including ledger ordering restoration and validation outcomes.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@supabase

supabase Bot commented Aug 7, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2a727a45-de90-43fa-ae94-991a81b7b029

📥 Commits

Reviewing files that changed from the base of the PR and between 1ff9ed2 and 04d1697.

📒 Files selected for processing (1)
  • docs/branch-review-ledger.md

📝 Walkthrough

Walkthrough

The pull request appends two review records to the Review Records table in docs/branch-review-ledger.md. The records document a repo-wide audit and the review-and-fix outcome for PR #1683.

Changes

Branch review ledger

Layer / File(s) Summary
Append review records
docs/branch-review-ledger.md
Adds rows for the seven-report repo-wide audit and the PR #1683 ledger-order restoration review.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: skip-branch-sync

Suggested reviewers: cursoragent, claude, copilot

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description preserves the template but provides no implementation summary, verification results, risk or rollback details, rollout effects, or governance confirmations. Add a concise change summary and record applicable verification results, risk, rollback, provider effects, and clinical governance confirmations, or state why each check was not run.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the ledger updates made by this pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/consolidated-ledger-updates

Comment @coderabbitai help to get the list of available commands.

cursoragent and others added 3 commits August 7, 2026 12:15
Clear behind-but-clean GitHub DIRTY/CONFLICTING state for PR #1683.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Prefer origin/main's shared ledger queue and append only the
missing seven-report audit row after the merge relocation.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Append the babysit review row for the post-sync consolidated tip.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@cursor

cursor Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

PR #1683 review-and-fix summary

Tip: 04d169712aec3e38bf80676dd9ea5a6f8ed48d9e on codex/consolidated-ledger-updates (matches GitHub head).

Sync / merge-tree: Was behind 53 with GitHub DIRTY/CONFLICTING while git merge-tree vs origin/main was clean. Merged origin/main, restored main’s ledger row order, kept only the missing seven-report audit row (+ review ledger row). Now behind 0 / ahead 4, merge-tree clean, GitHub MERGEABLE (status BLOCKED only while required checks settle). Auto-merge not armed.

Review / Bugbot:

  • Bugbot: none (no cursor[bot] threads or comments).
  • Actionable threads: 0.
  • High-confidence P0/P1: none.
  • Fixed: merge sync + ledger-order relocation after union merge (prefer main’s shared queue).
  • Dispositioned: none required.

Delta vs main: docs/branch-review-ledger.md only — append seven-report audit row for 2a8881afad230880166de60a533e17588d9920ec plus this review-and-fix ledger record.

Required CI on tip: in progress after push (Change scope, PR policy, PR mergeability, SAST/Secret Scan, etc.). Prior tip had mergeability failure only because the merge ref was dirty — missing checks while dirty were not treated as green.

Local proof: npm run verify:pr-local -- --files docs/branch-review-ledger.md PASS (docs scope): format Prettier; check:branch-review-ledger 649; docs links 1650; outstanding-issues 258. No provider-backed gates.

Residual risk: Hosted required checks still settling on the new tip; Production UI not expected for this docs-only path once scope classifies. Merge left to you.

@BigSimmo
BigSimmo enabled auto-merge (squash) August 7, 2026 12:36
@BigSimmo
BigSimmo merged commit 3d544aa into main Aug 7, 2026
23 checks passed
@BigSimmo
BigSimmo deleted the codex/consolidated-ledger-updates branch August 7, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants