refactor(navigation): remove the vestigial one-button mode strip

[BigSimmo]

Summary

• Deletes the single-button mode strip from the seven modes that stay single-surface — answer (an "Ask" button) and documents, services, forms, favourites, prescribing, tools (a "Search" one). Each rendered one <button> inside its own <nav> landmark whose only effect was focusing a composer already visible on the same screen. For a screen-reader user navigating by landmark, that is a navigation region announced for a no-op. All seven are genuinely single-surface — records, or one page — so there was nothing to adopt onto the shared header bar and nothing to replace the button with. Deleted, not ported. Factsheets, the one mode of the eight with a real second destination, took the bar in feat(navigation): adopt the shared mode nav for Factsheets #1674, which is why that had to land first.
• The keep-it argument does not survive checking. The case for the strip was that it might be the fast way back to a phone composer that scroll-hides. It cannot be: the shell renders it with sticky={false} and never passes placeInShell, so it sits in normal flow and scrolls off-screen at exactly the moment the composer hides.
• The registry[modeId][0]?.id fallback in activeModeSecondaryNavigationId is deleted, and the compiler forces it. An emptied as const entry is readonly [], so [0] is a hard TS2493. Anyone emptying the arrays without this gets a typecheck failure they might "fix" with a cast — quietly restoring the mark-the-first-slot-current bug that function's own doc comment warns callers about. Worth knowing before reviewing the diff.
• The documents clause in isModeSecondaryNavigationRoute goes with its entry. The hasSubmittedSearch early return stays — it is the only thing that puts the bar on a submitted-search mode home for all five adopted modes, and is now commented as such so it is not mistaken for more dead gating.
• PageSecondaryNavigation loses modeItems, modeAriaLabel, onSearch and stickyTop (the last already had zero callers anywhere). The empty-registry return sits below the informationDefinitions branch deliberately: services, forms, documents and prescribing register no destinations yet still claim section navs, so hoisting it would silently strip navigation from every /services/*, /forms/*, /medications/* and /documents/<id> record. That ordering is the highest-risk edit here and is mutation-checked.
• The action kind on SecondaryNavigation is kept, with a comment recording that it now has no live consumer. It carries the tablist roving-focus behaviour and is covered directly by its own component tests, so it is component API with tests rather than orphaned code — and check:knip runs without --include exports, so it would not be caught by the dead-code gate either way. Deleting it is a clean separate change; the point is not to do half of each.

Found while verifying, deliberately not fixed here: /forms/form-1 draws no section nav at all. form-detail-page.tsx:881 carries form-decision-context-mobile as a testId, not an element id, and the other five declared formSections targetIds are rendered nowhere — so AvailableInformationPageNavigation filters every item out and returns null. That is /issues #256 (declared section sets whose targets nothing renders), confirmed live for forms. It is pre-existing and unaffected by this PR: the section branch already won on that route and still does. Recorded in the new test's comment so the next person finds it where they'd look.

RAG impact: no retrieval behaviour change — navigation and layout only.

Verification

• npm run verify:pr-local

Verification not run: verify:pr-local aborts at check:installed-lock-parity — installed @playwright/test is 1.62.0 against a locked 1.62.1. Deliberately not resolved with npm ci: 1.62.1 expects Chromium build 1234 while only 1194 is on disk with downloads disabled, which would stop the browser specs running at all. Components run directly instead:

• npm run lint — exit 0, clean.

• npm run typecheck — clean. This is the gate that forces the TS2493 fallback deletion; it also surfaced exactly the 12 test call sites still passing the removed onSearch prop, and nothing else.

• npm run test — Test Files 1 failed | 518 passed (519), Tests 1 failed | 5493 passed | 4 skipped (5498). The single failure is tests/pr-handoff-stop.test.ts, a shell-hook test untouched by this diff; re-confirmed pre-existing on this base by a stashed re-run (1 failed | 10 passed on the clean tree), not carried over from feat(navigation): adopt the shared mode nav for Factsheets #1674's finding.

• Focused set — mode-secondary-navigation, mode-nav-contract, mode-nav-addon-slot.dom, page-secondary-navigation.dom, secondary-navigation.dom: Test Files 5 passed (5), Tests 97 passed (97).

• npm run format — run and committed.

• npm run verify:ui when UI, routing, styling, browser behavior, reduced-motion, or forced-colors behavior changed

UI verification run directly (same lock-parity reason): tests/ui-mode-nav-density.spec.ts + tests/ui-accessibility.spec.ts → 71 passed (1.1m). ui-accessibility is the one that matters beyond the usual set here — it carries the duplicated-landmark scan, which is where seven deleted <nav>s would have surfaced.

Mutation check on the load-bearing edit: hoisting the empty-registry guard above the informationDefinitions branch fails 2 tests in page-secondary-navigation.dom.test.tsx, including the new forms branch-order test. The guard placement is genuinely protected, not just commented.

Risk and rollout

• Risk: Removes a control across seven modes at once, which is the reason this was split from feat(navigation): adopt the shared mode nav for Factsheets #1674 rather than bundled. Bounded by what the control was: a button whose target is on the same screen, in normal flow, non-sticky. No adopted mode's behaviour changes — the five bar modes take the same path through PageSecondaryNavigation as before, just with the legacy fallback branch gone.
• Rollback: Single revert. Nothing outside mode-secondary-navigation.ts and page-secondary-navigation.tsx depends on the removed machinery.
• Provider or production effects: None.

Clinical Governance Preflight

Not applicable, verified against scripts/pr-policy.mjs rather than assumed: none of src/lib/mode-secondary-navigation.ts, src/components/page-secondary-navigation.tsx, src/components/secondary-navigation.tsx or src/components/clinical-dashboard/global-search-shell.tsx matches clinicalRiskPatterns — the src/lib/… clause requires one of auth/permission/privacy/security/rag/retriev/rank/search/answer/clinical/citation/source/document/upload/download in the path, and the presentation clause is explicitly written so that living under clinical-dashboard/ is not by itself clinical-risk. Nothing matches ragRankingPatterns. Navigation wiring only.

Notes

This completes the mode-navigation handover. All 13 modes now have navigation matching what they actually contain: five carry the shared header bar (dsm, specifiers, formulation, differentials, factsheets), therapy-compass feeds ModeNav from its own useTherapyNavItems, and the remaining seven are single-surface with no secondary nav at all.

Tools was assessed and deliberately left single-surface: its five ToolCatalogArea values drive filter chips, labels and icon tones inside the launcher with no area routes, and most catalogue records link out of /tools entirely — the launcher's own visible filter row already is that navigation.

---

Generated by Claude Code

Summary by CodeRabbit

• Improvements
  • Removed redundant single-action navigation strips from several modes for a cleaner interface.
  • Navigation now appears only when relevant destinations are available.
  • Improved handling of unmatched routes so users no longer see unrelated fallback navigation.
  • Preserved section navigation where applicable, including information and forms-related pages.
• Bug Fixes
  • Prevented unnecessary navigation from appearing on modes without available destinations.
  • Maintained correct search-route visibility behavior.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR removes legacy secondary-navigation search actions and fallback rendering. Seven modes now use empty registries. Route resolution returns no active destination when no explicit route exists. Tests cover registry, rendering, and route behavior.

Changes

Secondary navigation cleanup

Layer / File(s)	Summary
Empty registries and route resolution src/lib/mode-secondary-navigation.ts	Seven modes now have empty secondary-navigation registries. Unmatched routes no longer select the first registry entry.
Registry-backed navigation rendering src/components/page-secondary-navigation.tsx, src/components/clinical-dashboard/global-search-shell.tsx, src/components/secondary-navigation.tsx	PageSecondaryNavigation no longer accepts onSearch or stickyTop, and it removes the legacy fallback. Registry navigation renders directly after route validation.
Navigation coverage and review record tests/mode-secondary-navigation.test.ts, tests/page-secondary-navigation.dom.test.tsx, tests/mode-nav-addon-slot.dom.test.tsx, docs/branch-review-ledger.md	Tests verify empty registries, route eligibility, rendered navigation, and removed props. The review ledger records validation results.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• BigSimmo/Database#1645: Directly modifies the same navigation components and registry behavior.
• BigSimmo/Database#1647: Covers the same registry-backed mode-navigation rollout and related tests.
• BigSimmo/Database#1642: Concerns shared mode-navigation registry behavior, including inert entries.

Suggested labels: codex

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the primary change: removing the vestigial one-button navigation strip.
Description check	✅ Passed	The description includes all required sections and documents scope, risks, verification results, blockers, and applicable governance checks.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/handover-review-nlhuln

---

_{Comment @coderabbitai help to get the list of available commands.}

[supabase]

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/branch-review-ledger.md`:
- Line 703: Update the 2026-08-07 ledger entry for commit
4ff613c10fbf734b1e740a31611296c17c791ec7 by appending a correction via the
ledger command. Replace the insufficient “lint exit 0” evidence with the
decisive lint output line, while preserving the rest of the verification
details.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 48364f73-402e-4901-bf0f-39dc3d9a25a4

📥 Commits

Reviewing files that changed from the base of the PR and between cd8f011 and c016740.

📒 Files selected for processing (8)

• docs/branch-review-ledger.md
• src/components/clinical-dashboard/global-search-shell.tsx
• src/components/page-secondary-navigation.tsx
• src/components/secondary-navigation.tsx
• src/lib/mode-secondary-navigation.ts
• tests/mode-nav-addon-slot.dom.test.tsx
• tests/mode-secondary-navigation.test.ts
• tests/page-secondary-navigation.dom.test.tsx

💤 Files with no reviewable changes (1)

• src/components/clinical-dashboard/global-search-shell.tsx