Skip to content

feat(answer): adopt AnswerCard on the live answer surface; resolve #207 vs #227 #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BigSimmo merged 13 commits into from
Aug 7, 2026
Merged

feat(answer): adopt AnswerCard on the live answer surface; resolve #207 vs #227 #1658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1af6953
feat(answer): adopt AnswerCard on the live answer surface; resolve #2…
BigSimmo Aug 6, 2026
a5f6419
ci: retrigger after Actions queue timeout
cursoragent Aug 6, 2026
ec5cbfe
fix(answer): address CodeRabbit review on AnswerCard adoption
cursoragent Aug 6, 2026
5b03ab9
Merge branch 'main' into claude/answer-shell-ds-adoption
BigSimmo Aug 6, 2026
d530738
Merge branch 'main' into claude/answer-shell-ds-adoption
BigSimmo Aug 6, 2026
5d0d89b
Merge branch 'main' into claude/answer-shell-ds-adoption
BigSimmo Aug 7, 2026
599222a
Merge branch 'main' into claude/answer-shell-ds-adoption
BigSimmo Aug 7, 2026
c8ddde5
Merge branch 'main' into claude/answer-shell-ds-adoption
BigSimmo Aug 7, 2026
786ab34
fix(answer): reclaim phone short-answer scroll after AnswerCard adoption
cursoragent Aug 7, 2026
89164b6
Merge branch 'main' into claude/answer-shell-ds-adoption
BigSimmo Aug 7, 2026
874f4ee
Merge branch 'main' into claude/answer-shell-ds-adoption
BigSimmo Aug 7, 2026
e73927d
Merge branch 'main' into claude/answer-shell-ds-adoption
BigSimmo Aug 7, 2026
ebb97dc
Merge branch 'main' into claude/answer-shell-ds-adoption
BigSimmo Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions docs/design-system/COMPONENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,14 +930,14 @@ tests to run.

Registered public components: 53
Components with a valid design-sync preview: 53
Components with product imports: 27
Components with product imports: 29

This generated snapshot is a local source-derived inventory. It does not assert remote design-project publication.

| Component | Family | Built | Locally registered | Observed v2 mount | Proof declared | Baseline committed | Product imports |
| ------------------------ | -------- | ----- | ------------------ | --------------------- | -------------- | ------------------ | --------------: |
| `AccessibleTable` | source | yes | yes | inherited-global-root | yes | no | 4 |
| `AnswerCard` | answer | yes | yes | no | yes | no | 0 |
| `AnswerCard` | answer | yes | yes | inherited-global-root | yes | no | 1 |
| `AnswerFooter` | answer | yes | yes | no | yes | no | 0 |
| `AsyncButton` | controls | yes | yes | inherited-global-root | yes | no | 4 |
| `Breadcrumb` | layout | yes | yes | inherited-global-root | yes | no | 1 |
Expand All @@ -947,7 +947,7 @@ This generated snapshot is a local source-derived inventory. It does not assert
| `Citation` | source | yes | yes | no | yes | no | 0 |
| `CitationList` | source | yes | yes | no | yes | no | 0 |
| `ConfirmDialog` | layout | yes | yes | no | yes | no | 0 |
| `DateDisplay` | source | yes | yes | inherited-global-root | yes | no | 2 |
| `DateDisplay` | source | yes | yes | inherited-global-root | yes | no | 3 |
| `Disclosure` | layout | yes | yes | no | yes | no | 0 |
| `DisclosureGroup` | layout | yes | yes | no | yes | no | 0 |
| `DoseLine` | answer | yes | yes | no | yes | no | 0 |
Expand All @@ -962,13 +962,13 @@ This generated snapshot is a local source-derived inventory. It does not assert
| `InlineNotice` | feedback | yes | yes | inherited-global-root | yes | no | 6 |
| `LinkAction` | controls | yes | yes | no | yes | no | 0 |
| `LoadingPanel` | feedback | yes | yes | inherited-global-root | yes | no | 7 |
| `MissingValue` | feedback | yes | yes | inherited-global-root | yes | no | 2 |
| `MissingValue` | feedback | yes | yes | inherited-global-root | yes | no | 3 |
| `OverlayRoot` | layout | yes | yes | inherited-global-root | yes | no | 1 |
| `PageHeader` | layout | yes | yes | inherited-global-root | yes | no | 2 |
| `Pagination` | controls | yes | yes | no | yes | no | 0 |
| `PanelHeading` | layout | yes | yes | inherited-global-root | yes | no | 2 |
| `Progress` | feedback | yes | yes | no | yes | no | 0 |
| `Quantity` | answer | yes | yes | no | yes | no | 0 |
| `Quantity` | answer | yes | yes | inherited-global-root | yes | no | 1 |
| `RadioGroup` | controls | yes | yes | no | yes | no | 0 |
| `RetrievalStateBanner` | answer | yes | yes | inherited-global-root | yes | no | 1 |
| `SafeBoldText` | layout | yes | yes | inherited-global-root | yes | no | 8 |
Expand All @@ -981,7 +981,7 @@ This generated snapshot is a local source-derived inventory. It does not assert
| `SourceProvenance` | source | yes | yes | inherited-global-root | yes | no | 1 |
| `SourceStatusBadge` | source | yes | yes | inherited-global-root | yes | no | 1 |
| `StageList` | feedback | yes | yes | no | yes | no | 0 |
| `StatusMark` | source | yes | yes | inherited-global-root | yes | no | 1 |
| `StatusMark` | source | yes | yes | inherited-global-root | yes | no | 2 |
| `Tabs` | controls | yes | yes | no | yes | no | 0 |
| `TextField` | controls | yes | yes | inherited-global-root | yes | no | 3 |
| `TextLink` | controls | yes | yes | no | yes | no | 0 |
Expand Down
2 changes: 1 addition & 1 deletion docs/design-system/adoption-contract.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,7 +592,7 @@
"status": "not-committed",
"files": []
},
"sanctionedSpecialPatterns": ["AnswerResultSurface", "VerificationNotice", "RetrievalStateBanner"],
"sanctionedSpecialPatterns": ["AnswerResultSurface", "RetrievalStateBanner"],
"documentedDisposition": "Answers are rendered inside the shared ClinicalDashboard route rather than a standalone page route."
},
{
Expand Down
46 changes: 23 additions & 23 deletions docs/design-system/adoption-manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,8 @@
"source": "src/components/ui/answer-card.tsx",
"sourceExported": true,
"entryExported": true,
"directImportFiles": [],
"productImportFiles": [],
"directImportFiles": ["src/components/clinical-dashboard/answer-result-surface.tsx"],
"productImportFiles": ["src/components/clinical-dashboard/answer-result-surface.tsx"],
"designSync": {
"listedInSourceMap": true,
"listedInDtsProps": true,
Expand All @@ -145,6 +145,7 @@
"tests/design-sync-contract.test.ts",
"tests/design-sync-visual-exports.test.ts",
"tests/design-system-adoption.test.ts",
"tests/ui-smoke.spec.ts",
"tests/ui-v2-answer-safety.dom.test.tsx"
],
"baseline": {
Expand All @@ -155,8 +156,8 @@
},
"built": true,
"locallyRegistered": true,
"v2ShellMounted": false,
"v2MountMode": "none",
"v2ShellMounted": true,
"v2MountMode": "inherited-global-root",
"proofDeclared": true,
"baselineCommitted": false
},
Expand Down Expand Up @@ -471,6 +472,7 @@
"src/components/ui/verification-notice.tsx"
],
"productImportFiles": [
"src/components/ui/answer-card.tsx",
"src/components/ui/retrieval-state-banner.tsx",
"src/components/ui/verification-notice.tsx"
],
Expand Down Expand Up @@ -978,7 +980,11 @@
"src/components/ui/answer-card.tsx",
"src/components/ui/date-display.tsx"
],
"productImportFiles": ["src/components/AccessibleTable.tsx", "src/components/ui/date-display.tsx"],
"productImportFiles": [
"src/components/AccessibleTable.tsx",
"src/components/ui/answer-card.tsx",
"src/components/ui/date-display.tsx"
],
"designSync": {
"listedInSourceMap": true,
"listedInDtsProps": true,
Expand Down Expand Up @@ -1155,7 +1161,7 @@
"sourceExported": true,
"entryExported": true,
"directImportFiles": ["src/components/ui/answer-card.tsx"],
"productImportFiles": [],
"productImportFiles": ["src/components/ui/answer-card.tsx"],
"designSync": {
"listedInSourceMap": true,
"listedInDtsProps": true,
Expand All @@ -1175,8 +1181,8 @@
},
"built": true,
"locallyRegistered": true,
"v2ShellMounted": false,
"v2MountMode": "none",
"v2ShellMounted": true,
"v2MountMode": "inherited-global-root",
"proofDeclared": true,
"baselineCommitted": false
},
Expand Down Expand Up @@ -1214,11 +1220,8 @@
"source": "src/components/ui/retrieval-state-banner.tsx",
"sourceExported": true,
"entryExported": true,
"directImportFiles": [
"src/components/clinical-dashboard/answer-result-surface.tsx",
"src/components/ui/answer-card.tsx"
],
"productImportFiles": ["src/components/clinical-dashboard/answer-result-surface.tsx"],
"directImportFiles": ["src/components/ui/answer-card.tsx"],
"productImportFiles": ["src/components/ui/answer-card.tsx"],
"designSync": {
"listedInSourceMap": true,
"listedInDtsProps": true,
Expand Down Expand Up @@ -1640,7 +1643,7 @@
"src/components/ui/citation.tsx",
"src/components/ui/retrieval-state-banner.tsx"
],
"productImportFiles": ["src/components/ui/retrieval-state-banner.tsx"],
"productImportFiles": ["src/components/ui/answer-card.tsx", "src/components/ui/retrieval-state-banner.tsx"],
"designSync": {
"listedInSourceMap": true,
"listedInDtsProps": true,
Expand Down Expand Up @@ -1853,11 +1856,8 @@
"source": "src/components/ui/verification-notice.tsx",
"sourceExported": true,
"entryExported": true,
"directImportFiles": [
"src/components/clinical-dashboard/answer-result-surface.tsx",
"src/components/ui/answer-card.tsx"
],
"productImportFiles": ["src/components/clinical-dashboard/answer-result-surface.tsx"],
"directImportFiles": ["src/components/ui/answer-card.tsx"],
"productImportFiles": ["src/components/ui/answer-card.tsx"],
"designSync": {
"listedInSourceMap": true,
"listedInDtsProps": true,
Expand Down Expand Up @@ -3046,17 +3046,17 @@
"files": []
},
"permittedComponentFamilies": ["answer", "controls", "feedback", "layout", "source"],
"sanctionedSpecialPatterns": ["AnswerResultSurface", "RetrievalStateBanner", "VerificationNotice"],
"sanctionedSpecialPatterns": ["AnswerResultSurface", "RetrievalStateBanner"],
"roots": [
{
"file": "src/components/clinical-dashboard/answer-result-surface.tsx",
"exists": true,
"imports": ["RetrievalStateBanner", "Sheet", "VerificationNotice"],
"imports": ["AnswerCard", "Sheet"],
"importedFamilies": ["answer", "layout"],
"literalCkbV2": false,
"dynamicCkbV2": false,
"v2MountMode": "inherited-global-root",
"sanctionedPatternsPresent": ["AnswerResultSurface", "VerificationNotice", "RetrievalStateBanner"]
"sanctionedPatternsPresent": ["AnswerResultSurface", "RetrievalStateBanner"]
Comment thread
coderabbitai[bot] marked this conversation as resolved.
},
{
"file": "src/components/clinical-dashboard/answer-thread-turn.tsx",
Expand Down Expand Up @@ -3239,7 +3239,7 @@
"summary": {
"registeredComponentCount": 53,
"previewCount": 53,
"productImportedComponentCount": 27,
"productImportedComponentCount": 29,
"rootCount": 55,
"productionRouteCount": 47,
"nextUiEntryCount": 99
Expand Down
Loading
Loading