Guard schema snapshot against NULL-generation artifact purge regressions

[Copilot]

Summary

• commit_document_index_generation already had replacement guards in migration logic, but the risk was schema snapshot drift back to unconditional NULL-generation deletes, which would erase legacy artifacts (for example document_images) during commits.

• Added regression coverage to lock in the guarded-delete contract across both live migration SQL and supabase/schema.sql.

• Schema snapshot parity guard

  • Added a fixture load for 20260702000000_commit_generation_preserve_legacy_artifacts.sql in tests/supabase-schema.test.ts.
  • Added a focused test asserting replacement-exists guard patterns are present for:
    • document_chunks
    • document_images
    • document_table_facts
    • document_embedding_fields
    • document_index_units
    • document_memory_cards
    • document_sections

• Example assertion pattern

  expect(sql).toContain(
    "nullif(metadata->>'index_generation_id', '') is null and exists ( select 1 from public.document_images replacement",
  );

Verification

• npm run verify:cheap
• npm run verify:ui when UI, routing, styling, browser behavior, reduced-motion, or forced-colors behavior changed
• npm run verify:release before release or handoff confidence claims
• npm run format:check
• npm run check:production-readiness when clinical workflow, privacy, environment, Supabase, source governance, or deployment behavior changed
• npm run check:deployment-readiness when deployment startup, hosting, or rollout behavior changed

Clinical Governance Preflight

Complete this section when the change touches ingestion, answer generation, search/ranking, source rendering, document access, privacy, production env, or clinical output.

• Source-backed claims still require linked source verification before clinical use
• No patient-identifiable document workflow was introduced or expanded without explicit governance approval
• Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
• Service-role keys and private document access remain server-only
• Demo/synthetic content remains clearly separated from real clinical sources
• Source metadata, review status, and outdated/unknown-source behavior remain conservative
• Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

Notes

• Scope is intentionally minimal: test-only guardrails to prevent future schema commits from reintroducing destructive NULL-generation artifact deletes.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c5914ec3e7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Assert the NULL-generation guard for every artifact table

The test claims to guard all artifact deletes, but after document_images these assertions only prove that a same-table replacement subquery exists somewhere in the SQL. A schema regression that changes, for example, document_memory_cards back to an unconditional nullif(metadata->>'index_generation_id', '') is null delete would still pass as long as the from public.document_memory_cards replacement text remains, so the destructive drift this test is meant to catch can slip through. Please assert the full is null and exists (...) guard per table, or isolate each delete block before checking it.

Useful? React with 👍 / 👎.