Search: add editable pins menu - #1631
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 32 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe change adds persisted editable search pins, integrates a pins-and-search popup with responsive focus handling, and adds two interactive mockup routes with design documentation and tests. ChangesEditable search pins
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant MasterSearchHeader
participant ModeActionPopup
participant SearchPinsMenu
participant BrowserStorage
User->>MasterSearchHeader: open Pins and search
MasterSearchHeader->>ModeActionPopup: render custom body
ModeActionPopup->>SearchPinsMenu: display pins and search controls
SearchPinsMenu->>BrowserStorage: read or persist normalized pins
SearchPinsMenu-->>MasterSearchHeader: select destination, mode, or action
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
Comment |
CI triageCI failed on this PR. Automated classification of the 3 failed job(s):
Compared with main CI run #8204 (cancelled). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
@codex resolve actionable Codex review findings for this pull request and current head using the repository instructions. This is the pull request's single automatic repair pass: do not perform a fresh review, create new standalone findings, or request another review. Work only the existing unresolved Codex threads on the current head. The only repository destination is BigSimmo/Database, and the only branch destination is the pull request head branch codex/editable-search-pins at starting commit a9b2aae; never publish fixes to a detached or synthetic work branch and never create a stacked pull request. Use the authenticated GitHub connector to commit each approved fix to BigSimmo/Database:codex/editable-search-pins, then verify that the pull request head contains the published commit before reporting success. Always fix P0 and P1 findings. For P2 and lower findings, fix only clear, scoped, low-risk issues; otherwise disposition them with a concise reason. For a fixed thread, reply with as the first line and as the second line. For a no-code disposition, use followed by . These result markers authorize the workflow to close that exact thread only after it verifies a fixed commit is the pull request head; a local-only commit is not a fix. If publication or verification fails, do not use either result marker, do not claim success, and leave the thread open with the blocker. If human input or new authorization is required, do the same. Finish only after every actionable thread is fixed or dispositioned and closed, or explicitly left open for a human decision. Do not update the branch from main, address unrelated reviews, broaden scope, or create more than one scoped fix commit. Do not use external APIs, paid services, credentials, dependency changes, or broad refactors unless explicitly authorized. Add targeted tests where behavior changes and run the narrowest relevant validation. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…-pins Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…-pins Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Address the last open review findings and residual polish: sheet autofocus for the first pin, null-detail pin sync that re-reads storage, Escape closing the editor first, confirm-before-delete, safer pin ids/defaults, scoped mode-action body scroll, shared command-dropdown displayability, and dead mode-select wiring cleanup.
Keep the null-detail pin sync fix while preserving the broader review follow-up changes on the local tip.
Resolve the leftover conflict hunk so null-detail CustomEvents re-read storage without resurrecting default pins.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Append the branch-review ledger row for tip 193afe6 after clearing the remaining pins-menu review threads.
… codex/editable-search-pins Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
… codex/editable-search-pins
Derive dropdown displayability from the shared media hook plus an eager focus override, clearing the override on blur or when media becomes undisplayable so lint no longer flags a cascading render.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Keep the nullable eager focus override for first-focus races, clear it on blur/undisplayable so media state can take over again, and drop the setState-in-effect mirror that failed Static PR lint.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…-pins Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Keep eager dropdown overrides from sticking false across resize, depend on custom-body truthiness for stable placement measurement, and retain the last written pin list in tab session memory when localStorage writes fail.
Combine the parallel review fixes for eager displayability, session pin memory, and stable custom-body placement, restore the test session reset helper, and avoid jsdom URL resolution in the placement contract test.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
… codex/editable-search-pins # Conflicts: # src/lib/search-pins.ts # tests/mode-action-popup.dom.test.tsx Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Resolve site-map and mockups-layout conflicts by keeping both the pins menu studies and the phone-mode-sheet-yes chrome suppressions from main.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
2 participants
Summary
+action menu with a responsive Pins and search surface.Verification
npm run verify:pr-localalso completed as a single command with exit 0 in 434 seconds.node scripts/run-vitest.mjs run tests/search-pins-menu.dom.test.tsx tests/search-pins.test.ts --reporter=dotnpm run typechecknpm run formatnpm run testnpm run verify:uiattempt exceeded the 20-minute shell window and returned no full-matrix result. Focused responsive owner/journey evidence is listed above; hosted CI remains required.Risk and rollout
feat(search): add editable pins menuand, if needed, the babysit follow-up commitda3e1b70cfe1d5f6c40e535a56ff37bd7ffa4d42.Clinical Governance Preflight
Clinical KB Database(sjrfecxgysukkwxsowpy)RAG impact: no retrieval behaviour change — this changes UI navigation, user-owned local preferences, and explicit search-mode controls only; retrieval selection and ranking are untouched.
Notes
origin/mainat68d477ed45fa3484ded70f29c41cbc46d0cef1c7with no failures; audited heada9b2aaed38c621788b05bfef982ab26cc53785a3.origin/mainatb03b51d7b22671f2734115b5fef469bd2e932ae3, then pushed fix commitda3e1b70cfe1d5f6c40e535a56ff37bd7ffa4d42.Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Tests