Privacy Live Signal: polish sticky obligation style - #1628
Conversation
Pad /privacy for notched-phone safe-area so the back control no longer sits under the status bar, and add a design-system study with Quiet ledger, Trust map, and Indexed brief comps (desktop + phone). Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Elevate direction 03: full-bleed sticky Important, phone jump chips locked into the sticky stack, index gists, one-open desktop default, and quieter processing map — plus dedicated perfected mockup comps.
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 24 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdded two privacy mockup routes. Added a three-direction redesign study and a perfected Live Signal mockup with responsive desktop and phone previews. Updated mockup navigation, shared chrome handling, sitemap entries, documentation, and the branch review ledger. ChangesPrivacy redesign study
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant Browser
participant PrivacyPageDirectionsMockups
participant PrivacyLiveSignalPerfectedMockups
participant LiveSignalPerfectedFrame
participant Accordion
Browser->>PrivacyPageDirectionsMockups: Open privacy-page directions route
PrivacyPageDirectionsMockups->>PrivacyLiveSignalPerfectedMockups: Render Live Signal previews
PrivacyLiveSignalPerfectedMockups->>LiveSignalPerfectedFrame: Create desktop and phone frames
LiveSignalPerfectedFrame->>Accordion: Render privacy sections
Accordion-->>LiveSignalPerfectedFrame: Update section expansion and navigation
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #8193 (cancelled). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
|
Flagging a duplicate-content issue found during a cross-PR review sweep (not editing this branch directly, since it's not mine): This branch's Once #1621 merges, this branch will hit a real conflict on that hunk. Recommend dropping the duplicate padding/back-control change from this branch (keep everything else — the Live Signal redesign mockups, the dedicated review route, the desktop+phone comps) and rebasing on top of what #1621 lands, rather than resolving it as a content merge. No action needed until #1621 lands — just flagging so the conflict is expected rather than surprising. Generated by Claude Code |
Prefix accordion panel ids with per-frame useId so desktop/phone comps do not collide; keep the Important notice panel mounted for aria-controls; clear sticky chrome on jump-scroll; key frame layout off the phone prop instead of viewport breakpoints; replace arbitrary font sizes with named type-scale steps to unblock Static PR checks.
Defer jump-chip / index scrollIntoView until useLayoutEffect so the previous panel collapse (and expand-all exit) has already updated heights before measuring the sticky-cleared target.
When the selected section is already open, React bails on identical state and the deferred layout effect never fires — scroll immediately on that path so re-tapping a chip or index row still recenters it.
Union the mockup registry conflicts so privacy Live Signal routes and the newly landed phone/pin mockups both remain discoverable.
- Keep main's searchPageShellStandalone + min-h-tap on /privacy after #1621. - Jump chips scroll only the device frame (not the review page) and use a single scroll-mt clearance so targets land under sticky chrome, not mid-frame.
When the Important notice is expanded, fixed scroll-mt clearance is too short. Measure StickySignalChrome height at jump time instead.
…ockups-2ff6 Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
CodeRabbit: fixed top-[13.5rem] lets expanded Important / text-zoom cover the signal index. Measure StickySignalChrome via ResizeObserver and use that height for the aside sticky offset. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
…ecks Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Summary
/privacyback-control safe-area so the control sits below the notch/mockups/privacy-live-signal-perfectedpublic/mockups/privacy-page-redesign-2026-08/useIdprefixes (fixes SRaria-controlscollisions), Important notice panel stays mounted when collapsed, jump-scroll clears sticky chrome and waits for accordion layout commit, frame layouts key off thephoneprop (not viewportsm:/lg:), named type-scale steps replace arbitrary font sizes that failed Static PRVerification
200at/mockups/privacy-live-signal-perfectednpm run formatbefore pushnpm run check:type-scale -- --strict— clean (✓ type-scale: no arbitrary text-[<n>px|rem|em] font sizes in src.)tests/privacy-ui.test.ts— 2 passedRisk and rollout
/privacychange is safe-area padding; redesign is mockup-only until adopted./privacysafe-area hunk in isolation. Once that lands, drop the duplicate padding change from this branch rather than content-merging it.Clinical Governance Preflight
Clinical KB Database(sjrfecxgysukkwxsowpy)Notes
Summary by CodeRabbit