Skip to content

fix: require approval for write-capable Cloud MCP tools - #1591

Merged
BigSimmo merged 9 commits into
mainfrom
codex/mcp-config-hardening-merge
Aug 2, 2026
Merged

fix: require approval for write-capable Cloud MCP tools#1591
BigSimmo merged 9 commits into
mainfrom
codex/mcp-config-hardening-merge

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Aug 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • Require approval for write-capable Figma, Railway, and Sentry MCP tools while retaining automatic approval for production read-only Supabase.
  • Make the project MCP validator fail closed on dotted credential headers, unparsed entries, and unsupported keys.
  • Keep Linux/Cloud shell-behaviour tests active in Linux CI while skipping those two cases in Windows worktrees, where WSL Git cannot resolve Windows gitdir pointers.
  • Update the Cloud contract documentation and review ledger.

Why

PR #1589 registered the Cloud MCP endpoints but auto-approved write-capable tools and allowed valid TOML forms such as dotted headers or unexpected keys to bypass the URL-only validator. Its Linux shell-behaviour tests also made the complete Windows-local suite fail.

Areas touched

  • .codex/config.toml
  • scripts/check-codex-cloud-setup.mjs
  • tests/codex-cloud-setup.test.ts
  • Cloud documentation and branch review ledger

Verification

  • npm run check:codex-cloud — passed.
  • npm test -- tests/codex-cloud-setup.test.ts — 16 passed, 2 Windows-only skips.
  • npm run verify:pr-local — passed: lint, typecheck, docs/workflow/policy gates, 214 CI-workflow tests, 479 test files, 4998 tests passed, 5 skipped, and offline RAG fixture validation.
  • npm run format — completed before push; no unrelated files changed.

Checks not run

  • No live Figma, Railway, Sentry, Supabase, OpenAI, deployment, or paid-provider calls were made. The patch is a disabled-by-default project configuration and offline validator change.
  • The two setup-codex-cloud.sh behavioural cases are Linux/Cloud-only and will run in hosted Linux CI.

Risk and rollback

The MCP servers remain enabled = false, endpoints remain unchanged, and credentials remain in the host credential store. The main residual dependency is correct MCP read/write tool annotation by each provider. Rollback is a normal revert of this PR.


Open in Devin Review

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 15 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a302877b-a3c3-4338-81b5-4c8c1155b06d

📥 Commits

Reviewing files that changed from the base of the PR and between ccb21d9 and 26fd298.

📒 Files selected for processing (7)
  • .codex/config.toml
  • AGENTS.md
  • docs/branch-review-ledger.md
  • docs/codebase-index.md
  • docs/codex-cloud.md
  • scripts/check-codex-cloud-setup.mjs
  • tests/codex-cloud-setup.test.ts

Comment @coderabbitai help to get the list of available commands.

@supabase

supabase Bot commented Aug 2, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

View 1 additional finding in Devin Review.

Open in Devin Review

Comment thread scripts/check-codex-cloud-setup.mjs Outdated
Comment thread scripts/check-codex-cloud-setup.mjs Outdated
@BigSimmo
BigSimmo merged commit 88c259e into main Aug 2, 2026
23 checks passed
@BigSimmo
BigSimmo deleted the codex/mcp-config-hardening-merge branch August 2, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant