fix: require approval for write-capable Cloud MCP tools - #1591
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 15 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
…ening-merge # Conflicts: # tests/codex-cloud-setup.test.ts
Summary
gitdirpointers.Why
PR #1589 registered the Cloud MCP endpoints but auto-approved write-capable tools and allowed valid TOML forms such as dotted headers or unexpected keys to bypass the URL-only validator. Its Linux shell-behaviour tests also made the complete Windows-local suite fail.
Areas touched
.codex/config.tomlscripts/check-codex-cloud-setup.mjstests/codex-cloud-setup.test.tsVerification
npm run check:codex-cloud— passed.npm test -- tests/codex-cloud-setup.test.ts— 16 passed, 2 Windows-only skips.npm run verify:pr-local— passed: lint, typecheck, docs/workflow/policy gates, 214 CI-workflow tests, 479 test files, 4998 tests passed, 5 skipped, and offline RAG fixture validation.npm run format— completed before push; no unrelated files changed.Checks not run
setup-codex-cloud.shbehavioural cases are Linux/Cloud-only and will run in hosted Linux CI.Risk and rollback
The MCP servers remain
enabled = false, endpoints remain unchanged, and credentials remain in the host credential store. The main residual dependency is correct MCP read/write tool annotation by each provider. Rollback is a normal revert of this PR.