Docs: pin GitHub acceptance ref identity - #1574
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
📝 WalkthroughWalkthroughThe GitHub acceptance instructions now require published branch and draft PR links as write-verification evidence before cleanup approval. ChangesAcceptance Guidance
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/codex-cloud.md`:
- Around line 154-155: Update the write-verification requirements in the
documented workflow so branch and draft PR links are required only when their
respective publication or creation operations succeed; when either operation
fails, require its failure reason and explicitly state that no link is
available.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: edd7ddd7-5bc2-4807-8bc8-1a96ff1d92ae
📒 Files selected for processing (1)
docs/codex-cloud.md
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9af4d85bee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Status
The original controlled GitHub write test did not prove publication of the expected ref:
codex/github-connector-write-test-202608022f1a09b5d0ceb3e8ae2ea689f1d96ef8efe6a185codex/test-github-integration-after-reconnectionef644b72f6e838820888eb6723d47309afdcdc92Change
The acceptance task now requires a task to record its expected branch and full HEAD SHA, publish that exact existing ref without reconstruction, and report whether the published ref matches exactly. It also retains conditional links for successful writes and explicit failure/no-link reporting.
Verification
npm run verify:pr-local -- --dry-run --files docs/codex-cloud.mdnpm run verify:pr-local -- --files docs/codex-cloud.mdnpm run formatgit diff --checkThe current Cloud environment validation remains read-only and independent of this documentation change.
Original Codex task