Skip to content

DS V2 PR-A: correctness — HCM proofs, contrast/disabled, prop unions #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BigSimmo merged 4 commits into from
Aug 1, 2026
Merged

DS V2 PR-A: correctness — HCM proofs, contrast/disabled, prop unions #1570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d23f5b5
Close DS V2 correctness slices 2–4 (HCM, contrast/disabled, prop unio…
BigSimmo Aug 1, 2026
1aa9822
Fold ckb-v2 HCM computed proofs into ui-style-contract.
BigSimmo Aug 1, 2026
7c06d2c
Record PR-A review ledger evidence before push.
BigSimmo Aug 1, 2026
d5e90b8
Fix live placeholder token, strip BOMs, and close review nits.
BigSimmo Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/branch-review-ledger.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,3 +584,4 @@ Records before 2026-07-28 were written by hand and had drifted: 146 lines carrie
| 2026-08-01 | claude/ds-v2-tooling-loop | 40181192519fddc9405523d06bd3e691096cda6c | PR-0 tooling loop: Context7 + Chrome DevTools MCP wiring, design-sync and mockup-capture scripts, docs/env-example updates (11 files, +1005/-11, no clinical or RAG surfaces) | gates green | verify:pr-local: format/lint/typecheck/lock-parity green; unit 4803 passed, 6 env-class WSL relay failures in ci-cache-safety.test.ts (Ubuntu distro stopped), focused rerun 13/13 green after WSL boot; check:rag:fixtures 36 golden cases green; build skipped by selector |
| 2026-08-01 | claude/ds-v2-tooling-loop (PR #1568) | f6317ea48355c26e080ce45b6f574159e8397e24 | PR #1568 unblock/fix | merged origin/main (behind-but-clean; merge-tree was clean); cleared GitHub DIRTY/CONFLICTING; advisory review threads left open (not merge/CI blockers); auto-merge remains armed | merge-tree clean; ahead 7 behind 0; no provider-backed checks; no product code fix needed |
| 2026-08-01 | claude/ds-v2-tooling-loop (PR #1568) | b76bcc9fbc39f2f986a52869c810ba3cb89994f2 | PR #1568 review-thread resolve | fixed and resolved all 13 review threads (fail-closed project identity, inventory exit code, provenance demo id, buildCmd execution, chrome pin, context7 rollback); ledger row for superseded 93d41c1 dispositioned | node --check scripts; design-sync --dry-run; no provider-backed checks |
| 2026-08-01 | claude/ds-v2-correctness | 1aa9822978668a10447ef3246bd60cda6f1208cb | ds-v2 PR-A correctness (HCM/contrast/prop-unions) | ready-to-merge | unit 4878p; verify:ui 344p; style-contract HCM 5p; verify:pr-local green (eval:rag:offline 574/574; fixture 36/23); typecheck+ds-contract green |
52 changes: 26 additions & 26 deletions docs/design-system/COMPONENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,32 +97,32 @@ print primitives (`PrintHeader`, `PrintFooter`, `CitationFootnote`, `PrintOnly`,

### 0.4 Open-defect ledger (existing components → closing PR)

| Component | Open defects (compressed) | Closes in |
| ---------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------ | ------------------------------ |
| Button | danger contrast token · brightness hover/active bypass tokens · 44px comment · no ref · needless client boundary | PR 3, PR 4 |
| AsyncButton | no `type="button"` (can submit a form) | PR 4 (retire or alias) |
| IconButton | `disabled:opacity` (one of 10 remaining uses) | PR 3 |
| ToggleSwitch | unnameable · knob animates `left`/`right` · opacity disabled | PR 4, PR 9 |
| Chip | 20px remove target · optional `removeLabel` · no full-value path | PR 4 |
| TextField/SearchField/Select | hint dropped on error (comment promises otherwise) · describedBy overwritten · placeholder on the decoration tier · no external id/refs | PR 7 |
| Checkbox/RadioGroup | RadioGroup inert-control contract · raw dimensions · unsanitised ids · no group hint/error | PR 4, PR 7 |
| Citation/CitationList | enabled-inert · `aria-label` on bare span · index keys · unstructured data | PR 4 |
| DoseLine | must compose `Quantity` · structured dose model · overdue text + non-colour mark + open action | PR 6 |
| StatusMark | app-type coupling · inline styles/raw geometry · HCM asserted-not-proven | PR 2, PR 12 |
| AnswerCard | unrestricted slots — no required verification/answer state | PR 6 |
| AnswerFooter | accepts preformatted strings; must take machine values + compose `DateDisplay` + `MissingValue` | PR 6 |
| PageHeader/Breadcrumb | `<h1>` truncates · actions starve title · low-contrast eyebrow | PR 3, PR 7-adjacent layout fix |
| Tabs | `aria-controls` to unrendered panels · invalid selected value can empty the tab order · split `SegmentedControl` | PR 4-adjacent, own tranche |
| Pagination | unclamped props · 320px overflow · opacity disabled · no focus/announce policy | PR 3, PR 8 |
| Links | `tone` leaks to DOM · `download` overridable by spread · `gap` animation · new-tab policy implicit | PR 9 |
| Tooltip | overwrites child handlers/describedBy · no portal/collision/delay · hardcoded z | PR 10 |
| Toast | z below `--z-toast` · warning=danger icon · urgency coupled to tone · no pause on hover/focus · no portal/queue cap | PR 10 |
| Sheet/ConfirmDialog | optional name · portal default off · hardcoded z/duration · title truncates · bare "Confirm" default | PR 10 |
| Disclosure | hardcoded `<h3>` · no print behaviour · truncation | PR 11 |
| Progress/StageList | width animation · "step 0 of N" · whole-list live region | PR 8, PR 9 |
| EmptyState | `live="polite"` by default | PR 8 |
| AccessibleTable | div caption vs `aria-label` · optional caption · uppercase dense headers · **bare `-` for missing cells** · inline equal widths · hand-rolled expander | PR 6 (`MissingValue`), PR 12 |
| ui-primitives.tsx | 572-line module mixing recipes/actions/feedback/clinical — split | PR 12 |
| Component | Open defects (compressed) | Closes in |
| ---------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------ | ---------------------------- |
| Button | brightness hover/active bypass tokens · 44px comment · no ref · needless client boundary (danger contrast landed #1538) | follow-on |
| AsyncButton | `type` applied after spread (default `button`; explicit `submit` preserved). Prefer `Button` busy API for new sites. | **done** (PR-A) |
| IconButton | disabled encoding uses `controlDisabled` (opacity retired in PR-A) | **done** (PR-A) |
| ToggleSwitch | operable branch requires `aria-label`; opacity disabled retired; knob still animates `left`/`right` | PR 9 (motion) |
| Chip | 20px remove target · `removeLabel` required when removable · no full-value path | PR 12 (target size) |
| TextField/SearchField/Select | hint dropped on error (comment promises otherwise) · describedBy overwritten · no external id/refs (placeholder off decoration tier in PR-A) | PR 7 |
| Checkbox/RadioGroup | RadioGroup controlled/uncontrolled union done; raw dimensions · unsanitised ids · no group hint/error | PR 7 |
| Citation/CitationList | interactive requires `onActivate`; static form uses `aria-label` on span · index keys · unstructured data | follow-on |
| DoseLine | must compose `Quantity` · structured dose model · overdue text + non-colour mark + open action | PR 6 |
| StatusMark | app-type coupling · inline styles/raw geometry · HCM token remaps proven (computed suite); mark shape still visual | PR 12 |
| AnswerCard | unrestricted slots — no required verification/answer state | PR 6 |
| AnswerFooter | accepts preformatted strings; must take machine values + compose `DateDisplay` + `MissingValue` | PR 6 |
| PageHeader/Breadcrumb | `<h1>` truncates · actions starve title · eyebrow ink moved off decoration (PR 3); layout starve remains | PR 7-adjacent layout fix |
| Tabs | `aria-controls` to unrendered panels · invalid selected value can empty the tab order · split `SegmentedControl` | PR 4-adjacent, own tranche |
| Pagination | unclamped props · 320px overflow · opacity disabled retired · no focus/announce policy | PR 8 |
| Links | `tone` leaks to DOM · `download` overridable by spread · `gap` animation · new-tab policy implicit | PR 9 |
| Tooltip | overwrites child handlers/describedBy · no portal/collision/delay · hardcoded z | PR 10 |
| Toast | z below `--z-toast` · warning=danger icon · urgency coupled to tone · no pause on hover/focus · no portal/queue cap | PR 10 |
| Sheet/ConfirmDialog | optional name · portal default off · hardcoded z/duration · title truncates · bare "Confirm" default | PR 10 |
| Disclosure | hardcoded `<h3>` · no print behaviour · truncation | PR 11 |
| Progress/StageList | width animation · "step 0 of N" · whole-list live region | PR 8, PR 9 |
| EmptyState | `live="polite"` by default | PR 8 |
| AccessibleTable | div caption vs `aria-label` · optional caption · uppercase dense headers · **bare `-` for missing cells** · inline equal widths · hand-rolled expander | PR 6 (`MissingValue`), PR 12 |
| ui-primitives.tsx | 572-line module mixing recipes/actions/feedback/clinical — split | PR 12 |
Comment thread
coderabbitai[bot] marked this conversation as resolved.

---

Expand Down
Loading
Loading