Skip to content

fix: resolve bounded outstanding reliability tasks - #1480

Merged
BigSimmo merged 26 commits into
mainfrom
codex/outstanding-local-batch-final
Jul 30, 2026
Merged

fix: resolve bounded outstanding reliability tasks#1480
BigSimmo merged 26 commits into
mainfrom
codex/outstanding-local-batch-final

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Jul 30, 2026

Copy link
Copy Markdown
Owner

Summary

Validation

  • npm run check:installed-lock-parity (pass on Node 24 / npm 11)
  • focused Vitest after the final review fix: 4 files, 63 tests passed
  • earlier bounded focused suite: 7 files, 125 tests passed
  • npm run check:branch-review-ledger (pass)
  • npm run check:outstanding-issues (pass)
  • npm run docs:check-index (pass: all 49 repository roots/modules/routes and schema tables indexed)
  • npm run docs:check-links (pass: 1427 repository references resolve)
  • npm run check:upload-limit-parity (pass: self-test and 150 MB default parity)
  • npm run check:github-actions (pass)
  • exact-head official CI run 30567269931 (pass), including PR required and all three Production UI shards
  • Production UI shard 1 decisive result: 121 passed in 6.6 minutes
  • one independent dispatch attempt saw an intermittent Services viewport-anchor failure; the official exact-head run passed the same test, and the failed dispatch was rerun/canceled after the required run proved the head
  • final local merge audit: clean merge tree e0605588626b882beb591115d0211585372a6288
  • post-merge proof: origin/main tree, reviewed head tree, and expected merge tree all equal e0605588626b882beb591115d0211585372a6288; production health status ok

Clinical governance preflight

Not applicable: no ingestion, answer generation, retrieval/ranking, source selection/rendering, document access, privacy, production environment, or clinical-output behavior changed.

Risk and rollback

  • Risk is limited to CI trigger behavior, Docker build-time upload-limit validation, shared result-band status/retry rendering, docs-index coverage, and theme token resolution.
  • Rollback by reverting squash commit 282b9af; no provider configuration, schema migration, production data, or retrieval behavior change is included.

Notes

Merged with exact head matching after zero unresolved review threads and zero blocking labels.

RAG impact: no retrieval behaviour change — this batch does not touch retrieval, ranking, source selection, or RAG fixtures.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 33 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0b018360-9b63-463e-91af-566bf5d5fcee

📥 Commits

Reviewing files that changed from the base of the PR and between a1ea90b and 416d8ea.

📒 Files selected for processing (8)
  • .github/workflows/ci.yml
  • CLAUDE.md
  • docs/branch-review-ledger.md
  • docs/codebase-index.md
  • docs/redesign/permanent-colour-direction.md
  • src/components/clinical-dashboard/favourites-command-library-page.tsx
  • src/components/clinical-dashboard/search-results-header-band.tsx
  • tests/search-results-header-band.dom.test.tsx
📝 Walkthrough

Walkthrough

The PR adds explicit partial-data states to favourites and search interfaces, strengthens repository index and ledger validation, defines a clinical accent token across themes, and updates CI, Docker build arguments, repository documentation, and review ledger records.

Changes

Partial favourites and search states

Layer / File(s) Summary
Partial status contracts and derivation
src/components/clinical-dashboard/saved-registry-favourites-status.ts, src/components/clinical-dashboard/search-results-header-band.tsx
Status unions and folding logic now represent partially available data separately from ready, loading, unauthorized, and error states.
Partial-state UI and tests
src/components/clinical-dashboard/favourites-command-library-page.tsx, src/components/clinical-dashboard/favourites-hub.tsx, src/components/clinical-dashboard/search-results-header-band.tsx, tests/*favourites*, tests/*search-results*
Partial registry loads show warning messaging, adjusted empty states, honest counts, and retry controls, with corresponding tests.

Repository validation and ledger checks

Layer / File(s) Summary
Tracked repository-root index coverage
scripts/check-codebase-index-coverage.mjs, tests/codebase-index-coverage.test.ts, docs/codebase-index.md, CLAUDE.md
Index coverage now discovers tracked root directories and validates their documentation in the top-level layout section.
Ledger merge-driver validation
scripts/check-branch-review-ledger.mjs, tests/repo-hygiene.test.ts, docs/branch-review-ledger.md
Ledger validation checks the configured custom merge driver and tests missing-driver failures; ledger records are updated.

Clinical accent token

Layer / File(s) Summary
Accent token mappings and contracts
src/app/globals.css, docs/redesign/permanent-colour-direction.md, .design-sync/NOTES.md, tests/design-token-contract.test.ts
--clinical-accent-strong maps to --primary-700 in both themes and LinkText in forced-colors mode, with palette, notes, contrast, and presence coverage.

Workflow and repository layout updates

Layer / File(s) Summary
Workflow configuration and repository layout
.github/workflows/*, CLAUDE.md
CI pull-request triggers are constrained to selected event types, Docker builds use 50 MB upload-limit arguments, and repository layout documentation lists additional directories.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

Suggested reviewers: claude

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 23.53% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The description covers Summary, Validation, and Risk/rollback, but it omits the template's Clinical Governance Preflight and Notes sections. Add the Clinical Governance Preflight checklist if applicable and a brief Notes section, or explicitly state why they are not needed.
✅ Passed checks (3 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title matches the main goal: resolving several bounded reliability tasks across CI, docs, UI, and token checks.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@supabase

supabase Bot commented Jul 30, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@BigSimmo BigSimmo added the skip-branch-sync Opt out of hosted pr-branch-sync / update-branch on this PR label Jul 30, 2026
@BigSimmo
BigSimmo marked this pull request as ready for review July 30, 2026 15:50

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7b63c28ca6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/check-upload-limit-config.mjs Outdated
@BigSimmo

Copy link
Copy Markdown
Owner Author

@codex resolve actionable Codex review findings for this pull request and current head using the repository instructions. This is the pull request's single automatic repair pass: do not perform a fresh review, create new standalone findings, or request another review. Work only the existing unresolved Codex threads on the current head. Always fix P0 and P1 findings. For P2 and lower findings, fix only clear, scoped, low-risk issues; otherwise disposition them with a concise reason. After fixing or dispositioning a thread, reply in that thread with as the first line, followed by a concise summary; that marker authorizes the workflow to close that exact thread. If human input or new authorization is required, do not use the marker and leave the thread open with the blocker. Finish only after every actionable thread is fixed or dispositioned and closed, or explicitly left open for a human decision. Do not update the branch from main, address unrelated reviews, broaden scope, or create more than one scoped fix commit. Do not use external APIs, paid services, credentials, dependency changes, or broad refactors unless explicitly authorized. Add targeted tests where behavior changes and run the narrowest relevant validation.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: f190f04c8c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

BigSimmo added 2 commits July 31, 2026 00:15
…al-batch-final

# Conflicts:
#	.github/workflows/docker-image.yml
#	Dockerfile
#	docs/deployment-architecture.md
#	package.json

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/redesign/permanent-colour-direction.md`:
- Line 50: Add a dark-mode palette table row for --clinical-accent-strong in
permanent-colour-direction.md, documenting its dark-mode value as `#A9D8F8` and
preserving the existing description and table format.

In `@src/components/clinical-dashboard/favourites-command-library-page.tsx`:
- Around line 1045-1053: Update SearchResultsHeaderBand to render the Retry
affordance for partial states, and ensure the favourites command-library page
passes refetchFavouritesRegistry when favouritesRegistryStatus is "partial" as
well as faulted states. Add a DOM test covering retry for partial results,
matching FavouritesHub’s existing partial-retry behavior.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a15e763a-5232-4bea-8553-51746f85049a

📥 Commits

Reviewing files that changed from the base of the PR and between 6431cec and a1ea90b.

📒 Files selected for processing (20)
  • .design-sync/NOTES.md
  • .github/workflows/ci.yml
  • .github/workflows/docker-image.yml
  • CLAUDE.md
  • docs/branch-review-ledger.md
  • docs/codebase-index.md
  • docs/redesign/permanent-colour-direction.md
  • scripts/check-branch-review-ledger.mjs
  • scripts/check-codebase-index-coverage.mjs
  • src/app/globals.css
  • src/components/clinical-dashboard/favourites-command-library-page.tsx
  • src/components/clinical-dashboard/favourites-hub.tsx
  • src/components/clinical-dashboard/saved-registry-favourites-status.ts
  • src/components/clinical-dashboard/search-results-header-band.tsx
  • tests/codebase-index-coverage.test.ts
  • tests/design-token-contract.test.ts
  • tests/favourites-hub-unavailable-controls.dom.test.tsx
  • tests/repo-hygiene.test.ts
  • tests/saved-registry-favourites-status.test.ts
  • tests/search-results-header-band.dom.test.tsx

Comment thread docs/redesign/permanent-colour-direction.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-branch-sync Opt out of hosted pr-branch-sync / update-branch on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant