Skip to content

fix: harden inactive-work cleanup verification - #1462

Merged
BigSimmo merged 9 commits into
mainfrom
codex/organize-inactive-20260730
Jul 30, 2026
Merged

fix: harden inactive-work cleanup verification#1462
BigSimmo merged 9 commits into
mainfrom
codex/organize-inactive-20260730

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Jul 30, 2026

Copy link
Copy Markdown
Owner

Summary

  • record two bounded reviews covering twenty clean inactive-work candidates, with physical deletion still protected by the primary-checkout lease
  • make the push formatter discover Prettier only from local or registered worktrees with a byte-identical lockfile and matching installed version
  • fail the push closed with an explicit npm ci --include=dev remediation when no exact-lock formatter exists; the silent prettier not resolvable — format check skipped path is removed
  • fail closed when the exact-lock dependency tree cannot be linked into the pushed-commit scratch checkout
  • add focused contracts for exact-lock sibling selection and missing-Prettier failure
  • synchronize current main, including PR fix: guard upload limits in production builds #1441's independent Windows-safe CI shell-test harness

RAG impact: no retrieval behaviour change — cleanup records and local verification tooling only; the old unvalidated retrieval residue remains explicitly rejected.

Verification

  • exact-lock dependency junction established and verified: Next 16.2.12, React 19.2.8, Playwright 1.62.0, TypeScript 6.0.3, Vitest 4.1.10
  • npm ls --depth=0 --json
  • npm run guard:push:self-test[guard-push] self-test passed
  • focused Vitest — 2 files passed, 28 tests passed
  • direct Windows aggregate probe — green exits 0; cancelled and failure scenarios exit 1 with the intended messages
  • npm run format:checkAll matched files use Prettier code style!
  • final npm run format:changedAll matched files use Prettier code style!
  • final pushed-commit guard simulation and both real pushes completed without a format skip or override
  • npm run check:branch-review-ledger — 165 live records + 1206 archived; no duplicates/conflict markers
  • npm run check:outstanding-issues — 141 rows; unique ids; next-id 147
  • git diff --check origin/main...HEAD
  • broad offline verification passed every static gate and lint; its first run also passed typecheck and ran all 436 unit files, isolating six Windows harness failures in ci-cache-safety; PR fix: guard upload limits in production builds #1441 independently landed the equivalent harness fix on main
  • final post-merge typecheck/full-unit replay — repository coordinator repeatedly denied admission while live Playwright/build/install owners held the exclusive lane; no lock was bypassed. The changed guard contracts are green and the earlier full run passed 435/436 files before the now-main harness fix.

Risk and rollback

  • Risk: low and local-only. Missing formatter dependencies now block instead of silently weakening verification.
  • Explicit emergency override remains SKIP_FORMAT_GUARD=1.
  • Rollback: revert 61266ee1a for the verification-tooling change; cleanup records remain independently revertible.
  • No deployment, hosted-CI rerun, provider workflow, production data operation, dependency-version change, force-push, or destructive cleanup was performed.

Notes

  • No worktree or branch was deleted. The primary checkout lease remains the authority for the twenty pending cleanup candidates.
  • docs/outstanding-issues.md includes a mechanical Prettier table realignment because the old pushed head failed the repository formatting contract.
  • Branch is synchronized with origin/main at d8b034c8a7aa07081bf3f4f62cbfc0841f7d8c00; PR head is e7b248e215714fbf823c784857f521f89d86fa3d.

@supabase

supabase Bot commented Jul 30, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 21 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 74c6d207-b50a-4da9-8f62-73860d80f880

📥 Commits

Reviewing files that changed from the base of the PR and between ecc59a8 and f99bb06.

📒 Files selected for processing (6)
  • AGENTS.md
  • docs/branch-review-ledger.md
  • docs/outstanding-issues.md
  • docs/process-hardening.md
  • scripts/guard-push.mjs
  • tests/guard-push.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

CI triage

CI failed on this PR. Automated classification of the 2 failed job(s):

  • Static PR checksneeds investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
  • PR requiredneeds investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.

Compared with main CI run #6987 (cancelled).

Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2292da7c4b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/outstanding-issues.md Outdated
@BigSimmo
BigSimmo enabled auto-merge (squash) July 30, 2026 14:07
@BigSimmo
BigSimmo disabled auto-merge July 30, 2026 14:10
@BigSimmo
BigSimmo enabled auto-merge (squash) July 30, 2026 14:13
@BigSimmo
BigSimmo disabled auto-merge July 30, 2026 14:26
BigSimmo added 3 commits July 30, 2026 23:54
…ve-20260730

# Conflicts:
#	docs/outstanding-issues.md
…ve-20260730

# Conflicts:
#	docs/outstanding-issues.md
#	tests/ci-cache-safety.test.ts
@BigSimmo BigSimmo changed the title docs: record bounded inactive-work cleanup review fix: harden inactive-work cleanup verification Jul 30, 2026
@BigSimmo BigSimmo added the skip-branch-sync Opt out of hosted pr-branch-sync / update-branch on this PR label Jul 30, 2026
@BigSimmo
BigSimmo merged commit f6ae0e7 into main Jul 30, 2026
23 checks passed
@BigSimmo
BigSimmo deleted the codex/organize-inactive-20260730 branch July 30, 2026 17:02
BigSimmo pushed a commit that referenced this pull request Jul 30, 2026
Third docs/outstanding-issues.md conflict, this time against #1462, #1467 and
#1482. That file carries no merge driver by design (#133), so any overlapping
edit conflicts; main is landing issue-ledger commits continuously.

Resolved by the same prescribed recipe: rebuilt from origin/main and re-applied
only this branch's own #86 "Hydration SHIPPED (#101)" edit. Verified identical
row count (146) and identical id set to origin/main, so the archived rows from
all three of those PRs are preserved and nothing was dropped.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GGEBHp4Seoh1jK1vGTNtYS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-branch-sync Opt out of hosted pr-branch-sync / update-branch on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant