Skip to content

Polish responsive document result cards - #1388

Merged
BigSimmo merged 11 commits into
mainfrom
codex/document-results-responsive-polish
Jul 29, 2026
Merged

Polish responsive document result cards#1388
BigSimmo merged 11 commits into
mainfrom
codex/document-results-responsive-polish

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Jul 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • make document result cards more compact and visually restrained without changing search or source-selection behavior
  • use three equal action columns on phones, returning to a natural horizontal toolbar from tablet upward
  • soften source-governance warning hierarchy while retaining the warning accent and existing content
  • add responsive, typography, overflow, focus, reduced-motion, and forced-colors browser coverage

RAG impact: no retrieval behaviour change — presentation-only changes to existing document results and source-governance notices.

Verification

  • npm run verify:pr-local
    • Local run pending repository heavy-lane availability; focused equivalents below passed.
  • npm run verify:ui when UI, routing, styling, browser behavior, reduced-motion, or forced-colors behavior changed
    • Focused production Playwright journey passed; full local matrix pending repository heavy-lane availability and required hosted UI checks must pass before merge.
  • npm run verify:release before release or handoff confidence claims
    • Not run locally; exact-head hosted checks and final merge audit are required before merge.
  • npm run check:installed-lock-parity
  • Focused ESLint
  • npm run typecheck
  • Focused unit tests: 30 passed
  • Isolated production Playwright document-search journey: 1 passed, covering 320/390/639/768/1440/1920px, keyboard focus, reduced motion, forced colors, and horizontal overflow
  • verify:cheap static/design/governance gates plus full lint passed; its repeated typecheck admission was blocked by another worktree's exclusive Playwright lease after the standalone typecheck had passed
  • npm run check:production-readiness
    • Isolated worktree has no .env.local; no secrets were copied. Hosted/environment-aware checks are required before merge.

Risk and rollout

  • Risk: Low UI risk. Styling and test changes only; no retrieval, ranking, answer, source-selection, API, database, or provider behavior changes.
  • Rollback: Revert the squash commit to restore the prior card spacing, typography, warning styling, and action layout.
  • Provider or production effects: GitHub PR/CI and the requested merge only. No Supabase, OpenAI, Railway, or production-data mutation.

Clinical Governance Preflight

  • Source-backed claims still require linked source verification before clinical use
  • No patient-identifiable document workflow was introduced or expanded without explicit governance approval
  • Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
  • Service-role keys and private document access remain server-only
  • Demo/synthetic content remains clearly separated from real clinical sources
  • Source metadata, review status, and outdated/unknown-source behavior remain conservative
  • Deployment classification/TGA SaMD impact checked: presentation-only change; no clinical decision-support behavior change

Notes

  • Based on fresh origin/main; synchronized after PR Add condensed document reader view #1380 landed using a normal merge commit, with no rebase or force-push.
  • Exact reviewed code commit: 94bef3d193f449e6396b1bf4688180281d260ca7.

Summary by CodeRabbit

  • UI Improvements

    • Polished document search result cards with improved spacing, responsive layouts, clearer match indicators, and refined action controls.
    • Updated document actions to display appropriately across narrow and wide screens.
    • Refined scope and governance notices, including warning text, expandable source details, and visual hierarchy.
  • Bug Fixes

    • Improved action visibility and layout behavior in high-contrast display modes.
  • Tests

    • Added responsive and accessibility checks covering document result actions across viewport sizes.

@supabase

supabase Bot commented Jul 29, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 31 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a470669f-65af-44cb-8729-d6eb39b3d3e9

📥 Commits

Reviewing files that changed from the base of the PR and between 32bfe47 and c9141be.

📒 Files selected for processing (3)
  • docs/branch-review-ledger.md
  • src/components/clinical-dashboard/document-search-results.tsx
  • tests/ui-smoke.spec.ts
📝 Walkthrough

Walkthrough

Document search result cards and governance notices receive responsive spacing and styling updates. UI smoke tests verify action layouts across viewport sizes and forced-color modes, while the review ledger records verification results.

Changes

Clinical dashboard UI

Layer / File(s) Summary
Responsive document result cards
src/components/clinical-dashboard/document-search-results.tsx, tests/ui-smoke.spec.ts, docs/branch-review-ledger.md
Document result spacing, card content, badges, tags, and responsive Open/Scope/Answer action layouts are updated and tested across viewport sizes and forced-color modes.
Governance notice styling
src/components/clinical-dashboard/answer-content.tsx
Scope and grouped governance warnings use revised spacing, typography, colors, and expandable source styling.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

  • BigSimmo/Database#497: Updates the same document-search smoke test with an Open-link URL assertion.
  • BigSimmo/Database#936: Refactors the clinical dashboard document search UI and integrates governance notices.

Suggested reviewers: claude, cursoragent

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main UI-focused change to responsive document result cards.
Description check ✅ Passed The description follows the template with Summary, Verification, Risk and rollout, Clinical Governance Preflight, and Notes filled in.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 32bfe47bc3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/components/clinical-dashboard/document-search-results.tsx Outdated
@BigSimmo

Copy link
Copy Markdown
Owner Author

@codex resolve actionable Codex review findings for this pull request and current head using the repository instructions. This is the pull request's single automatic repair pass: do not perform a fresh review, create new standalone findings, or request another review. Work only the existing unresolved Codex threads on the current head. Always fix P0 and P1 findings. For P2 and lower findings, fix only clear, scoped, low-risk issues; otherwise disposition them with a concise reason. After fixing or dispositioning a thread, reply in that thread with as the first line, followed by a concise summary; that marker authorizes the workflow to close that exact thread. If human input or new authorization is required, do not use the marker and leave the thread open with the blocker. Finish only after every actionable thread is fixed or dispositioned and closed, or explicitly left open for a human decision. Do not update the branch from main, address unrelated reviews, broaden scope, or create more than one scoped fix commit. Do not use external APIs, paid services, credentials, dependency changes, or broad refactors unless explicitly authorized. Add targeted tests where behavior changes and run the narrowest relevant validation.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: 32bfe47bc3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@BigSimmo BigSimmo added the skip-branch-sync Opt out of hosted pr-branch-sync / update-branch on this PR label Jul 29, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 397d8d622f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/branch-review-ledger.md
@BigSimmo
BigSimmo merged commit 4f28be7 into main Jul 29, 2026
27 checks passed
@BigSimmo
BigSimmo deleted the codex/document-results-responsive-polish branch July 29, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-branch-sync Opt out of hosted pr-branch-sync / update-branch on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants