Fix PWA search composer losing focus - #1373
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughPassive scrolling no longer blurs the global search composer. Focus release now occurs only for explicit outside gestures or PageUp/PageDown keyboard navigation, with contract, DOM, browser, and PWA coverage. ChangesComposer focus and scroll handling
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Browser
participant GlobalSearchShell
participant useDocumentScrollHideReporter
participant ComposerInput
Browser->>GlobalSearchShell: emit scroll
GlobalSearchShell->>useDocumentScrollHideReporter: report scroll metrics
Browser->>useDocumentScrollHideReporter: emit outside gesture or PageDown
useDocumentScrollHideReporter->>ComposerInput: release focus
Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a892ce1464
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex resolve actionable Codex review findings for this pull request and current head using the repository instructions. This is the pull request's single automatic repair pass: do not perform a fresh review, create new standalone findings, or request another review. Work only the existing unresolved Codex threads on the current head. Always fix P0 and P1 findings. For P2 and lower findings, fix only clear, scoped, low-risk issues; otherwise disposition them with a concise reason. After fixing or dispositioning a thread, reply in that thread with as the first line, followed by a concise summary; that marker authorizes the workflow to close that exact thread. If human input or new authorization is required, do not use the marker and leave the thread open with the blocker. Finish only after every actionable thread is fixed or dispositioned and closed, or explicitly left open for a human decision. Do not update the branch from main, address unrelated reviews, broaden scope, or create more than one scoped fix commit. Do not use external APIs, paid services, credentials, dependency changes, or broad refactors unless explicitly authorized. Add targeted tests where behavior changes and run the narrowest relevant validation. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a892ce1464
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Summary
Verification
verify:phone-chromeandverify:pr-localflight plans inspectednpm run verify:pr-locallocally — not run because other repository dev servers prevented an isolated clean install; hosted CI on the exact head is the authoritative gatenpm run verify:uilocally — not run for the same install/process-isolation reason; the changed Playwright journey is included in hosted UI checksnpm run verify:releaselocally — provider/release gate delegated to the explicitly authorized protected-main workflowRisk and rollout
Clinical Governance Preflight
Not applicable: this changes search-composer focus lifecycle only. It does not change retrieval, ranking, clinical content, source rendering, document access, privacy, or provider behavior.
RAG impact: no retrieval behaviour change — shared UI focus handling and regression tests only.
Notes
main, so its focused results are supporting evidence rather than installed-lock parity proof. Hosted CI uses the current lockfile.Summary by CodeRabbit