Skip to content

fix(ci): target enableAllProjectMcpServers via settings, add diagnostics - #1366

Merged
BigSimmo merged 2 commits into
mainfrom
fix/claude-action-settings-diagnostic
Jul 28, 2026
Merged

fix(ci): target enableAllProjectMcpServers via settings, add diagnostics#1366
BigSimmo merged 2 commits into
mainfrom
fix/claude-action-settings-diagnostic

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

Summary

  • fix(ci): disable project MCP auto-load for the Claude Code Action #1359's claude_args: --strict-mcp-config did not resolve the @claude crash — a live re-test after merge still failed in ~2s with is_error: true, total_cost_usd: 0, num_turns: 1. Zero cost means no model call was ever made, so the failure happens during setup, before Claude Code even starts working.
  • This action runs the Agent SDK's query() in-process rather than spawning the claude CLI binary, so claude_args may not translate to --strict-mcp-config (or any CLI flag) at all in this execution path.
  • This PR instead sets enableAllProjectMcpServers: false directly via the action's settings input — the actual JSON key the action's own logs show it writing ("Updated settings with enableAllProjectMcpServers: true").
  • Also temporarily enables show_full_output: true so that if this still fails, we get the real error instead of a silently swallowed one. Both diagnostics get trimmed to a minimal permanent fix once the real cause is confirmed.

Verification

  • npm run check:github-actions — pin/policy check passes.
  • Verification not run: unit suite — workflow YAML only, no application code.
  • Live verification not run in this PR (same constraint as fix(ci): disable project MCP auto-load for the Claude Code Action #1359 — GitHub loads issue_comment workflow definitions from the default branch, not the PR head). Will re-run the throwaway-PR @claude test once this merges.

Risk and rollout

  • Risk: low — additive/diagnostic action inputs only; no permissions, trigger, or pinned-SHA changes. show_full_output: true will print full agent tool-call output to (private-repo) Actions logs for this workflow only, temporarily.
  • Rollback: revert this commit.
  • Provider or production effects: None beyond the @claude Actions workflow itself.

Notes


Generated by Claude Code

#1359's claude_args: --strict-mcp-config had zero observable effect — a
live re-test still failed in ~2s with $0 cost and zero turns (no model
call ever made), so the crash isn't resolved and may not even be
MCP-related. This action runs the Agent SDK query() in-process rather
than spawning the claude CLI, so claude_args likely doesn't map to
--strict-mcp-config at all.

Sets `enableAllProjectMcpServers: false` directly via the settings
input (the JSON key the action's own logs show it writing), and
temporarily enables show_full_output to capture the real error if this
still fails. Both are diagnostic and will be trimmed once root-caused.
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 35 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 05062bc3-a29f-4348-b721-bbc61f6faa17

📥 Commits

Reviewing files that changed from the base of the PR and between 5f8c4d7 and efe69b5.

📒 Files selected for processing (1)
  • .github/workflows/claude.yml

Comment @coderabbitai help to get the list of available commands.

@supabase

supabase Bot commented Jul 28, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@BigSimmo
BigSimmo marked this pull request as ready for review July 28, 2026 13:37
@BigSimmo
BigSimmo enabled auto-merge (squash) July 28, 2026 13:38
@BigSimmo
BigSimmo merged commit deb7c6b into main Jul 28, 2026
19 checks passed
@BigSimmo
BigSimmo deleted the fix/claude-action-settings-diagnostic branch July 28, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants