-
Notifications
You must be signed in to change notification settings - Fork 0
fix: Implement audit design fixes and fallback improvements #1351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9400f52
Implement audit design fixes and fallback improvements
BigSimmo 47f69ff
chore: format files
BigSimmo aabbffe
Merge origin/main into audit-design-fixes-clean
cursoragent 0538e3f
Merge origin/main into audit-design-fixes-clean (ledger docs)
cursoragent 6999698
Merge origin/main into audit-design-fixes-clean
cursoragent dcf0844
Merge origin/main into audit-design-fixes-clean
cursoragent ed39e60
Merge origin/main into audit-design-fixes-clean
cursoragent da02ea0
ci: retrigger checks after npm ECONNRESET flake
cursoragent 412a802
fix: make audit fallbacks reachable and address review blockers
cursoragent fe22726
test: expect document 404 segment not-found UI in smoke
cursoragent a400273
fix: give segment not-found pages a single h1
cursoragent b003722
fix: render segment not-found titles as h1
cursoragent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| "use client"; | ||
|
|
||
| import Link from "next/link"; | ||
| import { FileQuestion } from "lucide-react"; | ||
| import { appModeHomeHref } from "@/lib/app-modes"; | ||
|
|
||
| export default function NotFound() { | ||
| return ( | ||
| <div className="flex h-[400px] items-center justify-center px-4"> | ||
| <div | ||
| role="status" | ||
| className="w-full max-w-md rounded-lg border border-dashed border-[color:var(--border-strong)] bg-[color:var(--surface-inset)] p-4 text-sm shadow-[var(--shadow-inset)] sm:p-5" | ||
| > | ||
| <div className="flex items-start gap-3"> | ||
| <span className="grid h-10 w-10 shrink-0 place-items-center rounded-lg bg-[color:var(--surface)] text-[color:var(--text-muted)]"> | ||
| <FileQuestion className="size-icon-md sm:size-icon-lg" aria-hidden="true" /> | ||
| </span> | ||
| <div className="min-w-0"> | ||
| <h1 className="text-base font-semibold text-[color:var(--text)]">Differential Not Found</h1> | ||
| <p className="mt-1 leading-6 text-[color:var(--text-muted)]"> | ||
| The requested differential diagnosis could not be found or has been deleted. | ||
| </p> | ||
| <div className="mt-3 flex flex-wrap gap-2"> | ||
| <Link | ||
| href={appModeHomeHref("differentials")} | ||
| className="text-sm font-medium text-blue-600 hover:underline" | ||
| > | ||
| Return to differentials | ||
| </Link> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| "use client"; | ||
|
|
||
| import Link from "next/link"; | ||
| import { FileQuestion } from "lucide-react"; | ||
| import { appModeHomeHref } from "@/lib/app-modes"; | ||
|
|
||
| export default function NotFound() { | ||
|
cursor[bot] marked this conversation as resolved.
|
||
| return ( | ||
| <div className="flex h-[400px] items-center justify-center px-4"> | ||
| <div | ||
| role="status" | ||
| className="w-full max-w-md rounded-lg border border-dashed border-[color:var(--border-strong)] bg-[color:var(--surface-inset)] p-4 text-sm shadow-[var(--shadow-inset)] sm:p-5" | ||
| > | ||
| <div className="flex items-start gap-3"> | ||
| <span className="grid h-10 w-10 shrink-0 place-items-center rounded-lg bg-[color:var(--surface)] text-[color:var(--text-muted)]"> | ||
| <FileQuestion className="size-icon-md sm:size-icon-lg" aria-hidden="true" /> | ||
| </span> | ||
| <div className="min-w-0"> | ||
| <h1 className="text-base font-semibold text-[color:var(--text)]">Document Not Found</h1> | ||
| <p className="mt-1 leading-6 text-[color:var(--text-muted)]"> | ||
| The requested document could not be found or has been deleted. | ||
| </p> | ||
| <div className="mt-3 flex flex-wrap gap-2"> | ||
| <Link href={appModeHomeHref("documents")} className="text-sm font-medium text-blue-600 hover:underline"> | ||
| Return to document library | ||
| </Link> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| "use client"; | ||
|
|
||
| import { RouteErrorBoundary } from "@/components/route-error-boundary"; | ||
|
|
||
| export default function ErrorPage({ error, reset }: { error: Error & { digest?: string }; reset: () => void }) { | ||
| return <RouteErrorBoundary error={error} reset={reset} />; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| "use client"; | ||
|
|
||
| import { RouteErrorBoundary } from "@/components/route-error-boundary"; | ||
|
|
||
| export default function ErrorPage({ error, reset }: { error: Error & { digest?: string }; reset: () => void }) { | ||
| return <RouteErrorBoundary error={error} reset={reset} />; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| "use client"; | ||
|
|
||
| import { RouteErrorBoundary } from "@/components/route-error-boundary"; | ||
|
|
||
| export default function ErrorPage({ error, reset }: { error: Error & { digest?: string }; reset: () => void }) { | ||
| return <RouteErrorBoundary error={error} reset={reset} />; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| "use client"; | ||
|
|
||
| import { RouteErrorBoundary } from "@/components/route-error-boundary"; | ||
|
|
||
| export default function ErrorPage({ error, reset }: { error: Error & { digest?: string }; reset: () => void }) { | ||
| return <RouteErrorBoundary error={error} reset={reset} />; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.