Skip to content

docs: keep PR titles/descriptions uncompressed under caveman mode - #1322

Merged
BigSimmo merged 4 commits into
mainfrom
claude/pr-policy-caveman-fix-6875bb
Jul 28, 2026
Merged

docs: keep PR titles/descriptions uncompressed under caveman mode#1322
BigSimmo merged 4 commits into
mainfrom
claude/pr-policy-caveman-fix-6875bb

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Jul 28, 2026

Copy link
Copy Markdown
Owner

Summary

  • pr-policy.yml runs scripts/pr-policy.mjs against the exact PR title/body text and hard-blocks the merge when a clinical-risk diff lacks a complete ## Clinical Governance Preflight or a RAG-ranking-surface diff lacks a satisfying RAG impact: line. Caveman-mode output-style compression can paraphrase/shorten that exact-parsed text and silently trip the gate. Added an explicit carve-out (AGENTS.md, handoff skill) so PR titles/descriptions are always written in full normal prose from .github/pull_request_template.md, regardless of active output style.

Verification

  • npm run check:pr-policy (self-test + workflow guard) — passed
  • npx prettier --check AGENTS.md .claude/skills/handoff/SKILL.md — passed
  • npm run lint — passed, 0 warnings
  • Verification not run: npm run typecheck / npm run test / npm run check:rag:fixtures — blocked >10 min by cross-worktree heavyweight-lock contention (other worktrees running full vitest/Playwright suites). Diff is docs-only (AGENTS.md + one .claude/skills file, no src//scripts//test files touched); hosted CI runs these independently.

Risk and rollout

  • Risk: low; docs-only change, no source/config/test code touched, no runtime behavior change.
  • Rollback: revert this commit.
  • Provider or production effects: None.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated contribution guidance for creating pull requests.
    • Clarified required pull request sections, governance checks, risk-and-rollout details, and RAG impact statements.
    • Added guidance to preserve the provided pull request template verbatim and validate policy requirements before merging.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: dbeaa8cb-6ebb-42f4-bdd2-9fc7008754b2

📥 Commits

Reviewing files that changed from the base of the PR and between 3a8edb9 and ebd1693.

📒 Files selected for processing (2)
  • .claude/skills/handoff/SKILL.md
  • AGENTS.md

📝 Walkthrough

Walkthrough

The PR updates handoff and agent documentation to require verbatim PR template content, required governance and RAG fields, and awareness of strict policy parsing and validation.

Changes

PR policy guidance

Layer / File(s) Summary
Verbatim PR body and policy requirements
.claude/skills/handoff/SKILL.md, AGENTS.md
Instructions now require exact PR template content, applicable governance checkboxes, a RAG impact: line, and policy validation via npm run check:pr-policy when relevant.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested labels: codex

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and matches the docs-only change about preserving full PR titles and descriptions.
Description check ✅ Passed The description covers Summary, Verification, and Risk and rollout, with clear evidence for skipped checks and no major template gaps.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 29c58693d6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread AGENTS.md
@cursor

cursor Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Closing as superseded by clean rebase: #1335

Useful content kept: AGENTS “PR titles/descriptions are parsed input” bullet + handoff step requiring full pr-policy template prose (never caveman-compressed).

Dropped/stale: tip’s hand-written ledger-row instruction — current main already requires npm run ledger:append.

@BigSimmo BigSimmo closed this Jul 28, 2026
@BigSimmo BigSimmo reopened this Jul 28, 2026
@supabase

supabase Bot commented Jul 28, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@BigSimmo BigSimmo changed the title chore: organize dirty work from claude/pr-policy-caveman-fix-6875bb docs: keep PR titles/descriptions uncompressed under caveman mode Jul 28, 2026
…man-fix-6875bb

# Conflicts:
#	.claude/skills/handoff/SKILL.md
@BigSimmo
BigSimmo enabled auto-merge (squash) July 28, 2026 09:52

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7e96cc3791

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread AGENTS.md
@BigSimmo
BigSimmo merged commit 5f8c4d7 into main Jul 28, 2026
18 of 19 checks passed
@BigSimmo
BigSimmo deleted the claude/pr-policy-caveman-fix-6875bb branch July 28, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant