chore: organize dirty work from codex/chat-mode-page-navigation-2328 - #1319
chore: organize dirty work from codex/chat-mode-page-navigation-2328#1319BigSimmo wants to merge 1 commit into
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 18 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (43)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: db7fee69d1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <PageSecondaryNavigation | ||
| modeId={searchMode} | ||
| pathname="/" | ||
| hasSubmittedSearch={Boolean(modeSearchSubmitted || answer || latestAnswerQuery)} |
There was a problem hiding this comment.
After an answer has been generated or restored, switching through the mode menu to a clean non-answer landing page leaves answer and latestAnswerQuery populated, so this expression passes true despite selectSearchMode resetting modeSearchSubmitted. As a result, clean Documents, Services, Forms, and other mode homes incorrectly gain the pinned secondary Search row, contrary to isModeSecondaryNavigationRoute's clean-landing behavior. Limit the answer state terms to answer mode; a regression test should generate an answer, switch to another mode, and assert that the secondary navigation is absent.
Useful? React with 👍 / 👎.
| const sections = items | ||
| .map((item) => ({ item, element: document.getElementById(item.targetId) })) |
There was a problem hiding this comment.
When client-side navigation replaces one detail record with another in the same route family, the item IDs usually remain unchanged, so this effect does not rerun and sections continues referencing detached elements from the previous page. Subsequent scrolling evaluates those detached nodes (typically all at top 0) and can mark the final section current regardless of the visible content; the listeners may also remain attached to the old scroll owner. Re-resolve targets when the pathname/content changes or observe replacement mutations; a focused test should navigate between two service or therapy records and verify the active section while scrolling the second record.
Useful? React with 👍 / 👎.
|
Closing as superseded by a surgical port onto current Kept: shared mode secondary navigation registry + components + unit/DOM tests, wired into Deliberately not taken from this tip: DocumentViewer anchor deletion, tip |
1 participant
Organized dirty work from codex/chat-mode-page-navigation-2328
RAG impact: no retrieval behaviour change — branch cleanup and organisation only.