Search results band: truthful failure state, approved design, and adoption gate

docs/branch-review-ledger.md

@@ -1183,10 +1183,16 @@ Records before 2026-07-28 were written by hand and had drifted: 146 lines carrie
 | 2026-07-28 | PR #1304 / `fix-test-run-lock` | `2abe39506f9f0ceaf8cf638bfa2b6dc37dc0ed2c` | CI babysit: resync main | FIXED. After green PR required on `f7d86c27`, main advanced by 1 commit (#1305); GitHub DIRTY again but `git merge-tree` CLEAN. Merged origin/main. No product conflicts; unique delta still knip.json (+ ledger). | merge-tree CLEAN; hosted PR required SUCCESS on prior tip; no provider-backed checks. |
 | 2026-07-28 | PR #1304 / `fix-test-run-lock` | `463e5c0adc77fe722e20376666f5991db3e288d9` | CI babysit closeout | MERGE-READY. Hosted PR required SUCCESS on exact tip; mergeable=MERGEABLE; 0 behind main; merge-tree CLEAN. Unique product delta: knip.json removes unused tailwindcss ignoreDependencies. Prior GitHub DIRTY labels during babysit were main-churn only. | Hosted CI run success on 463e5c0a; no provider-backed checks. |
 | 2026-07-28 | PR #1304 / fix-test-run-lock | 7cc32c053c752bef19f3de408a1376428e54af74 | CI babysit: sync main | SUPERSEDED (documenting stale-CI ledger error). Prior row for this HEAD incorrectly treated hosted required-CI SUCCESS on earlier tip e6b826ed9150f312c2e7a957f715019e73a7f0be as verification of this later merge commit 7cc32c05. No hosted required-CI result exists for this exact SHA. This ref has since advanced; the later row at 463e5c0adc77fe722e20376666f5991db3e288d9 recorded exact-tip hosted CI SUCCESS, so this commit's status is historical/superseded. | No hosted CI run on this exact HEAD; prior row reused results from e6b826ed; corrective ledger entry only. |
+| 2026-07-28 | PR #1316 / `claude/top-search-design-mockups-w53znc` | `8ccd7f481819ae4b41352acf9d867b2b850696be` | CI/review closeout: remaining band review gaps | FIXED. Prior Production UI failure on older tip was Suspense duplicate `global-search-input` (addressed earlier). Tip closes 7 unresolved review threads: favourites partial-status + refetch, differentials unauthorized copy, docs typography, forced-colors adoption gate, forms/loading control suppression confirmation. Merge-tree clean vs main; hosted CI rerunning on this head. | Focused vitest 38/38; tsc + eslint on touched files PASS; no Bugbot MCP available in this environment; no provider-backed checks. |
+| 2026-07-28 | claude/top-search-design-mockups-w53znc | af07e34b5e6ca958206926a05509c1e321dbe862 | bugbot SearchResultsHeaderBand favourites status | P1: favourites status override under-reports registry faults when any items exist; empty/filter guards use overridden status; registryStatus unused. P2: demo prototype merge still over-faults band. No code change. | static review of band/favourites/diff call sites; offline fold proof; PR thread context; no provider/CI |
+| 2026-07-28 | PR #1316 / `claude/top-search-design-mockups-w53znc` | `1c65a083e8307f108774b0c3a3fb96559c42ee0d` | CI/review closeout complete | READY FOR HOSTED CI. All review threads resolved. Account-favourites pending/failure folded into band status; remaining Codex/CodeRabbit gaps closed; Bugbot residual noted (binary band cannot express partial source failure without a dedicated `partial` status). Merge-tree was clean vs main at prior tip; CI rerunning on this head. | Focused vitest 43/43; tsc/eslint PASS on touched files; Bugbot via pr-bugbot subagent (no MCP Bugbot server); no provider-backed checks. |
 | 2026-07-28 | PR-1296 | 58a6fe241de122c81822a5f60064cc2c49b2f245 | PR #1296 full diff vs origin/main | FIXED P1 z-index ladder bypass; approve after exact-head CI | Removed semantic z-index utilities that lowered established overlay rungs and bypassed main lint; diff check pending; prior exact-head PR required and Production UI passed; refreshed exact-head CI pending |
 | 2026-07-28 | PR #1337 / claude/circleci-config-decision-f1efc6 | eb2f8f867de13ca64fbdb5e95242e7e5067be6dc | CI babysit: CircleCI verify + Codex P2s | FIXED. Root causes: (1) CircleCI missing PyMuPDF/pip so CI=1 pdf-extractor prerequisite failed; (2) naive docs-only md regex false-greened policy Markdown; (3) Bugbot P1: non-root npm install -g fails on cimg/node. Fixed by ci-change-scope docs_only halt, apt python3-pip + PyMuPDF==1.28.0, npm 11.x assert. Both Codex threads resolved. brace-expansion already on main via #1314. | format:check; contract Vitest 5/5; pdf-extractor 6/6 with CI=1+PyMuPDF; typecheck; lint; Bugbot re-review no remaining bugs; hosted CI/CircleCI re-running on eb2f8f86 |
 | 2026-07-28 | PR #1337 / claude/circleci-config-decision-f1efc6 | e9bcebb9ef7baddb2eed961bf40bbd89a358b41b | CI babysit: CircleCI verify green | FIXED. Root cause of CircleCI red: cimg/node:24.9 fails engine-strict npm ci because @babel/parser requires Node >=24.11. Switched to cimg/node:24.18. Also addressed Codex P2s (ci-change-scope docs-only; PyMuPDF venv+PYTHON_BIN). Hosted ci/circleci: verify SUCCESS on tip; GH PR required SUCCESS. Codex threads previously resolved. | circleci config validate; contract Vitest 6/6; hosted CircleCI verify SUCCESS (job 225); hosted PR required/Static/Unit SUCCESS |
 | 2026-07-28 | cursor/mode-secondary-navigation-dc4e | ea9f74062269cc820af5fdc9d3d1ce09e5cf0a4a | pr-1336-babysit | fixed P1 Suspense+DocumentViewer double-nav; P2 documents/search gate; CI babysit | verify:cheap,vitest-70+4189,tsc,eslint,build |
 | 2026-07-28 | cursor/mode-secondary-navigation-dc4e | e33997dbdd4a62689ff17ff1f536d9e830ae22ad | pr-1336-babysit | fixed Codex P1 horizontal scroll + P2 service section ids; merged main | vitest-62,eslint,tsc |
+| 2026-07-28 | claude/top-search-design-mockups-w53znc | 9731a9e35fdd036e039f88cbe1f8ccb0f99e9fdc | PR #1316 tip WIP: #024 status + favourites count suppress + therapy retry settle | no high-confidence P0/P1; residual #091 partial-count trust + search-band onRetry dead behind workspace error gate | vitest favourites-hub-unavailable-controls + therapy-compass-data-recovery (7 passed); static review of uncommitted diffs |
+| 2026-07-28 | PR #1316 / `claude/top-search-design-mockups-w53znc` | `9bace1d1b359df5c9a87c40be1e374a89976fd2a` | CI/review closeout: #024 prose, favourites counts, therapy retry settle | FIXED open threads. CodeRabbit #024 contradiction corrected in prose (item stays open). Codex favourites counts suppressed until trusted. Codex therapy retry returns settling Promise + busy coverage. Merged latest main (clean). Bugbot: no P0/P1. Residual #091 partial-count trust; search-band onRetry still behind workspace error gate (workspace Retry uses loading). | full vitest 4229 passed / 4 skipped; typecheck; eslint touched; check:branch-review-ledger; Bugbot via pr-bugbot |
+| 2026-07-28 | PR #1316 / `claude/top-search-design-mockups-w53znc` | `7b968d695c4545e1677c2e7f136172ef686d0012` | CI/review closeout: loadError split + adoption mode homes | FIXED new Codex P2s. Separated account loadError from mutation error; expanded band adoption to mode href pages + 2-hop reach; prior #024/favourites-counts/therapy-retry threads already resolved. Merge-tree clean vs main (0 behind). Bugbot earlier pass had no P0/P1 on prior WIP. | vitest favourites-account-retry + adoption + hub (10); typecheck; full suite 4232/4 prior tip |
 | 2026-07-28 | PR #1296 / `css-layout-audit-complete` | `84d846d8d0d168ca2babcc6d699e0a88bb0379c0` | Inspect closeout: sync main + forced-colors scope | FIXED. GitHub CONFLICTING was unpushed main sync (local merge-tree CLEAN, 3 behind on remote tip). Pushed merge. Bugbot P2: removed broad forced-colors `!important` wipe on `.edge-glass-header`/`[aria-selected=true]`/`.surface-raised` (token remap retained; header Canvas fill already earlier). Mockup board `z-[2147483647]` → ladder `z-[100]`. Prior CodeRabbit/Codex threads remain resolved. | lint/typecheck/format:check PASS; vitest 4197; local build PASS; no provider checks. |
 | 2026-07-28 | PR #1296 / `css-layout-audit-complete` | `f7c34fd7` | Sync main #1297 CSS/motion audit | FIXED. GitHub CONFLICTING after main landed #1297; `git merge origin/main` clean (globals.css + ledger auto-merge). Retained content-auto, scoped forced-colors token remap, mockup z-[100]. Prior tip hosted PR required SUCCESS. | merge-tree CLEAN; focused nav test PASS; no provider checks. |