Skip to content

test(ui): stabilize hydrated browser interactions - #1282

Merged
BigSimmo merged 3 commits into
mainfrom
codex/settings-followup
Jul 27, 2026
Merged

test(ui): stabilize hydrated browser interactions#1282
BigSimmo merged 3 commits into
mainfrom
codex/settings-followup

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Jul 27, 2026

Copy link
Copy Markdown
Owner

Summary

  • Stabilize Playwright answer and search interactions by waiting for one hydrated React owner before fill or submit.
  • Make universal-search mocks echo the requested query so streamed groups are not rejected as stale.
  • Retry differential scroll-to-end geometry after late dock reserve layout.
  • Record the protected-main review in the append-only ledger.

Verification

  • npm run verify:pr-local — PASS: runtime, formatting, lint, typecheck, 393 files, 3,538 passed / 2 skipped, and 36 offline RAG fixtures.
  • npm run verify:ui — PASS: 323/323 production Chromium journeys.
  • Focused integrated production Chromium — PASS: 5/5 corrected journeys.
  • npm run verify:release — not run; this test-only change was covered by the exact integrated Chromium and PR-local gates, and no non-GitHub provider-backed release checks were authorized.
  • Live retrieval/answer evaluations — not run because retrieval, ranking, generation, and clinical output behavior are unchanged.

RAG impact: no retrieval behaviour change — test-only hydration, mock-query, and scroll synchronization updates.

Risk and rollout

  • Risk: Low. Test-only synchronization changes could make a persistent duplicate owner fail more explicitly; they do not alter production runtime code.
  • Rollback: Revert the squash commit.
  • Provider or production effects: GitHub PR and protected-main merge only; no Supabase, OpenAI, Railway, or production-data interaction.

Clinical Governance Preflight

Not applicable: no ingestion, retrieval/ranking, source rendering, document access, privacy, environment, or clinical output behavior changed.

Notes

  • Release review: APPROVE with no P0-P3 findings.
  • Highest residual risk is physical iOS/WebKit behavior outside local Chromium coverage.

Summary by CodeRabbit

  • Tests
    • Improved UI test reliability by waiting for interactive controls to finish loading before use.
    • Strengthened checks for answer submission, universal search, mobile scrolling, and long-content workflows.
    • Updated search test scenarios to reflect entered queries and search modes.
    • Added retry handling for delayed layout and scrolling behavior.

@supabase

supabase Bot commented Jul 27, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 8b45ffc5-7643-473a-aff3-ca5352e5e583

📥 Commits

Reviewing files that changed from the base of the PR and between b2b5268 and 1816500.

📒 Files selected for processing (6)
  • docs/branch-review-ledger.md
  • tests/answer-progress-ui-smoke.spec.ts
  • tests/ui-smoke.spec.ts
  • tests/ui-stress.spec.ts
  • tests/ui-tools.spec.ts
  • tests/ui-universal-search.spec.ts

📝 Walkthrough

Walkthrough

Playwright UI tests now wait for React event handlers and settled control state before interaction, use request-specific universal-search mock data, and retry scroll geometry checks. A branch review ledger entry records the associated verification results.

Changes

UI test hardening

Layer / File(s) Summary
Answer composer hydration readiness
tests/answer-progress-ui-smoke.spec.ts, tests/ui-smoke.spec.ts, tests/ui-stress.spec.ts
Answer-generation tests wait for React handlers and enabled controls before filling or submitting questions.
Universal-search request and composer readiness
tests/ui-universal-search.spec.ts
The mock derives query parameters from requests, while composer setup validates a unique visible input and waits for React hydration.
Differential dock interaction and scroll verification
tests/ui-tools.spec.ts, docs/branch-review-ledger.md
Differential search validates hydrated controls, scroll-end geometry is retried as one action, and the ledger records verification results.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested reviewers: claude, cursoragent

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the PR’s main focus on stabilizing hydrated browser interactions.
Description check ✅ Passed The description matches the template well, with summary, verification, risk, governance, and notes all filled in.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/settings-followup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@BigSimmo
BigSimmo merged commit 49266cd into main Jul 27, 2026
19 checks passed
@BigSimmo
BigSimmo deleted the codex/settings-followup branch July 27, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant