Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions docs/branch-review-ledger.md
Original file line number Diff line number Diff line change
Expand Up @@ -1091,3 +1091,13 @@ This file is append-only. Never rewrite or delete an existing review record; app
| 2026-07-26 | PR #1259 / `codex/phone-header-hidden-edge` | `cceea70588d50d3f119394e93e50f7b38ed6f920` | Superseding P2 implementation review after parallel branch merge | APPROVE pending exact-head required CI. Merged the concurrently advanced PR branch without force or rebase. Both sides fixed the same portal-focus defect; the resolved tree retains the native listener on the actual addon DOM host and removes the document-global custom event, which could clear the universal header focus pin during unrelated desktop mutations. Retained the stronger static and browser assertions from the remote branch. No unresolved code conflict or product finding remains. | Merge conflicts limited to the duplicate focus implementations and duplicate UI test; TypeScript PASS; header-scroll contracts 15/15; focused production Chromium regression 1/1. Earlier exact local tree: `verify:cheap` PASS and phone-scroll 39/39. No provider-backed checks. |
| 2026-07-26 | PR #1259 / `codex/phone-header-hidden-edge` | `d7f1ac58d00d20a2405eb1641054d31c3a5b996e` | Final focus lifecycle remediation review | APPROVE pending exact-head required CI. Addressed the final CodeRabbit and Codex P2 lifecycle findings: the addon host is now tracked as state so listeners follow conditional host creation/replacement, focus is recomputed on attach, a scoped MutationObserver clears the pin when focused portal content unmounts without focusout, and cleanup clears the latch. The phone regression now activates the focused Back link with Enter and proves the destination header can hide again. No unresolved code finding remains locally. | Focused production Chromium focus-and-navigation regression 1/1; complete phone-scroll suite 39/39; header-scroll contracts 15/15; TypeScript PASS; `verify:cheap` PASS (393 files; 3514 passed / 2 skipped). No provider-backed checks. |
| 2026-07-26 | PR #1259 / `codex/phone-header-hidden-edge` | `482d6f2489c9ca1ee4603f0013bd9b3190a2cc36` | Superseding lifecycle resolution after concurrent branch merge | APPROVE pending exact-head required CI. Merged the concurrently advanced lifecycle fix without force or rebase. The resolved tree uses a stable callback ref, explicit collapse-strategy ownership, active-element synchronization on attach, scoped subtree observation, and cleanup clearing. Kept separate browser cases for focus pinning and keyboard-navigation teardown so each contract fails independently. No unresolved code conflict or local finding remains. | Header-scroll contracts 15/15; TypeScript PASS; focused production Chromium lifecycle cases 2/2. Immediately preceding equivalent lifecycle tree: phone-scroll 39/39 and `verify:cheap` PASS; final exact-head cheap gate follows this record. No provider-backed checks. |

| 2026-07-26 | PR #1255 / `execute-audit-remediation-plan` | `cc645928cefb18e4c08870ddc1c483bc051a92b9` | open-PR babysit sweep: close without merge | CLOSED (not merged). Unsafe #1188 lineage: ~507 behind, merge-tree dirty, literal `>>>>>>> theirs` in `evidence-panels.tsx`, dangling `renderSystemNotice`. Intentional maintainability already on main via #1213. | Marker/dangling-call grep on tip; merge-tree conflict inventory; no provider-backed checks. |
| 2026-07-26 | PR #1253 / `remediate-system-audit-findings` | `cc1fa9d48434c809e2cf73dfeb3124d2b36f0968` | open-PR babysit sweep: close without merge | CLOSED (not merged). ~507 behind with real merge-tree conflicts across answer API/evidence/tests/docs; PR policy missing governance/RAG impact. Salvageable ideas need clean rebuild on main, not this tip. | merge-tree conflict inventory; no provider-backed checks. |
| 2026-07-26 | PR #1257 / `cursor/therapy-search-trim-e63e` | head `b80a3810819846760e862e1d0d4aa746ae6b0237` / squash `024ebffdf753b8487af4615768d19d882b27d2b7` | prlanded after squash merge | LANDED. Therapy search intro/local query field removed; Codex sidebar assertion thread resolved on tip. Remote branch deleted by merge. | Hosted Production UI + PR required SUCCESS; merge-tree clean; no provider-backed checks. |
| 2026-07-26 | PR #1212 / `cursor/pr1196-coalesce-main-4711` | head `b88d69bb1dc1aa6c6ca8f34f3df3641801b60bd0` / squash `a9920e3fc29fce9ad2ffb547811e085a708680b9` | prlanded after squash merge | LANDED. Search/embedding coalesce poison + fractional PDF pixel budget on main. GitHub CONFLICTING was stale drift; merge-tree clean before sync. Remote branch deleted by merge. | Hosted PR required/Production UI/Unit/Build/Static SUCCESS on tip; no provider-backed checks. |
| 2026-07-26 | PR #1241 / `cursor/imp04-prune-dead-exports-01f2` | head `7f9c56c148fbd743ea3b48fe86c67461c42fc0f4` / squash `5d6f06156f0370427361343f249bf1d7f180e874` | prlanded after squash merge | LANDED. IMP-04 dead mockup/primitive export prune intact on main. CodeRabbit ledger thread dispositioned. Remote branch deleted by merge. | Hosted PR required/Production UI/Static/Unit/Build SUCCESS; `git diff` tip vs main empty; no provider-backed checks. |
| 2026-07-26 | PR #1248 / `cursor/fix-mode-switch-lag-22f6` | head `83419c98fea9385df9beb10a9062d2dc7289f0f0` / squash `dbcd4cea605ee7f5af8f2f9b5ff22d18385131ea` | prlanded after squash merge | LANDED. Mode-switch lag/portal keep-alive; Documents cross-mode ownership fixed; submitted-param hard-load P2 seeded for `run=1`+query only. Codex thread resolved then squash-merged. Remote branch deleted by merge. | Hosted PR required/Production UI/Static/Unit/Build SUCCESS; verify:cheap PASS pre-merge; no provider-backed checks. |
| 2026-07-26 | PR #1254 / `apply-audit-remediation-fixes` | head `b5aa92f0febbd0425c5f3d809356946a7d2371f5` / squash `4d54abfa4d467b16e5e2f0fe3f16b8b3b52bc967` | prlanded after squash merge | LANDED. Provenance/governance UI tokens, citation telemetry, threshold inclusivity (`lt`/`lte`/`gt`/`gte`), locality audit kept out of offline pr-local. Supersedes earlier DO NOT MERGE babysit rows after thread resolve + green CI. Remote branch deleted by merge. | Hosted PR policy/PR required/Static/Unit/Build/Production UI/Migration SUCCESS; Codex P1 thread resolved; no provider-backed evals. |
| 2026-07-26 | PR #1259 / `codex/phone-header-hidden-edge` | head `0025d17a2c8c727d4e6cf44ae368f6448a84eeba` / squash `ecf54db378c8081b36c8fd62eaadbd716a1750c8` | prlanded after squash merge | LANDED. Edge-to-edge phone header collapse + shared hide/reveal + portaled addon focus lifecycle. Supersedes earlier blocked babysit rows. Remote branch deleted by merge. | Hosted PR required/Production UI/Unit/Build/Static SUCCESS; focused phone-scroll/header contracts PASS; no provider-backed checks. |
| 2026-07-26 | open-PR babysit sweep (Cursor) | `origin/main` @ `ecf54db378c8081b36c8fd62eaadbd716a1750c8` | triage + close + sequential land | Queue cleared. Closed #1255/#1253 as unsafe/superseded. Squash-merged useful #1257, #1212, #1241, #1248, #1254, and late-arriving #1259 after CI green + thread triage. Open PR count 0 at closeout. | Per-PR hosted required CI green at merge; merge-tree used to classify GitHub CONFLICTING as staleness vs real conflicts; no provider-backed checks. |
Loading