Pull request overview
Copilot reviewed 36 out of 37 changed files in this pull request and generated no new comments.
Suppressed comments (3)
src/components/clinical-dashboard/use-signed-image-url.ts:113
- The stale-response guard runs after the 401 side effect. If user A's request returns 401 after an account switch or token refresh, this inactive callback still calls
markSessionExpired() and expires user B's valid session. Check active before processing the status; the new account-switch test should also cover a late 401.
.then(({ status, data }) => {
if (status === 401) markSessionExpired();
if (!active) return;
src/components/document-viewer/pdf-canvas-viewer.tsx:403
- Enabling pinch in fit mode exposes a discontinuity: the handler multiplies
zoomRef (initially 1.1), while a 320px phone fits an A4 page at the 0.55 minimum. The first ~1% pinch therefore jumps the page from about 55% to 111% instead of zooming continuously. Seed the manual zoom from the current computed fit scale before applying the first pinch factor.
src/components/document-viewer/canvas-raster-budget.ts:69
- The hard
0.1 floor can violate the very ceiling this helper promises: whenever cssArea > maxCanvasPixels / 0.1², the returned backing-store area exceeds MAX_CANVAS_PIXELS and WebKit can still blank large poster/custom-UserUnit PDFs. Let the pixel budget win over the density floor and add a case where the affordable scale is below 0.1.
const outputScale = Math.max(MIN_OUTPUT_SCALE, Math.min(preferred, affordable));
Originally posted by @Copilot in #1741 (review)
Pull request overview
Copilot reviewed 36 out of 37 changed files in this pull request and generated no new comments.
Suppressed comments (3)
src/components/clinical-dashboard/use-signed-image-url.ts:113
markSessionExpired()and expires user B's valid session. Checkactivebefore processing the status; the new account-switch test should also cover a late 401.src/components/document-viewer/pdf-canvas-viewer.tsx:403
zoomRef(initially 1.1), while a 320px phone fits an A4 page at the 0.55 minimum. The first ~1% pinch therefore jumps the page from about 55% to 111% instead of zooming continuously. Seed the manual zoom from the current computed fit scale before applying the first pinch factor.src/components/document-viewer/canvas-raster-budget.ts:69
0.1floor can violate the very ceiling this helper promises: whenevercssArea > maxCanvasPixels / 0.1², the returned backing-store area exceedsMAX_CANVAS_PIXELSand WebKit can still blank large poster/custom-UserUnit PDFs. Let the pixel budget win over the density floor and add a case where the affordable scale is below 0.1.Originally posted by @Copilot in #1741 (review)