Revert "fix(ui): save routing groups as list"

[Sameerlite]

Reverts #29889

Please add proof of this working and also test

[greptile-apps]

Greptile Summary

This PR reverts #29889, which had fixed routing_groups being serialized as a JSON string instead of a proper list when saving router settings. The revert re-introduces that bug and simultaneously removes the test that was specifically written to catch it.

• index.tsx: routing_groups is dropped from jsonKeys, so the parseInputValue helper returns the raw text-box string (e.g. \"[]\") instead of a parsed array — the backend will receive a string where it expects a list.
• index.test.tsx: The assertion that routing_groups is submitted as an array (and explicitly not as a string) is deleted, along with the routing_groups fixture in the mock response, removing all CI coverage for this field.

Confidence Score: 2/5

Not safe to merge — re-introduces a known data-type mismatch for routing_groups and removes the only test guarding against it.

The one-line change in index.tsx causes routing_groups to be forwarded to the backend as a plain string instead of a parsed JSON array on every save. The PR description itself acknowledges proof is missing, and both the functional regression and the deletion of its regression test are present in this diff.

Both changed files need attention: index.tsx reintroduces the type mismatch, and index.test.tsx removes the guard that would have caught it in CI.

Important Files Changed

Filename	Overview
ui/litellm-dashboard/src/components/router_settings/index.tsx	Removes routing_groups from the jsonKeys set, causing routing-group values to be submitted to the backend as raw strings instead of parsed JSON arrays — re-introducing the bug fixed by PR #29889.
ui/litellm-dashboard/src/components/router_settings/index.test.tsx	Deletes the test that verified routing_groups is sent as a list (not a string) and removes the routing_groups field from the mock response fixture, eliminating the only regression guard for this field.

Comments Outside Diff (1)

1. ui/litellm-dashboard/src/components/router_settings/index.test.tsx, line 134-159 (link)

   Test that guards against routing_groups string regression is deleted

   The removed test explicitly asserted that routing_groups is submitted as an array ([]) and explicitly asserted it is NOT submitted as the string "[]". Deleting it means the reintroduced bug will pass CI undetected. The mock fixture removal also strips the only example of routing_groups from the response shape, so no other test exercises this field. If this revert is intentional, a replacement test documenting the new expected behavior must be added.

   Rule Used: # Code Review Rule: Mock Test Integrity

   What:... (source)

_{Reviews (1): Last reviewed commit: "Revert "fix(ui): save routing groups as ..." | Re-trigger Greptile}

[greptile-apps]

routing_groups re-introduced as a raw string instead of a list

By removing routing_groups from jsonKeys, the parseInputValue helper will now fall through to return v (the raw trimmed string), so whatever the user typed in the text box — e.g. "[]" or "[\"group1\"]" — is forwarded to the backend as a plain string. The backend expects a JSON list, not a string, so any configured routing groups will be silently ignored or cause a parse error server-side. This is exactly the regression that PR #29889 was written to fix.

Rule Used: What: Flag any modifications to existing tests and... (source)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!