Allow building xsd-parser-types with xml but without quick-xml#280
Open
RoastVeg wants to merge 1 commit into
Open
Allow building xsd-parser-types with xml but without quick-xml#280RoastVeg wants to merge 1 commit into
RoastVeg wants to merge 1 commit into
Conversation
Bergmann89
requested changes
Jul 2, 2026
Bergmann89
left a comment
Bergmann89
left a comment
Owner
There was a problem hiding this comment.
Hey @RoastVeg, thanks for your contribution. Looks good to me, just a few formatting remarks. I also started the CI pipeline please check if it passes, then we can merge this.
| events::attributes::Attribute, | ||
| name::QName, | ||
| }; | ||
| #[cfg(not(feature = "quick-xml"))] |
Owner
There was a problem hiding this comment.
Please move this after the using directives block (right before Attribute).
| #[cfg(feature = "quick-xml")] | ||
| use quick_xml::events::Event; | ||
|
|
||
| #[cfg(feature = "quick-xml")] |
Owner
There was a problem hiding this comment.
Can you please move all conditional using directives to it's own block? Like:
use std::std::FromStr;
use other_crate::SomeType;
#[cfg(feature = "quick-xml")]
use quick_xml::events::Event;
#[cfg(feature = "quick-xml")]
use crate::quick_xml::{DeserializeBytes, SerializeBytes};
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.