Modernisation cleanup: pom.xml, plugin.yml api-version, IslandLevelListener test#161
Merged
Merged
Conversation
Matches the Paper 1.21.11 runtime already declared in pom.xml. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Drop unused powermock.version and spigot.version properties - Drop the Spigot Nexus repository (Paper is the only API in use) - Add codemc maven-public and codemc snapshots repos; keep the bentoboxworld repo for BentoBox releases - Bump maven-compiler-plugin 3.7.0 -> 3.15.0 with fork=true for Java 21 toolchain compatibility Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Covers the happy path: IslandLevelCalculatedEvent triggers BiomesAddonManager.checkBiomesUnlockStatus with the event's island, target player (as User), and level. Brings every event listener in the addon to minimum test coverage. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plugin.yml: bumpapi-versionfrom1.19to1.21to match the Paper 1.21.11 runtime already declared inpom.xml.pom.xml: drop unusedpowermock.version/spigot.versionproperties and the Spigot Nexus repository; add the codemc maven-public + snapshots repos alongside the existing bentoboxworld repo; bumpmaven-compiler-plugin3.7.0 → 3.15.0 withfork=truefor Java 21 toolchain compatibility.IslandLevelListenerTestso every event listener in the addon now has a test.Test plan
mvn test— 82 tests, 0 failures (81 existing + 1 new)🤖 Generated with Claude Code