Skip to content

Make biome unlock notifications gamemode-aware (#112)#160

Merged
tastybento merged 3 commits into
developfrom
issue-112-gamemode-aware-unlock-notifications
Apr 16, 2026
Merged

Make biome unlock notifications gamemode-aware (#112)#160
tastybento merged 3 commits into
developfrom
issue-112-gamemode-aware-unlock-notifications

Conversation

@tastybento
Copy link
Copy Markdown
Member

@tastybento tastybento commented Apr 16, 2026

Summary

  • When a biome unlocks, only send the clickable "use it now" prompt if the player is currently in that island's gamemode world.
  • Players in other worlds (e.g. /wilderness, a different gamemode) receive a plain message naming the gamemode instead, so they know where the unlock applies and aren't misled into running a command in the wrong world.
  • Adds two new locale keys (click-text-to-purchase-other-world, click-text-to-set-other-world) in en-US.yml.

Closes #112

Test plan

  • Multi-gamemode dev server (e.g. BSkyBlock + AcidIsland + a non-addon world).
  • Trigger an unlock while standing on the correct island → clickable message as before; click runs the gamemode command.
  • Trigger an unlock while the recipient is in a different gamemode or /wilderness → non-clickable message naming the gamemode.
  • Rejoin the server outside the gamemode world → JoinLeaveListener path produces the gamemode-named variant.
  • Offline members still receive nothing.

🤖 Generated with Claude Code

tastybento and others added 3 commits April 15, 2026 17:02
Players in unrelated worlds (e.g. /wilderness) no longer receive the
clickable "use it now" prompt for biomes unlocked on a different
gamemode's island. When the recipient's current world doesn't match the
island's gamemode, send a non-clickable message that names the gamemode
so the player knows where the unlock applies.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Simpler than the prior two-variant message: if the recipient isn't in
the island's gamemode world, send nothing. Removes the now-unused
click-text-to-*-other-world locale keys.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@tastybento tastybento merged commit d6024df into develop Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unlocking biome notification can be more specific

1 participant