Defer on-join player resets until after team-accept teleport

[tastybento]

Summary

• Move cleanPlayer / cleanJoiningPlayer from before homeTeleportAsync to inside the .thenRun(...) callback in IslandTeamInviteAcceptCommand.acceptTeamInvite, so the inventory / XP / health / hunger / money resets configured by island.reset.on-join.* (and on-leave) run after the player has been teleported to the island world, not before.
• Adds a regression test that uses an uncompleted CompletableFuture to assert no resets fire until the teleport completes.

The bug

Reported via InvSwitcher: a player standing in a non-BentoBox world with items, who accepts an invite into an AOneBlock or Boxed team island, returns to find their non-BentoBox-world inventory empty. The pattern only shows up in those two game modes because they're the ones that ship (Boxed 3.3.0) or commonly default (AOneBlock, via the Java field default true) with island.reset.on-join.inventory: true. BSkyBlock / AcidIsland / CaveBlock / Poseidon / StrangerRealms ship with false and don't trigger it.

Root cause

1. Player stands in non-BB world world with real items.
2. /island team accept calls cleanJoiningPlayer(user) synchronously — player.getInventory().clear() runs while the player is still in the non-BB world.
3. homeTeleportAsync then teleports them to the island. The teleport eventually fires PlayerChangedWorldEvent.
4. InvSwitcher's PlayerListener.onWorldEnter sees from = world, calls storeInventory(player, world), and persists the now-empty inventory under that world's storage key.
5. When the player later returns to a non-BB world, InvSwitcher loads the empty inventory it just saved. Their items are gone.

Fix

Defer the player-data resets until the teleport completes. This way PlayerChangedWorldEvent fires (and InvSwitcher saves the still-intact non-BB inventory) before any clear() happens; the resets then run in the island world, which is the semantically correct place for on-join resets. The getIslands().removePlayer(...) call is logical island-state housekeeping and stays before the teleport; deleteIsland(...) was already inside thenRun and is now grouped with cleanPlayer there for consistency.

Test plan

• ./gradlew test --tests 'IslandTeamInviteAcceptCommandTest' — green, including the three pre-existing XP-reset tests that still verify resets occur (the mocked CompletableFuture.completedFuture(true) causes thenRun to fire synchronously).
• ./gradlew test — full suite green.
• New testAcceptTeamInvite_inventoryClearWaitsForTeleport uses an uncompleted future to assert inv.clear() / setLevel(0) / setExp(0F) / setTotalExperience(0) are not called before the teleport completes, then completes the future and asserts they are called after.
• Manual reproduction with InvSwitcher 1.17.1, AOneBlock 1.25.0, Boxed 3.3.0 (both with on-join.inventory: true): player joins a team while standing in world, returns to world after, items should remain.

🤖 Generated with Claude Code

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud