Append §r reset after prefix substitution to prevent formatting leakage#2907
Merged
Conversation
When prefixes with bold/italic decorations (e.g. <gold><bold>[BentoBox]: </bold></gold>) are converted to legacy § codes, the result has no reset code at the end. When substituted into message strings, the bold formatting leaks into subsequent text. Fix: Append §r reset after prefix translations in replacePrefixes() to prevent formatting leakage into surrounding message text. Agent-Logs-Url: https://github.com/BentoBoxWorld/BentoBox/sessions/624d7e6b-da75-4336-aae6-8b078f0d5ec6 Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
Agent-Logs-Url: https://github.com/BentoBoxWorld/BentoBox/sessions/624d7e6b-da75-4336-aae6-8b078f0d5ec6 Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix bold formatting issue in localization
Append §r reset after prefix substitution to prevent formatting leakage
Apr 5, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefix translations like
<gold><bold>[BentoBox]: </bold></gold>are converted to legacy§6§l[BentoBox]:with no trailing reset. When substituted into message strings, bold/italic decorations bleed into subsequent text because legacy formatting codes are sticky.Changes
User.replacePrefixes(): Append§rafter prefix translations that contain legacy formatting codes, so decorations are self-containedUserTest: AddtestPrefixBoldDoesNotLeakcovering the prefix substitution pathBefore/After