Fix ItemStack quantity > 99 crash during serialization#2895
Merged
Conversation
Mojang's ItemStack codec enforces a [1, 99] range on item count (ExtraCodecs.intRange(1, 99)). When addons provide items with quantities exceeding this limit (e.g., RED_MUSHROOM:100), serialization throws IllegalStateException. Clamp quantities at both parse time (ItemParser) and serialization time (ItemStackTypeAdapter) with a warning log, so the operation succeeds gracefully instead of crashing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ItemStackcodec enforces a[1, 99]range on item count (ExtraCodecs.intRange(1, 99)inItemStack.MAP_CODEC). When addons provide items with quantities exceeding this limit (e.g.,RED_MUSHROOM:100in a Biomes template),CraftMagicNumbers.serializeStack()throwsIllegalStateException: Value must be within range [1;99]: 100[1, 99]at both parse time (ItemParser) and serialization time (ItemStackTypeAdapter) with a warning log, so the operation succeeds gracefully instead of crashingItemParser: simple items, potions, old-format potions, and bannersTest plan
./gradlew testpassesRED_MUSHROOM:100, verify warning is logged and import succeeds with quantity clamped to 99🤖 Generated with Claude Code