Skip to content

fix(find-missing-jsonls): add native macOS and Linux path detection - #6

Merged
BasedGPT merged 1 commit into
BasedGPT:mainfrom
rpranjan11:fix/find-missing-jsonls-macos-path
May 30, 2026
Merged

BasedGPT merged 1 commit into
BasedGPT:mainfrom
rpranjan11:fix/find-missing-jsonls-macos-path

Conversation

@rpranjan11

Copy link
Copy Markdown
Contributor

find_missing_jsonls_in_backup.py was the only script not updated in
commit 0609930. diagnose.py and repair_session_metadata.py both
received native macOS/Linux path detection but this one was missed.

This PR applies the same _default_appdata_claude_dir() pattern already
used in repair_session_metadata.py for consistency, and restores the
PROJECTS_DIR constant that sits alongside it.

Tested on macOS (MacBook Pro M3). Output matches expected results.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first PR. Please confirm:

  • CI passes (fixture tests + sanitisation lint)
  • If you added a mutator, it has a matching fixture and passes the five mutator gates (see docs/architecture.md)
  • No personal paths, real UUIDs, or identifying info in committed files

@rpranjan11

Copy link
Copy Markdown
Contributor Author

Thanks for your first PR. Please confirm:

  • CI passes (fixture tests + sanitisation lint)
  • If you added a mutator, it has a matching fixture and passes the five mutator gates (see docs/architecture.md)
  • No personal paths, real UUIDs, or identifying info in committed files

CI commit check passes (✅ 28bad99). Fixture test workflows are awaiting maintainer approval to run — nothing I can action on my side.

Confirming the checklist:

  • CI: green commit check, fixture workflows pending maintainer approval to run
  • Mutator: not applicable — this is a read-only script, no mutator added
  • Personal info: diff contains only import platform and the _default_appdata_claude_dir() function — no personal paths, UUIDs, or identifying info

@BasedGPT
BasedGPT merged commit 6f77878 into BasedGPT:main May 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants