Skip to content

Fix: mean shape in compatible with input shape - #5719

Merged
Noiredd merged 1 commit into
BVLC:masterfrom
leemgs:upstream-issue5718
Nov 6, 2017
Merged

Fix: mean shape in compatible with input shape#5719
Noiredd merged 1 commit into
BVLC:masterfrom
leemgs:upstream-issue5718

Conversation

@leemgs

@leemgs leemgs commented Jun 29, 2017

Copy link
Copy Markdown
Contributor

@Noiredd

Noiredd commented Jun 29, 2017

Copy link
Copy Markdown
Member

👍, I remember having to hack a fix like that into every caffe installation in order to run my models. Would be really great to see it in stock.

@goodloop

goodloop commented Sep 5, 2017

Copy link
Copy Markdown

any problem with this pull request? why it have not been merged to master?

@Noiredd Noiredd added the focus label Oct 13, 2017
@Noiredd

Noiredd commented Oct 13, 2017

Copy link
Copy Markdown
Member

The only thing I don't like is the print statement - when bulk-testing multiple nets with their own transformers it generates a lot of doubtfully useful output, which tended to be rather annoying. But other than that, do we have anything this PR?

@leemgs

leemgs commented Oct 30, 2017

Copy link
Copy Markdown
Contributor Author

@Yangqing, @jeffdonahue, @shelhamer, Please, have a look at this.

@Noiredd

Noiredd commented Nov 2, 2017

Copy link
Copy Markdown
Member

@leemgs Please remove the print line and I will merge this.

@leemgs
leemgs force-pushed the upstream-issue5718 branch from 83f5482 to bfc638d Compare November 2, 2017 14:51
@leemgs

leemgs commented Nov 2, 2017

Copy link
Copy Markdown
Contributor Author

@Noiredd I have removed the print line. Then resubmitted PR with squash.

@Noiredd

Noiredd commented Nov 6, 2017

Copy link
Copy Markdown
Member

Thank you for the fix @leemgs!

@Noiredd
Noiredd merged commit 613e13b into BVLC:master Nov 6, 2017
XinYao1994 pushed a commit to XinYao1994/caffe that referenced this pull request Aug 29, 2018
Fix: mean shape incompatible with input shape
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants