Simplify DataTransform - #1328
Closed
sguada wants to merge 4 commits into
Closed
Conversation
Conflicts: include/caffe/data_transformer.hpp
There was a problem hiding this comment.
Where does Datatype come from? This line should be template <typename Dtype>.
Member
|
@sguada should this be closed or is it still part of the data plan? |
Contributor
Author
|
@shelhamer I think we should close this PR and when needed open a new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to unify the code for the different types of data (Datum, cv::Mat, Blob) to be transformed.
It adds the option to process vectors of data, persistency and state to the Transformer. Persistency as proposed in #1311 allows to apply the same transformation to different data. #1311 has been integrated here.
@longjon could you take a look? I cannot compile it due to some template error.