Skip to content

update proxy tests to build the url at runtime to avoid failing azdev scan - #71

Merged
jmccormick7 merged 1 commit into
mainfrom
mccormickjo/fix-azdev-credscan
Aug 10, 2026
Merged

jmccormick7 merged 1 commit into
mainfrom
mccormickjo/fix-azdev-credscan

Conversation

@jmccormick7

Copy link
Copy Markdown

azdev cred scan


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@github-actions

Copy link
Copy Markdown

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions

Copy link
Copy Markdown

@jmccormick7 jmccormick7 changed the title update proxy tests to build the url at runtime to avoid failing the update proxy tests to build the url at runtime to avoid failing azdev scan Aug 10, 2026
@jmccormick7

Copy link
Copy Markdown
Author

test_utils.py no longer flags for having secrets/credentials in the file.
image
test_utils.py was flagged for having secrets by the az dev pipeline run: https://dev.azure.com/azclitools/public/_build/results?buildId=336642&view=logs&jobId=a763532e-e1e4-51e7-f150-11e442419f5f&j=a763532e-e1e4-51e7-f150-11e442419f5f&t=37c61662-51af-58eb-5026-9f2fbee7b846

Secrets detected from src/connectedk8s/azext_connectedk8s/tests/unittests/test_utils_.py, Please remove or replace it. You can run 'azdev scan --confidence-level MEDIUM'/'azdev mask --confidence-level MEDIUM' locally to fix.

@jmccormick7
jmccormick7 merged commit b5ea25d into main Aug 10, 2026
9 of 11 checks passed
@jmccormick7
jmccormick7 deleted the mccormickjo/fix-azdev-credscan branch August 10, 2026 21:29
jmccormick7 added a commit that referenced this pull request Aug 10, 2026
)

azdev cred scan

Co-authored-by: John McCormick <mccormickjo@microsoft.com>
jmccormick7 added a commit that referenced this pull request Aug 13, 2026
)

azdev cred scan

Co-authored-by: John McCormick <mccormickjo@microsoft.com>
jmccormick7 added a commit that referenced this pull request Aug 13, 2026
)

azdev cred scan

Co-authored-by: John McCormick <mccormickjo@microsoft.com>
jmccormick7 added a commit that referenced this pull request Aug 13, 2026
)

azdev cred scan

Co-authored-by: John McCormick <mccormickjo@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants